From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6A3BEE7FDCB for ; Mon, 2 Feb 2026 20:01:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7894C10E276; Mon, 2 Feb 2026 20:01:45 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="fZLADw8E"; dkim-atps=neutral Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7159A10E276 for ; Mon, 2 Feb 2026 20:01:44 +0000 (UTC) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-4359a302794so3330795f8f.1 for ; Mon, 02 Feb 2026 12:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1770062503; x=1770667303; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=4hGFAoXoGcmWys+uUjHRPMoq6GYRS4Iplih/Yjd1Z5o=; b=fZLADw8EvxoKzR6U2czszCjCWm3divTHyHllmkQP7fNdI3bSxj60M4WMd21Hme0pXB BnMAHkZqscbvJtqe6t5s15bQZi05MSWjqDmt0OYVvCbpoaEAgPdVTGdOle7cIuN+LKbx +c6RfBEsQNgH4xDR7uCY+saXBXI+5lQHdG8VNc3qPkfc+NH/E1geI//jkypJaIkBjb/v lQIlpccuICWS/YYfH130JB77yb2KhmbBxit/HdoqDgiTwJlVqDkfaofM+Liv1v54lHzK Ib689w47WcG61DR88uF0a3AS3oQGhHGAAcOjyxhoyWJc13Hhcfo5C0RVlcMxPTLy2cal gCnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1770062503; x=1770667303; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4hGFAoXoGcmWys+uUjHRPMoq6GYRS4Iplih/Yjd1Z5o=; b=Mzgxe7fZi9GE4Q9djvgVLV3bx3FyHORVBj/Owj0Bn9XENw6ssq3NzIDjEVCHg9FWzm IypTtK65bTqhkUNVnX8MlbTxTY4u7MsOkYv7dDWiDnYuxkhI9aohNSs7TuH16O6uprdN Siu8VxSfe6NDpCa6Gjw4NIwpaxTQoQBjca9+orG5zvZUyz4Udoq+JwCF3SAmWoE3e0RO O0Y0AP6BSGguTSM0mbWQdiip+Ahg3PQE3OeUQuzHxZVPQt4Gm5lEnSfkBbJoVdkcCWmk cQcja4caxlPC2qV8NKDR6xKVMZhLoiG/DqxoSuLM5uOffl7Q5qoLR3qkazv3QkzX0Kdb /aeQ== X-Forwarded-Encrypted: i=1; AJvYcCXGkO1kzR/7YodJ882LbEInAfBOgU5diswBQBZxNmDafhMTOOBa9PzwcV4ICuEs/VG3IgYUilYv7sk=@lists.freedesktop.org X-Gm-Message-State: AOJu0YxH9APGHXtM9aQ3r3NU7AEEmiP6R0YzJs/+bUdLqvV7TdM61OER w5zcUFQ9DlpuIvVGvhs+GTa+lsvpjZqJd2qqyEf8HoB/dAgIuI7JbKC841FEgMMhlBY= X-Gm-Gg: AZuq6aLsQFYec0id2NMtW4/jrMlJg7gvucxHvyIzOlQZ5bv5JqBDnGsopoiS2JVFv/w gwxLACNUlxsnp8/t6/N12e6bY6cVCBYqBVeA12KSxdeFW6EASVj/edIFtKGX3+i/ccHV+8YWkS4 DVMhRYwS0c8cuwsiLCoK5b33yf61xXzmqcHhhqE1OpVmp5zTGMnkEQxZd0soyrNSdGs5iZcEroR g36K5dVc7oorLCdFeUDst1QL44+J608Sdau+L1y7hNSyLkwlNOMz1XZx/nHhnb/R4vPpAGiUHsd t0PAHuHvv53CAZSTvZ9Otq5OM6JLH+OtKGNK/7bhrQ6+M886BSyDa4SEjG+ChaCcQje9mcuCp85 a3vzjNb5F3eMlQdDaCD5YboWNYDtppVjoacmnuVCu5t4L+hk10cj49zNk3x6uhjI8NmApEmsnsY 4bfF3/PAK8CSyislsZ X-Received: by 2002:a05:600c:c162:b0:480:1b65:b741 with SMTP id 5b1f17b1804b1-482db4ac5bamr160582205e9.15.1770062502857; Mon, 02 Feb 2026 12:01:42 -0800 (PST) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-483051287cfsm19591905e9.6.2026.02.02.12.01.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Feb 2026 12:01:42 -0800 (PST) Date: Mon, 2 Feb 2026 23:01:39 +0300 From: Dan Carpenter To: KrishnaAgarwal1308 Cc: Andy Shevchenko , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: fix macro flow control warning and empty macro argument in fbtft-bus.c Message-ID: References: <20260202162826.116739-1-krishnaworkemail1308@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260202162826.116739-1-krishnaworkemail1308@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 02, 2026 at 09:58:26PM +0530, KrishnaAgarwal1308 wrote: > Fix checkpatch warning by adding identity modifier for define_fbtft_write_reg(). > No functional change. > This commit does two things. It introduces fbtft_identity() and it flips the if (ret < 0) condition around to avoid the goto inside a macro. Only the first change is mentioned in the commit message. I have see the fbtft_identity() approach before and I don't like it. https://lore.kernel.org/all/20250718191935.5918-2-abronzo@mac.com/ The name identity() doesn't mean anything. It's a real word and it has a meaning but it doesn't have a meaning which is at all related to this code. I think I would be okay with this the macro were called nop_endian() or cpu_to_cpu_endian() or something. Or another approach is to just leave the code as-is. Or maybe we could add a comment? Regarding the flipped condition, the new code is badly formatted and uglier than the original. I would prefer to leave it as-is. regards, dan carpenter