From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4DA9FEA7946 for ; Wed, 4 Feb 2026 21:10:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE24210E77B; Wed, 4 Feb 2026 21:10:18 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="ByZyaTLG"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id E1CBB10E779 for ; Wed, 4 Feb 2026 21:10:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770239417; x=1801775417; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=8BGUP+Fh8sJoIk+wDhGM6z4Q5hkH9tUOVqzPdwjSySk=; b=ByZyaTLGeLve+sVkxvNfGvuSBRx4NhWLSHuXdoznVcAvRrB7M0hbIWM+ yMq+bB+y5gt8GaYcCzHRtapEhWY+PbaSB9CFcDCyFjKqbMvcYiQi7+aUA 8+/wBRTLwUh9eIAs4zEaSJO7+buK0sBCpjWOoYA5Ylzi8b7KXMugGIId6 Q6bnto97FeuNsXqJ0iK0TA0gfGppqQbss5vXgTKYrBwxQvyqk83hphjhl po5oQRzcnkz0c8bgG9Bg+ghmlNjvL5JzwUWtXb8Fxi8MZf11Rk0WZYYvY 0IJH2LHcQVGF9rDmbRw1M7G2NvHDJPEKWAVzH53vzePxYKa1vpvIWFfyP g==; X-CSE-ConnectionGUID: kgGw5zg7QCCDlm5zSKKSvQ== X-CSE-MsgGUID: 2UjFS288SuCR/euiVQ2xCg== X-IronPort-AV: E=McAfee;i="6800,10657,11691"; a="81748675" X-IronPort-AV: E=Sophos;i="6.21,273,1763452800"; d="scan'208";a="81748675" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2026 13:10:17 -0800 X-CSE-ConnectionGUID: 7aeGqPOERc25kyYZt88EPg== X-CSE-MsgGUID: iAE4JCIoS9+oWNVbTP0NyQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,273,1763452800"; d="scan'208";a="214806959" Received: from pgcooper-mobl3.ger.corp.intel.com (HELO localhost) ([10.245.245.188]) by orviesa004-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Feb 2026 13:10:12 -0800 Date: Wed, 4 Feb 2026 23:10:09 +0200 From: Andy Shevchenko To: Cristian Ciocaltea Cc: Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Sandy Huang , Heiko =?iso-8859-1?Q?St=FCbner?= , Andy Yan , Louis Chauvet , Haneen Mohammed , Melissa Wen , Jani Nikula , Robert Mader , kernel@collabora.com, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Matt Roper , =?iso-8859-1?Q?N=EDcolas_F=2E_R=2E_A=2E?= Prado , Diederik de Haas Subject: Re: [PATCH v6 2/4] drm: Add CRTC background color property Message-ID: References: <20260129-rk3588-bgcolor-v6-0-c15f755a4055@collabora.com> <20260129-rk3588-bgcolor-v6-2-c15f755a4055@collabora.com> <97a4fd2d-62e2-41ad-8ee9-d2551c3ab312@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <97a4fd2d-62e2-41ad-8ee9-d2551c3ab312@collabora.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Feb 04, 2026 at 10:32:23PM +0200, Cristian Ciocaltea wrote: > On 1/29/26 11:37 AM, Andy Shevchenko wrote: > > On Thu, Jan 29, 2026 at 02:58:52AM +0200, Cristian Ciocaltea wrote: ... > >> +#define __DRM_ARGB64_PREP_BPC(c, shift, bpc)({ \ > > > > Not sure if this is an accepted style in DRM, by I find it difficult > > to follow. I would expect the "({" be on a separate line. > > I initially got confused by the plethora of different styles, e.g. in > "include/linux/math.h" we can find: > > #define rounddown(x, y) ( \ > [...] > > #define DIV_ROUND_CLOSEST_ULL(x, divisor)( \ > [...] > > #define mult_frac(x, n, d) \ > ({ \ > [...] > > #define abs_diff(a, b) ({ \ > [...] math.h is a collection of APIs from the past from different years and code, that's why the style is inconsistent (a lot!). So better not to take that as an example. > I agree your option is the most readable one, hence I used it consistently in > v7. Thanks! -- With Best Regards, Andy Shevchenko