From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6AA69EF06E2 for ; Sun, 8 Feb 2026 13:47:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 66DED10E102; Sun, 8 Feb 2026 13:47:02 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="OmO99yFt"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.15]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8970110E102 for ; Sun, 8 Feb 2026 13:47:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1770558421; x=1802094421; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=IfCx8FuhXcmPUmvEZWLLSa3nIj7MtGEd1V5PX3u5lZM=; b=OmO99yFtSzscFdeNuWAo2KZ69imyLJloyuB316ap+WYqdmsSH7UPT10K Ag5+iGMUL8C+OrBj6rxycXAkDJV9WEeCuL/lpR10j1nW6Xzwj8qxTlhpU JL16W1ntFY5oDnNVQcf3OO21520BK41/1ov2a38xAXBUrE9O1yDO5NmLL Zps1HEDxemIebUPAH9B/APfthPlDaEmWZqwAEAMmASzl3/BcZPih4m/Pk LI+Z1lpvMJm22xuiwi89A/I5TDR7nHB+swx1HMDuRJDDvHeF7+cfs3IdW Frp2XNBkULV80/4b1eNQtv55j+7ogp3tF+hA1Q4T31zTZf8c4lPJh+bs/ A==; X-CSE-ConnectionGUID: KPY0y7fYQpazPaWfraJ9UQ== X-CSE-MsgGUID: JseOsIqyQ8ayhgRR8Z12wQ== X-IronPort-AV: E=McAfee;i="6800,10657,11695"; a="75311516" X-IronPort-AV: E=Sophos;i="6.21,280,1763452800"; d="scan'208";a="75311516" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by orvoesa107.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2026 05:47:00 -0800 X-CSE-ConnectionGUID: U8Xf+RzOT8mH95qaZlMQEg== X-CSE-MsgGUID: xz95bUBSTYSkoWwIuVgdUA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,280,1763452800"; d="scan'208";a="211390967" Received: from fpallare-mobl4.ger.corp.intel.com (HELO localhost) ([10.245.245.100]) by orviesa007-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Feb 2026 05:46:57 -0800 Date: Sun, 8 Feb 2026 15:46:55 +0200 From: Andy Shevchenko To: Artem Lytkin Cc: Andy Shevchenko , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: fbtft: fix unchecked write return value in fb_agm1264k-fl Message-ID: References: <20260207220523.3816-1-iprintercanon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260207220523.3816-1-iprintercanon@gmail.com> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sat, Feb 07, 2026 at 10:05:23PM +0000, Artem Lytkin wrote: > The second call to par->fbtftops.write() does not capture the return > value, so the subsequent error check tests a stale value from the > first write call. Add the missing assignment so the error check > applies to the correct write operation. Hmm... Sounds about right, but it was like that from the day 1. Acked-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko