From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD00CF513F1 for ; Mon, 9 Mar 2026 09:12:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3556210E4AC; Mon, 9 Mar 2026 09:12:14 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="jHru3esd"; dkim=pass (2048-bit key; unprotected) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="I2Fxuc9d"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id D771C10E4AC for ; Mon, 9 Mar 2026 09:12:12 +0000 (UTC) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6298WDU33773276 for ; Mon, 9 Mar 2026 09:12:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=qcppdkim1; bh=xbMtvtdOfLDdatvp+5lzCch6 oMIueR07h2NcUioWpFw=; b=jHru3esdNzuncTNwyW211a+aJdCkYiYxILsoZN+3 1GwgTcHiMn/ymHOV08WINAfoWlfYw32mmtmF+Seo9nDBKL/8faTBqtOibVjY8T1b dgaY0uA7GYpKzy2BlixGrj6mN62goEwdjRuKoxo3BmtDppXIOIRCT3W6eZFhNujG NUVHihFT8lC0N4D4b9D4sUu9vqiYV7661k24lzZtWboU4mtxwP07+llelKSKDhOL XCCcln8fcMYU0Dbq9i5aXPPkIr1kAbbwT4ojrN+2XxrTTpUirMmL8EjgT/DODPGl DyxQTsHS6r2QOpA4ooTD4DOGq2QorD2Gt3YNLkNIxsnfsg== Received: from mail-qk1-f200.google.com (mail-qk1-f200.google.com [209.85.222.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cstsa857y-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 09 Mar 2026 09:12:11 +0000 (GMT) Received: by mail-qk1-f200.google.com with SMTP id af79cd13be357-8cd81be6f05so709493885a.2 for ; Mon, 09 Mar 2026 02:12:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773047531; x=1773652331; darn=lists.freedesktop.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=xbMtvtdOfLDdatvp+5lzCch6oMIueR07h2NcUioWpFw=; b=I2Fxuc9d1lJMy9ORQ+ani6CGOQnMHOpF+gaIyH8erNHErGxl8KFjn9Djvbi9wiJZ7u EAM5wptjrYOTkaJJcLqYSOGdnkvx8g6hVSlls3KbqYpXUGSTOwuOGVgPQgQYkB28yhsx zo1hwQEqpYXn8vYBNrbgD2UqcK47mw3NDA7TSdl4xU9ArJ3a1bfELns0sVt//SGWY3RQ vRg/7hp2MG2d2UqdRUa847PGJaT50TIhEyWz69nsjA7VY02IuEJbthN8Rw07ZfmR8965 cTuTxSOvEgYD34I1jl4fxG/Q4Tx4Mvr+ITkeKBrsBk2SgSKlqmJsp+juOsrB0pDnMSul id7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1773047531; x=1773652331; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xbMtvtdOfLDdatvp+5lzCch6oMIueR07h2NcUioWpFw=; b=DQH1+l8tNbNofZR8jfiTzBYhxboQ1icflleMKNLrQ5czIBQW069l2WwRgfRFtELjBI ipPqFi2fRNEFrNV4tK2RLNCU8wLs1SQojPCJnwiNEbpIJ5a18zy4AtUh1ksYwLBoJfgx SoSArBmNLUa3lUSYrfPBfa2YT6Cza4h4mBS/1qxhFJ0bamy5qDOoR5VjHDV5tVmp0s4W 8XMCfD2Ttq8MYvavue1LHyke9ry3ALklmQ7yn5nX+ngPGDwG+Kz/1GGfPM4Ms14gfM+C MvG2saCnNuAqUtunSxbbxn6PqXGzFeEM/uBSX+DfCOnZ80MAmCm0yryAmM6uThTSInRg pNKw== X-Forwarded-Encrypted: i=1; AJvYcCXFwxxQvFhs0ypjW4gj4w8kyFZFdsNTuSTUCTlJHguROmcbrN45V9dM5vmADtoZbdP13CZkVnvdahs=@lists.freedesktop.org X-Gm-Message-State: AOJu0Ywz+C2e0xRdTRFx0Y23EH6JKBCuVnwHAwddbqnH7LoJrYOsYg/L Wu9jqQtXvNVUbnIHyPkbIGzu7sc+PRqW4ieWN7hXQvzc/otONmVlO4RKia4RyElX6cqG3V/dvH9 qWUaeBHur9BlOq5wYBW3ZxCWubg17up+pyKXhUR7ltyDNGQnhyiURb/eP7Pv3bpJ1eLz6XzA= X-Gm-Gg: ATEYQzw4R2whI1hE/z+sQ1sMc2rlZT0UjGWvXTbCw6V3LDmVXc46jT1SZcCN41/w2jx arPCrYYL88IXfA2YsZTs++sPY/w/qlt92U95hsCjdVFbueEoSyNQhr+VbDYpnWdCveP+rT0YNPS BeFjkvSadO4i2Cz9NIqRUAoDNFc3NgoGSxpS2pGzV4EmWfHXjDYwuLUxLreZyh2yYZ0hOV7joRe CZ+dk4dykeI0SeIXZGUf5xRXTgFE3mhldpVEQHk/CXNHP04tkB/76pU8KU/0B0yqVOu0VQYklCU VSF2X5pLQQnpSK+OW7U0OXVuMhUMEqZEy4DCXE0fB/U7W21+uGmGR2VuH4Xl+a8PUVqgbOWkfBg 1JhA3nB3iMqtxJPWLJ/C8RzIs7ZbqtBHw8KNmzc8szeagYfldjC6yjQ== X-Received: by 2002:a05:620a:700a:b0:8c9:f9c1:5ed with SMTP id af79cd13be357-8cd6d4d541dmr1304569185a.63.1773047530899; Mon, 09 Mar 2026 02:12:10 -0700 (PDT) X-Received: by 2002:a05:620a:700a:b0:8c9:f9c1:5ed with SMTP id af79cd13be357-8cd6d4d541dmr1304566385a.63.1773047530429; Mon, 09 Mar 2026 02:12:10 -0700 (PDT) Received: from trex (110.red-81-38-138.dynamicip.rima-tde.net. [81.38.138.110]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-439dae483desm23179497f8f.34.2026.03.09.02.12.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Mar 2026 02:12:09 -0700 (PDT) From: Jorge Ramirez X-Google-Original-From: Jorge Ramirez Date: Mon, 9 Mar 2026 10:12:06 +0100 To: Sumit Garg Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-media@vger.kernel.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, ath12k@lists.infradead.org, linux-remoteproc@vger.kernel.org, andersson@kernel.org, konradybcio@kernel.org, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, robin.clark@oss.qualcomm.com, sean@poorly.run, akhilpo@oss.qualcomm.com, lumag@kernel.org, abhinav.kumar@linux.dev, jesszhan0024@gmail.com, marijn.suijten@somainline.org, airlied@gmail.com, simona@ffwll.ch, vikash.garodia@oss.qualcomm.com, dikshita.agarwal@oss.qualcomm.com, bod@kernel.org, mchehab@kernel.org, elder@kernel.org, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, jjohnson@kernel.org, mathieu.poirier@linaro.org, trilokkumar.soni@oss.qualcomm.com, mukesh.ojha@oss.qualcomm.com, pavan.kondeti@oss.qualcomm.com, jorge.ramirez@oss.qualcomm.com, tonyh@qti.qualcomm.com, vignesh.viswanathan@oss.qualcomm.com, srinivas.kandagatla@oss.qualcomm.com, amirreza.zarrabi@oss.qualcomm.com, jens.wiklander@linaro.org, op-tee@lists.trustedfirmware.org, apurupa@qti.qualcomm.com, skare@qti.qualcomm.com, Sumit Garg Subject: Re: [PATCH 11/14] media: qcom: Switch to generic PAS TZ APIs Message-ID: References: <20260306105027.290375-1-sumit.garg@kernel.org> <20260306105027.290375-12-sumit.garg@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260306105027.290375-12-sumit.garg@kernel.org> X-Proofpoint-GUID: 82x3WhOZ03uX5k439-LF6cHzPrKpA2E_ X-Authority-Analysis: v=2.4 cv=I+Vohdgg c=1 sm=1 tr=0 ts=69ae8eeb cx=c_pps a=hnmNkyzTK/kJ09Xio7VxxA==:117 a=P2IcWdTxk7sEx2G8DnB30w==:17 a=kj9zAlcOel0A:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=zah51VvIpe4vvf6E17kA:9 a=CjuIK1q_8ugA:10 a=PEH46H7Ffwr30OY-TuGO:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzA5MDA4NCBTYWx0ZWRfX+/wKRVCREZ4M qiX6bvz/EXztU7OOlLaKnIqQrmneH+GOO9TKROaXFrgfZncFcJMAuMJpK8BxoX/Zw4VJfLYpVM7 qJY+fAafiv6QFl6t3WEeFPNVmVVHlDW4j5XBTY0vdzl7Ygcyg6FfJl4AFPLIwbkgTQDtjLNUydz 6ZPyxz4CnmVqEqjuGxZMD/8hHlA8b4QQmzRguI8+uibOYslmqM5NSW6PsJHmOqYFTxxtthZ7ZeO Xb2HgJtfRkPjQ09wee/NSoVIgW6lmZE3XECxGIIbHwDBtVxB1aTRcX6wlJ+Rqsndp1TL9RnlpiS noHMpi4KRn2t6qcXerQyCvDpgzqojNzp2pPIb/LLdX+MN9Rcg2NcpyWYJi9nijFGseyBR+pcwxW 23HUaLlztiwg/AjqHrBwMkhhKAa+IbO7QylanZR51AECRqcs7dslB99G7NOjizUbH1wu71zrvmH c+JqfCCPFwhfNIkL0sg== X-Proofpoint-ORIG-GUID: 82x3WhOZ03uX5k439-LF6cHzPrKpA2E_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-09_03,2026-03-06_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 impostorscore=0 spamscore=0 malwarescore=0 suspectscore=0 bulkscore=0 lowpriorityscore=0 clxscore=1011 priorityscore=1501 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603090084 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 06/03/26 16:20:24, Sumit Garg wrote: > From: Sumit Garg > > Switch qcom media client drivers over to generic PAS TZ APIs. Generic PAS > TZ service allows to support multiple TZ implementation backends like QTEE > based SCM PAS service, OP-TEE based PAS service and any further future TZ > backend service. > > Signed-off-by: Sumit Garg > --- > drivers/media/platform/qcom/iris/iris_firmware.c | 9 +++++---- > drivers/media/platform/qcom/venus/firmware.c | 11 ++++++----- > 2 files changed, 11 insertions(+), 9 deletions(-) > > diff --git a/drivers/media/platform/qcom/iris/iris_firmware.c b/drivers/media/platform/qcom/iris/iris_firmware.c > index 5f408024e967..b3c5281aea91 100644 > --- a/drivers/media/platform/qcom/iris/iris_firmware.c > +++ b/drivers/media/platform/qcom/iris/iris_firmware.c > @@ -4,6 +4,7 @@ > */ > > #include > +#include > #include > #include > #include > @@ -79,7 +80,7 @@ int iris_fw_load(struct iris_core *core) > return -ENOMEM; > } > > - ret = qcom_scm_pas_auth_and_reset(core->iris_platform_data->pas_id); > + ret = qcom_pas_auth_and_reset(core->iris_platform_data->pas_id); > if (ret) { > dev_err(core->dev, "auth and reset failed: %d\n", ret); > return ret; > @@ -93,7 +94,7 @@ int iris_fw_load(struct iris_core *core) > cp_config->cp_nonpixel_size); > if (ret) { > dev_err(core->dev, "qcom_scm_mem_protect_video_var failed: %d\n", ret); > - qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); > + qcom_pas_shutdown(core->iris_platform_data->pas_id); > return ret; > } > } > @@ -103,10 +104,10 @@ int iris_fw_load(struct iris_core *core) > > int iris_fw_unload(struct iris_core *core) > { > - return qcom_scm_pas_shutdown(core->iris_platform_data->pas_id); > + return qcom_pas_shutdown(core->iris_platform_data->pas_id); > } > are the calls to set_remote_state required? 0 is not the IRIS/VENUS remote processor. If it is legacy, maybe they can be phased out? > int iris_set_hw_state(struct iris_core *core, bool resume) > { > - return qcom_scm_set_remote_state(resume, 0); > + return qcom_pas_set_remote_state(resume, 0); > } > diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c > index 1de7436713ed..3a38ff985822 100644 > --- a/drivers/media/platform/qcom/venus/firmware.c > +++ b/drivers/media/platform/qcom/venus/firmware.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -58,7 +59,7 @@ int venus_set_hw_state(struct venus_core *core, bool resume) > int ret; > > if (core->use_tz) { > - ret = qcom_scm_set_remote_state(resume, 0); > + ret = qcom_pas_set_remote_state(resume, 0); > if (resume && ret == -EINVAL) > ret = 0; > return ret;