From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 51D8AE9B342 for ; Mon, 2 Mar 2026 10:33:50 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0371C10E47D; Mon, 2 Mar 2026 10:33:49 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="QgncP8+O"; dkim-atps=neutral Received: from mail-wm1-f73.google.com (mail-wm1-f73.google.com [209.85.128.73]) by gabe.freedesktop.org (Postfix) with ESMTPS id DF0DA10E358 for ; Mon, 2 Mar 2026 10:33:47 +0000 (UTC) Received: by mail-wm1-f73.google.com with SMTP id 5b1f17b1804b1-4836bf1a920so45032865e9.3 for ; Mon, 02 Mar 2026 02:33:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772447626; x=1773052426; darn=lists.freedesktop.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=EnMgJMcaQgCDj7i00Uawlj/G1rJtXPwe1sCLwvhoFHI=; b=QgncP8+OhRI+4ZO8rEr1hLMqQCNpyPYa913C2g4NZbsFSKiVn4mIJpp/iEnsHZeO1E lsaodZ2LnkwcyNbCyQl9x/WxSwEfl66kj3zpjL7cOqjts5WkhS9y2JjM71pRyXlkwsS8 COQ/7JVp1OTD0YRFtLfJiKUOEHTNj9oWHJG5XQN+FsPBgK6zU559gnSx45TNjGnv7GOw nknTfDJVJ33lEAQooLqhMJHIozyy1xGkYf/XaG8yaBAu3om7YVvfkXeth/rDBAn/qxoG Mz9zsKFWJt0RDebkUB5Sh726qFrnvt5L744rYG6nPw8PogFWHzQojUmcJGixGN04fZ8x ZFmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772447626; x=1773052426; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=EnMgJMcaQgCDj7i00Uawlj/G1rJtXPwe1sCLwvhoFHI=; b=xJQKICFmFpRbDAb0zi95EPf3hXwnDZy0OFgrRfPQVXz09Lxz9jBJeMfAckxZe9k1bq LSwuotJgLblVPbX3oqQWhNgUlHHlG13+MFAbchE19utMK31NLHG9RyDJ4iI9Iwzd8P4R NJjLYhUO1Q+mO1qmB4M2OZhyhZiH7JQkJi02z0e6hL1yK9d50f394P8r3lGsCrThFwMW o4HmUTKS/SBIIOYkjAg0HQy+Be5ih92JnukzGRYbVqxiymxQeaN3J8zZVifUC41l0FSy ux0NLswX5BQtJiWIGE7R1txb3LhK6utRrYclP4dCi5tm6l62Z//kOiT3/lbNlj4QyTSv f45A== X-Forwarded-Encrypted: i=1; AJvYcCVNK5Bspm4VxxsuPPwBanNnetmv32Y6KDQ9P6O9MvVFDzv1n/C1AYj0Bzy5pUPPlxzBfPwwEYScwbY=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwKV2puXTpz3T4se/1kkKmN72QquQ3icB4BS+0E+kC4Lq+hkG/e 4vmQBpoDxgE+YzfJs2Khu/QajQ1S4rEuCv0qugsjrc2/lOqDlMBwMs/tNZ7qx72omU4PGusZyjY UtxazGYu/T/6z5YGQ8g== X-Received: from wmdd1.prod.google.com ([2002:a05:600c:a201:b0:480:3227:a124]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:6383:b0:47d:3ead:7440 with SMTP id 5b1f17b1804b1-483c9bdb683mr186031315e9.32.1772447625915; Mon, 02 Mar 2026 02:33:45 -0800 (PST) Date: Mon, 2 Mar 2026 10:33:45 +0000 In-Reply-To: Mime-Version: 1.0 References: <20260227200848.114019-1-david@kernel.org> <20260227200848.114019-3-david@kernel.org> <8a27e9ac-2025-4724-a46d-0a7c90894ba7@kernel.org> Message-ID: Subject: Re: [PATCH v1 02/16] mm/memory: remove "zap_details" parameter from zap_page_range_single() From: Alice Ryhl To: "David Hildenbrand (Arm)" Cc: linux-kernel@vger.kernel.org, "linux-mm @ kvack . org" , Andrew Morton , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Jann Horn , Pedro Falcato , David Rientjes , Shakeel Butt , "Matthew Wilcox (Oracle)" , Madhavan Srinivasan , Michael Ellerman , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Jarkko Sakkinen , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Greg Kroah-Hartman , "Arve =?utf-8?B?SGrDuG5uZXbDpWc=?=" , Todd Kjos , Christian Brauner , Carlos Llamas , Ian Abbott , H Hartley Sweeten , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Jason Gunthorpe , Leon Romanovsky , Dimitri Sivanich , Arnd Bergmann , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Andy Lutomirski , Vincenzo Frascino , Eric Dumazet , Neal Cardwell , "David S. Miller" , David Ahern , Jakub Kicinski , Paolo Abeni , Miguel Ojeda , linuxppc-dev@lists.ozlabs.org, kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-sgx@vger.kernel.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, netdev@vger.kernel.org, rust-for-linux@vger.kernel.org, x86@kernel.org Content-Type: text/plain; charset="utf-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Mar 02, 2026 at 11:27:40AM +0100, David Hildenbrand (Arm) wrote: > On 3/2/26 11:01, Alice Ryhl wrote: > > On Mon, Mar 02, 2026 at 09:18:45AM +0100, David Hildenbrand (Arm) wrote: > >> On 2/28/26 13:38, Alice Ryhl wrote: > >>> > >>> > >>> Please run rustfmt on Rust changes. Here, rustfmt leads to this being > >>> formatted on a single line: > >> > >> Having to run tooling I don't even have installed when removing a single > >> function parameter; did not expect that :) > > > > Well, rustfmt comes with the compiler, and it would be ideal to build > > test changes before sending them :) > > At least on Ubuntu on my notebook where I do most of the coding+patch > submissions it's a separate package? > > I do all my builds on a different (more powerful) machine where the > whole rust machinery's in place. Further, build bots that run on my > private branches did not report any issues. There are some build bots that check for rustfmt, though not all of them. > > But no worries, I took care of testing it. Thanks for taking the time to > > update the Rust code as well. > > I just did an allyesconfig and it does not report any warnings. > > So apparently, rustfmt problems not result in the compiler complaining? > > Or something else is off here that rust/kernel/mm/virt.rs won't get > compiled on my machine, even with allyesconfig. I can definitely see > some RUSTC stuff happening in the logs, like > > RUSTC L rust/kernel.o > > Thanks for the review and for pointing out rustfmt! Similar to kerneldoc and other similar targets, formatting isn't checked in the normal build, but make can be invoked on the rustfmtcheck target to check it. Alice