From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8B6FEA4E3D for ; Mon, 2 Mar 2026 16:46:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 09A2410E562; Mon, 2 Mar 2026 16:46:00 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="YSyysjbJ"; dkim-atps=neutral Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by gabe.freedesktop.org (Postfix) with ESMTPS id D21F610E562 for ; Mon, 2 Mar 2026 16:45:58 +0000 (UTC) Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-4837b6f6b93so33817305e9.3 for ; Mon, 02 Mar 2026 08:45:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1772469957; x=1773074757; darn=lists.freedesktop.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=sOpHk1BL+uJZfW7J1uTT7wM4CHb4+mXkf8VEbmZQIDI=; b=YSyysjbJ5JoyvwLLwtugR/VKFygQmyGVYr42QfHzpXuwWZUWHQAdzBFztl6em25vCw M5E/nChFdJHqE4tjJaNhIavPBWVu5la250MoXayooJodBNscInPdNw7qcl/L5V2IXyIq Az0bUdJKjPecGer/+ZMCZ6G+WoaA7xdaSX8d0j4paIIkJ1dnqdjPBB4p/YOZeGf6AUVM 5/FmimvBcfdZTvxTNfJFPwP0SNX6uR7g6UvoZImoWU93UmpSSEeLWrm8xnDgDTz7V0j+ gCIdgRSxk4TznfrKjtcO6jK0zXy/UJKisGXwd7eXQIyqTXTWYaviowlF7I7qlxMwI9mm OUSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772469957; x=1773074757; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sOpHk1BL+uJZfW7J1uTT7wM4CHb4+mXkf8VEbmZQIDI=; b=qhZbaP/xNKsLg9KFnTzpoVFm7f8YFqHbxgAWqtnQb9QcuWQaS41pcVCHjym2yjrR8r hVk0tKbGSxDWGm+2qins1KALuU8/Ruzw3jFvnjA2FAqZqLyDFjUHYF20zC+kBo69XI+U FQ7gHfX6/qqPgQYrPzTmwUObfGgneZ4qqG0cYs3DXMz017B+WIJ/mvREHQ8La+DS0oyS 02vx93dY2Mdv0QQFseVGon9tem/9CvgxQeSEyWzxaRc4QefCB7chqwcf+U1BF/2ngLHG PzPTPtVwn9iYEQuCa2S0A9N2TRF3jYdc9mGwNxVKeJ2qeTk/3ZP+cl7hSl37Bf/7veyX 9bfg== X-Gm-Message-State: AOJu0YwJrhG4dUxzTc5Yg+aNlePNelrBPBy6di+iQV82YVFBORy8siJ0 5kq7WK8f3AFG1IQELNtfc4jtSqnyQ4V6/rknxKLfasrfELhaNf0a4GXr9e3Kg2jTm3Tp1CwflWA 1kIeJwnuujAWEu82VdA== X-Received: from wmbg25.prod.google.com ([2002:a05:600c:a419:b0:483:6c98:3d2f]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:8b0c:b0:480:4b5d:9ec with SMTP id 5b1f17b1804b1-483c9bdd26dmr247647015e9.33.1772469957264; Mon, 02 Mar 2026 08:45:57 -0800 (PST) Date: Mon, 2 Mar 2026 16:45:56 +0000 In-Reply-To: <20260224002314.344675-1-deborah.brouwer@collabora.com> Mime-Version: 1.0 References: <20260224002314.344675-1-deborah.brouwer@collabora.com> Message-ID: Subject: Re: [PATCH v3] drm/tyr: Clarify driver/device type names From: Alice Ryhl To: Deborah Brouwer Cc: dri-devel@lists.freedesktop.org, rust-for-linux@vger.kernel.org, daniel.almeida@collabora.com, boris.brezillon@collabora.com, dakr@kernel.org Content-Type: text/plain; charset="utf-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Feb 23, 2026 at 04:23:14PM -0800, Deborah Brouwer wrote: > Currently the `TyrDriver` struct implements both `platform::Driver` and > `drm::Driver`. For clarity, split up these two roles: > - Introduce `TyrPlatformDriverData` to implement `platform::Driver`, and > - Introduce `TyrDrmDriver` to implement `drm::Driver`. > > Also rename other variables to reflect their roles in the DRM context: > - Rename `TyrDevice` to `TyrDrmDevice` > - Rename `TyrData` to `TyrDrmDeviceData` > - Rename `File` to `TyrDrmFileData` > - Rename `DrmFile` to `TyrDrmFile` > > No functional changes are intended. > > Co-developed-by: Boris Brezillon > Signed-off-by: Boris Brezillon > Signed-off-by: Deborah Brouwer I checked with Danilo who has no additional comments. Applied to drm-rust-next. Thanks!