From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8DC06C47095 for ; Mon, 7 Jun 2021 17:06:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E0A961029 for ; Mon, 7 Jun 2021 17:06:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E0A961029 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=shipmail.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 32A156E948; Mon, 7 Jun 2021 17:06:22 +0000 (UTC) Received: from pio-pvt-msa1.bahnhof.se (pio-pvt-msa1.bahnhof.se [79.136.2.40]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDB026E932 for ; Mon, 7 Jun 2021 17:06:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by pio-pvt-msa1.bahnhof.se (Postfix) with ESMTP id C60BD3F77A; Mon, 7 Jun 2021 19:06:16 +0200 (CEST) Authentication-Results: pio-pvt-msa1.bahnhof.se; dkim=pass (1024-bit key; unprotected) header.d=shipmail.org header.i=@shipmail.org header.b="YbUuMmd3"; dkim-atps=neutral X-Virus-Scanned: Debian amavisd-new at bahnhof.se Received: from pio-pvt-msa1.bahnhof.se ([127.0.0.1]) by localhost (pio-pvt-msa1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id tpTAEio_6tkm; Mon, 7 Jun 2021 19:06:15 +0200 (CEST) Received: by pio-pvt-msa1.bahnhof.se (Postfix) with ESMTPA id 816763F723; Mon, 7 Jun 2021 19:06:14 +0200 (CEST) Received: from [192.168.0.209] (unknown [192.55.55.41]) by mail1.shipmail.org (Postfix) with ESMTPSA id 881A73600BE; Mon, 7 Jun 2021 19:06:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=shipmail.org; s=mail; t=1623085574; bh=DZBdqxUxaWk6GVidM9JLsr69chUjuW6/Juo6jpAnrqA=; h=Subject:From:To:References:Date:In-Reply-To:From; b=YbUuMmd3oWemxfPaDFiHauO27Qan9km9apVbjgPzNNb8zQtuIIzcJF7q4G+H3JGNx EkJrHcZwWnjT732RAKM0w2jElBPA/sbIpKq8QGnR1ExsKdRby9Lkui08Y3NwxKSuUH zLR6WRud1CBKsLN2BwjNQr4G80e/Ya7h7P4CTCew= Subject: Re: [PATCH 01/10] drm/ttm: allocate resource object instead of embedding it v2 From: =?UTF-8?Q?Thomas_Hellstr=c3=b6m_=28Intel=29?= To: =?UTF-8?Q?Christian_K=c3=b6nig?= , matthew.auld@intel.com, dri-devel@lists.freedesktop.org References: <20210602100914.46246-1-christian.koenig@amd.com> Message-ID: Date: Mon, 7 Jun 2021 19:06:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 6/7/21 6:40 PM, Thomas Hellström (Intel) wrote: > > On 6/2/21 12:09 PM, Christian König wrote: > ... >> @@ -728,14 +728,15 @@ static int ttm_bo_add_move_fence(struct >> ttm_buffer_object *bo, >>    */ >>   static int ttm_bo_mem_force_space(struct ttm_buffer_object *bo, >>                     const struct ttm_place *place, >> -                  struct ttm_resource *mem, >> +                  struct ttm_resource **mem, >>                     struct ttm_operation_ctx *ctx) >>   { >>       struct ttm_device *bdev = bo->bdev; >> -    struct ttm_resource_manager *man = ttm_manager_type(bdev, >> mem->mem_type); >> +    struct ttm_resource_manager *man; >>       struct ww_acquire_ctx *ticket; >>       int ret; >>   +    man = ttm_manager_type(bdev, (*mem)->mem_type); > > Isn't (*mem) uninitialized here? Should be place->mem_type? Eviction > is immediately sent to the bushes. > > Got at least one additional NULL pointer deref to track down in the > eviction code, but could be a merge error of mine as well. Actually this last one was probably due to a bad temporary fix of the above one. /Thomas > >