From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4AA3C433F5 for ; Mon, 21 Feb 2022 14:31:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F3D5D10E4AB; Mon, 21 Feb 2022 14:31:11 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id B548B10E4AB for ; Mon, 21 Feb 2022 14:31:09 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 9BD311F437D2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1645453868; bh=N4Q5wrYBCEyiwQyMO1QGIB213vHWLXUeGyE8Au/Swq8=; h=Date:From:Subject:To:Cc:References:In-Reply-To:From; b=JRVIx99hM8g0lJMG67zLddemt5gjDyjZUbDkYQbSqtrBmsi82foU/EAk4UNAufyLe Y00fiAtDkBFmyCX+li9ig3sc1ZE8ftZNVDIvh1bVV58hAQvnEIpOry6qvo/xLRIcrD LI0EKe4zonX5xyEZRPM4ypRqrTc3pS5Q5KgL2cxbedw6jLN/5G4k+lM7TOdHvkl/BP 8UJU+RI26fI1cbrO4eWVN6ieNyqYWhk02U8pOMpbrJUKWEoqZ3yjLD9YvKFfIXHsZg y/oc6efDT4+LFvLxarPxYeEDexrDj7Tki1D2wlLI7SbWAjBm/5Yiuk8H6rM38Jc6xc Q2P67OHDdcqOA== Message-ID: Date: Mon, 21 Feb 2022 15:31:05 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 From: AngeloGioacchino Del Regno Subject: Re: [PATCH v8 09/19] drm/mediatek: dpi: move dimension_mask to board config To: Guillaume Ranquet , chunkuang.hu@kernel.org, p.zabel@pengutronix.de, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, matthias.bgg@gmail.com, chunfeng.yun@mediatek.com, kishon@ti.com, vkoul@kernel.org, deller@gmx.de, ck.hu@mediatek.com, jitao.shi@mediatek.com References: <20220218145437.18563-1-granquet@baylibre.com> <20220218145437.18563-10-granquet@baylibre.com> Content-Language: en-US In-Reply-To: <20220218145437.18563-10-granquet@baylibre.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Il 18/02/22 15:54, Guillaume Ranquet ha scritto: > Add flexibility by moving the dimension mask to board config > You should really fix both title and description for this commit, as this is moving hvsize_mask, not dimension_mask. Also, s/board/SoC/g. > Signed-off-by: Guillaume Ranquet > --- > drivers/gpu/drm/mediatek/mtk_dpi.c | 12 ++++++++++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/mediatek/mtk_dpi.c b/drivers/gpu/drm/mediatek/mtk_dpi.c > index 8ca3455ed64ee..0d3acd08ea358 100644 > --- a/drivers/gpu/drm/mediatek/mtk_dpi.c > +++ b/drivers/gpu/drm/mediatek/mtk_dpi.c > @@ -129,6 +129,8 @@ struct mtk_dpi_conf { > bool swap_input_support; > // Mask used for HWIDTH, HPORCH, VSYNC_WIDTH and VSYNC_PORCH (no shift) > u32 dimension_mask; > + // Mask used for HSIZE and VSIZE (no shift) C-style comments please > + u32 hvsize_mask; > const struct mtk_dpi_yc_limit *limit; > }; >