From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maarten Lankhorst Subject: Re: [PATCH v6 1/6] drm/i915/skl: Add support for the SAGV, fix underrun hangs Date: Wed, 3 Aug 2016 09:50:53 +0200 Message-ID: References: <1470177458-31984-1-git-send-email-cpaul@redhat.com> <1470177458-31984-2-git-send-email-cpaul@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1470177458-31984-2-git-send-email-cpaul@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Lyude , intel-gfx@lists.freedesktop.org, =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Matt Roper Cc: Daniel Vetter , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Daniel Vetter , stable@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T3AgMDMtMDgtMTYgb20gMDA6Mzcgc2NocmVlZiBMeXVkZToKPiBTaW5jZSB0aGUgd2F0ZXJtYXJr IGNhbGN1bGF0aW9ucyBmb3IgU2t5bGFrZSBhcmUgc3RpbGwgYnJva2VuLCB3ZSdyZSBhcHQKPiB0 byBoaXR0aW5nIHVuZGVycnVucyB2ZXJ5IGVhc2lseSB1bmRlciBtdWx0aS1tb25pdG9yIGNvbmZp Z3VyYXRpb25zLgo+IFdoaWxlIGl0IHdvdWxkIGJlIGxvdmVseSBpZiB0aGlzIHdhcyBmaXhlZCwg aXQncyBub3QuIEFub3RoZXIgcHJvYmxlbQo+IHRoYXQncyBiZWVuIGNvbWluZyBmcm9tIHRoaXMg aG93ZXZlciwgaXMgdGhlIG15c3RlcmlvdXMgaXNzdWUgb2YKPiB1bmRlcnJ1bnMgY2F1c2luZyBm dWxsIHN5c3RlbSBoYW5ncy4gQW4gZWFzeSB3YXkgdG8gcmVwcm9kdWNlIHRoaXMgd2l0aAo+IGEg c2t5bGFrZSBzeXN0ZW06Cj4KPiAtIEdldCBhIGxhcHRvcCB3aXRoIGEgc2t5bGFrZSBHUFUsIGFu ZCBob29rIHVwIHR3byBleHRlcm5hbCBtb25pdG9ycyB0bwo+ICAgaXQKPiAtIE1vdmUgdGhlIGN1 cnNvciBmcm9tIHRoZSBidWlsdC1pbiBMQ0QgdG8gb25lIG9mIHRoZSBleHRlcm5hbCBkaXNwbGF5 cwo+ICAgYXMgcXVpY2tseSBhcyB5b3UgY2FuCj4gLSBZb3UnbGwgZ2V0IGEgZmV3IHBpcGUgdW5k ZXJydW5zLCBhbmQgZXZlbnR1YWxseSB0aGUgZW50aXJlIHN5c3RlbSB3aWxsCj4gICBqdXN0IGZy ZWV6ZS4KPgo+IEFmdGVyIGRvaW5nIGEgbG90IG9mIGludmVzdGlnYXRpb24gYW5kIHJlYWRpbmcg dGhyb3VnaCB0aGUgYnNwZWMsIEkKPiBmb3VuZCB0aGUgZXhpc3RlbmNlIG9mIHRoZSBTQUdWLCB3 aGljaCBpcyByZXNwb25zaWJsZSBmb3IgYWRqdXN0aW5nIHRoZQo+IHN5c3RlbSBhZ2VudCB2b2x0 YWdlIGFuZCBjbG9jayBmcmVxdWVuY2llcyBkZXBlbmRpbmcgb24gaG93IG11Y2ggcG93ZXIKPiB3 ZSBuZWVkLiBBY2NvcmRpbmcgdG8gdGhlIGJzcGVjOgo+Cj4gIlRoZSBkaXNwbGF5IGVuZ2luZSBh Y2Nlc3MgdG8gc3lzdGVtIG1lbW9yeSBpcyBibG9ja2VkIGR1cmluZyB0aGUKPiAgYWRqdXN0bWVu dCB0aW1lLiBTQUdWIGRlZmF1bHRzIHRvIGVuYWJsZWQuIFNvZnR3YXJlIG11c3QgdXNlIHRoZQo+ ICBHVC1kcml2ZXIgcGNvZGUgbWFpbGJveCB0byBkaXNhYmxlIFNBR1Ygd2hlbiB0aGUgZGlzcGxh eSBlbmdpbmUgaXMgbm90Cj4gIGFibGUgdG8gdG9sZXJhdGUgdGhlIGJsb2NraW5nIHRpbWUuIgo+ Cj4gVGhlIHJlc3Qgb2YgdGhlIGJzcGVjIGdvZXMgb24gdG8gZXhwbGFpbiB0aGF0IHNvZnR3YXJl IGNhbiBzaW1wbHkgbGVhdmUKPiB0aGUgU0FHViBlbmFibGVkLCBhbmQgZGlzYWJsZSBpdCB3aGVu IHdlIHVzZSBpbnRlcmxhY2VkIHBpcGVzL2hhdmUgbW9yZQo+IHRoZW4gb25lIHBpcGUgYWN0aXZl Lgo+Cj4gU3VyZSBlbm91Z2gsIHdpdGggdGhpcyBwYXRjaHNldCB0aGUgc3lzdGVtIGhhbmdzIHJl c3VsdGluZyBmcm9tIHBpcGUKPiB1bmRlcnJ1bnMgb24gU2t5bGFrZSBoYXZlIGNvbXBsZXRlbHkg dmFuaXNoZWQgb24gbXkgVDQ2MHMuIEFkZGl0aW9uYWxseSwKPiB0aGUgYnNwZWMgbWVudGlvbnMg dHVybmluZyBvZmYgdGhlIFNBR1YJd2l0aCBtb3JlIHRoZW4gb25lIHBpcGUgZW5hYmxlZAo+IGFz IGEgd29ya2Fyb3VuZCBmb3IgZGlzcGxheSB1bmRlcnJ1bnMuIFdoaWxlIHRoaXMgcGF0Y2ggZG9l c24ndCBlbnRpcmVseQo+IGZpeCB0aGF0LCBpdCBsb29rcyBsaWtlIGl0IGRvZXMgaW1wcm92ZSB0 aGUgc2l0dWF0aW9uIGEgbGl0dGxlIGJpdCBzbwo+IGl0J3MgbGlrZWx5IHRoaXMgaXMgZ29pbmcg dG8gYmUgcmVxdWlyZWQgdG8gbWFrZSB3YXRlcm1hcmtzIG9uIFNreWxha2UKPiBmdWxseSBmdW5j dGlvbmFsLgo+Cj4gQ2hhbmdlcyBzaW5jZSB2NToKPiAgLSBEb24ndCB1c2UgaXNfcG93ZXJfb2Zf Mi4gTWFrZXMgdGhpbmdzIGNvbmZ1c2luZwo+ICAtIERvbid0IHVzZSB0aGUgb2xkIHN0YXRlIHRv IGZpZ3VyZSBvdXQgd2hldGhlciBvciBub3QgdG8KPiAgICBlbmFibGUvZGlzYWJsZSB0aGUgc2Fn diwgdXNlIHRoZSBuZXcgb25lCj4gIC0gU3BsaXQgdGhlIGxvb3AgaW4gc2tsX2Rpc2FibGVfc2Fn diBpbnRvIGl0J3Mgb3duIGZ1bmN0aW9uCj4gIC0gTW92ZSBza2xfc2Fndl9lbmFibGUvZGlzYWJs ZSgpIGNhbGxzIGludG8gaW50ZWxfYXRvbWljX2NvbW1pdF90YWlsKCkKPiBDaGFuZ2VzIHNpbmNl IHY0Ogo+ICAtIFVzZSBpc19wb3dlcl9vZl8yIGFnYWluc3QgYWN0aXZlX2NydGNzIHRvIGNoZWNr IHdoZXRoZXIgd2UgaGF2ZSA+IDEKPiAgICBwaXBlIGVuYWJsZWQKPiAgLSBGaXggc2tsX3NhZ3Zf Z2V0X2h3X3N0YXRlKCk6ICh0ZW1wICYgMHgxKSBpbmRpY2F0ZXMgZGlzYWJsZWQsIDB4MAo+ICAg IGVuYWJsZWQKPiAgLSBDYWxsIHNrbF9zYWd2X2VuYWJsZS9kaXNhYmxlKCkgZnJvbSBwcmUvcG9z dC1wbGFuZSB1cGRhdGVzCj4gQ2hhbmdlcyBzaW5jZSB2MzoKPiAgLSBVc2UgdGltZV9iZWZvcmUo KSB0byBjb21wYXJlIHRpbWVvdXQgdG8gamlmZmllcwo+IENoYW5nZXMgc2luY2UgdjI6Cj4gIC0g UmVhbGx5IGFwcGx5IG1pbm9yIHN0eWxlIG5pdHBpY2tzIHRvIHBhdGNoIHRoaXMgdGltZQo+IENo YW5nZXMgc2luY2UgdjE6Cj4gIC0gQWRkZWQgY29tbWVudHMgYWJvdXQgdGhpcyBwcm9iYWJseSBi ZWluZyBvbmUgb2YgdGhlIHJlcXVpcmVtZW50cyB0bwo+ICAgIGZpeGluZyBTa3lsYWtlJ3Mgd2F0 ZXJtYXJrIGlzc3Vlcwo+ICAtIE1pbm9yIHN0eWxlIG5pdHBpY2tzIGZyb20gTWF0dCBSb3Blcgo+ ICAtIERpc2FibGUgdGhlc2UgZnVuY3Rpb25zIG9uIEJyb3h0b24sIHNpbmNlIGl0IGRvZXNuJ3Qg aGF2ZSBhbiBTQUdWCj4KPiBSZXZpZXdlZC1ieTogTWF0dCBSb3BlciA8bWF0dGhldy5kLnJvcGVy QGludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSA8Y3BhdWxAcmVkaGF0LmNvbT4KPiBD YzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZndsbC5jaD4KPiBDYzogVmlsbGUgU3ly asOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiBDYzogc3RhYmxlQHZnZXIu a2VybmVsLm9yZwo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oICAgICAg fCAgIDIgKwo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oICAgICAgfCAgIDUgKysK PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwgIDExICsrKysKPiAgZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmggICAgIHwgICAyICsKPiAgZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfcG0uYyAgICAgIHwgMTEyICsrKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrCj4gIDUgZmlsZXMgY2hhbmdlZCwgMTMyIGluc2VydGlvbnMoKykKPgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rydi5oIGIvZHJpdmVycy9ncHUvZHJt L2k5MTUvaTkxNV9kcnYuaAo+IGluZGV4IDY1YWRhNWQuLjg3MDE4ZDMgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2k5MTVfZHJ2LmgKPiBAQCAtMTk2Miw2ICsxOTYyLDggQEAgc3RydWN0IGRybV9pOTE1X3By aXZhdGUgewo+ICAJc3RydWN0IGk5MTVfc3VzcGVuZF9zYXZlZF9yZWdpc3RlcnMgcmVnZmlsZTsK PiAgCXN0cnVjdCB2bHZfczBpeF9zdGF0ZSB2bHZfczBpeF9zdGF0ZTsKPiAgCj4gKwlib29sIHNr bF9zYWd2X2VuYWJsZWQ7Cj4gKwo+ICAJc3RydWN0IHsKPiAgCQkvKgo+ICAJCSAqIFJhdyB3YXRl cm1hcmsgbGF0ZW5jeSB2YWx1ZXM6Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2k5MTVfcmVnLmggYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4gaW5kZXggMmY5 M2Q0YS4uNWZiMWM2MyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl Zy5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+IEBAIC03MTcwLDYg KzcxNzAsMTEgQEAgZW51bSB7Cj4gICNkZWZpbmUgICBIU1dfUENPREVfREVfV1JJVEVfRlJFUV9S RVEJCTB4MTcKPiAgI2RlZmluZSAgIERJU1BMQVlfSVBTX0NPTlRST0wJCQkweDE5Cj4gICNkZWZp bmUJICBIU1dfUENPREVfRFlOQU1JQ19EVVRZX0NZQ0xFX0NPTlRST0wJMHgxQQo+ICsjZGVmaW5l ICAgR0VOOV9QQ09ERV9TQUdWX0NPTlRST0wJCTB4MjEKPiArI2RlZmluZSAgICAgR0VOOV9TQUdW X0RJU0FCTEUJCQkweDAKPiArI2RlZmluZSAgICAgR0VOOV9TQUdWX0xPV19GUkVRCQkJMHgxCj4g KyNkZWZpbmUgICAgIEdFTjlfU0FHVl9ISUdIX0ZSRVEJCQkweDIKPiArI2RlZmluZSAgICAgR0VO OV9TQUdWX0RZTkFNSUNfRlJFUSAgICAgICAgICAgICAgMHgzCj4gICNkZWZpbmUgR0VONl9QQ09E RV9EQVRBCQkJCV9NTUlPKDB4MTM4MTI4KQo+ICAjZGVmaW5lICAgR0VONl9QQ09ERV9GUkVRX0lB X1JBVElPX1NISUZUCTgKPiAgI2RlZmluZSAgIEdFTjZfUENPREVfRlJFUV9SSU5HX1JBVElPX1NI SUZUCTE2Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXku YyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IGE4ZThjYzgu LjAwMWM4ODUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTEz NjkyLDYgKzEzNjkyLDE0IEBAIHN0YXRpYyB2b2lkIGludGVsX2F0b21pY19jb21taXRfdGFpbChz dHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIAkJICAgICBpbnRlbF9zdGF0ZS0+Y2Rj bGtfcGxsX3ZjbyAhPSBkZXZfcHJpdi0+Y2RjbGtfcGxsLnZjbykpCj4gIAkJCWRldl9wcml2LT5k aXNwbGF5Lm1vZGVzZXRfY29tbWl0X2NkY2xrKHN0YXRlKTsKPiAgCj4gKwkJLyoKPiArCQkgKiBT S0wgd29ya2Fyb3VuZDogYnNwZWMgcmVjb21tZW5kcyB3ZSBkaXNhYmxlIHRoZSBTQUdWIHdoZW4g d2UKPiArCQkgKiBoYXZlIG1vcmUgdGhlbiBvbmUgcGlwZSBlbmFibGVkCj4gKwkJICovCj4gKwkJ aWYgKElTX1NLWUxBS0UoZGV2X3ByaXYpICYmCj4gKwkJICAgIGh3ZWlnaHQzMihpbnRlbF9zdGF0 ZS0+YWN0aXZlX2NydGNzKSA+IDEpCj4gKwkJCXNrbF9kaXNhYmxlX3NhZ3YoZGV2X3ByaXYpOwo+ ICAJCWludGVsX21vZGVzZXRfdmVyaWZ5X2Rpc2FibGVkKGRldik7Cj4gIAl9Cj4gIAo+IEBAIC0x Mzc2NSw2ICsxMzc3Myw5IEBAIHN0YXRpYyB2b2lkIGludGVsX2F0b21pY19jb21taXRfdGFpbChz dHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIAkJaW50ZWxfbW9kZXNldF92ZXJpZnlf Y3J0YyhjcnRjLCBvbGRfY3J0Y19zdGF0ZSwgY3J0Yy0+c3RhdGUpOwo+ICAJfQo+ICAKPiArCWlm IChod2VpZ2h0MzIoaW50ZWxfc3RhdGUtPmFjdGl2ZV9jcnRjcykgPD0gMSkKPiArCQlza2xfZW5h YmxlX3NhZ3YoZGV2X3ByaXYpOwpTaG91bGQgYmUgZ3VhcmRlZCB3aXRoIGEgaWYgKGludGVsX3N0 YXRlLT5tb2Rlc2V0ICYmCgpMb29rcyBvayBvdGhlcndpc2UuIDotKQoKV2l0aCB0aGF0IGZpeGVk OgoKUmV2aWV3ZWQtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51 eC5pbnRlbC5jb20+Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=