public inbox for dri-devel@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, jouni.hogander@intel.com,
	animesh.manna@intel.com
Subject: Re: [PATCH 13/23] drm/i915/psr: Add helper to get Async Video timing support in PR active
Date: Thu, 2 Apr 2026 13:24:28 +0300	[thread overview]
Message-ID: <ac5D3IJnVfx6Xpdn@intel.com> (raw)
In-Reply-To: <20260402080425.548702-14-ankit.k.nautiyal@intel.com>

On Thu, Apr 02, 2026 at 01:34:13PM +0530, Ankit Nautiyal wrote:
> Introduce a helper to check if Panel Replay has Async Video Timing support
> during PR Active state.
> 
> Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_psr.c | 8 ++++++++
>  drivers/gpu/drm/i915/display/intel_psr.h | 1 +
>  2 files changed, 9 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 2f1b48cd8efd..782e839b7396 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -4623,3 +4623,11 @@ bool intel_psr_use_trans_push(const struct intel_crtc_state *crtc_state)
>  
>  	return HAS_PSR_TRANS_PUSH_FRAME_CHANGE(display) && crtc_state->has_psr;
>  }
> +
> +bool intel_psr_pr_async_video_timing_supported(struct intel_dp *intel_dp)
> +{
> +	struct intel_connector *connector = intel_dp->attached_connector;
> +

I think we also need to confirm here that panel replay itself
is supported by the sink. Otherwise this bit will for sure be
zero and then we'll think that we need to transmit AS SDP
even for non-PR sinks.

> +	return !(connector->dp.panel_replay_caps.dpcd[INTEL_PR_DPCD_INDEX(DP_PANEL_REPLAY_CAP_CAPABILITY)] &
> +		 DP_PANEL_REPLAY_ASYNC_VIDEO_TIMING_NOT_SUPPORTED_IN_PR);
> +}
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.h b/drivers/gpu/drm/i915/display/intel_psr.h
> index 394b641840b3..29723e63888f 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.h
> +++ b/drivers/gpu/drm/i915/display/intel_psr.h
> @@ -86,5 +86,6 @@ void intel_psr_compute_config_late(struct intel_dp *intel_dp,
>  				   struct intel_crtc_state *crtc_state);
>  int intel_psr_min_guardband(struct intel_crtc_state *crtc_state);
>  bool intel_psr_use_trans_push(const struct intel_crtc_state *crtc_state);
> +bool intel_psr_pr_async_video_timing_supported(struct intel_dp *intel_dp);
>  
>  #endif /* __INTEL_PSR_H__ */
> -- 
> 2.45.2

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2026-04-02 10:24 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-02  8:04 [PATCH 00/23] Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 01/23] drm/dp: Rename and relocate AS SDP payload field masks Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 02/23] drm/dp: Clean up DPRX feature enumeration macros Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 03/23] drm/dp: Add bits for AS SDP FAVT Payload Fields Parsing support Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 04/23] drm/dp: Add DPCD for configuring AS SDP for PR + VRR Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 05/23] drm/dp: Store coasting vtotal in struct drm_dp_as_sdp Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 06/23] drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 07/23] drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 08/23] drm/i915/dp: Account for AS_SDP guardband only when enabled Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 09/23] drm/i915/dp: Add a helper to decide if AS SDP can be used Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 10/23] drm/i915/dp: Skip AS SDP for DP branch devices Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 11/23] drm/i915/dp: Use revision field of AS SDP data structure Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 12/23] drm/i915/dp: Include all relevant AS SDP fields in comparison Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 13/23] drm/i915/psr: Add helper to get Async Video timing support in PR active Ankit Nautiyal
2026-04-02 10:24   ` Ville Syrjälä [this message]
2026-04-02  8:04 ` [PATCH 14/23] drm/i915/dp: Add member to intel_dp to store AS SDP v2 support Ankit Nautiyal
2026-04-02 11:04   ` Ville Syrjälä
2026-04-02 12:50     ` Ville Syrjälä
2026-04-07  8:20       ` Nautiyal, Ankit K
2026-04-07 13:35         ` Nautiyal, Ankit K
2026-04-07 15:15           ` Ville Syrjälä
2026-04-02  8:04 ` [PATCH 15/23] drm/i915/dp: Allow AS SDP only if v2 is supported Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 16/23] drm/i915/psr: Write the PR config DPCDs in burst mode Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 17/23] drm/i915/display: Add helper for AS SDP transmission time selection Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 18/23] drm/i915/psr: Program Panel Replay CONFIG3 using AS SDP transmission time Ankit Nautiyal
2026-04-02 10:30   ` Ville Syrjälä
2026-04-02  8:04 ` [PATCH 19/23] drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM Ankit Nautiyal
2026-04-02 10:48   ` Ville Syrjälä
2026-04-07  8:51     ` Nautiyal, Ankit K
2026-04-07  9:06       ` Nautiyal, Ankit K
2026-04-02  8:04 ` [PATCH 20/23] drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 21/23] drm/i915/dp: Split AS SDP computation between compute_config and compute_config_late Ankit Nautiyal
2026-04-02  8:04 ` [PATCH 22/23] drm/i915/dp: Compute and include coasting vtotal for AS SDP Ankit Nautiyal
2026-04-02 11:10   ` Ville Syrjälä
2026-04-07 10:54     ` Nautiyal, Ankit K
2026-04-07 10:56       ` Nautiyal, Ankit K
2026-04-07 15:40         ` Ville Syrjälä
2026-04-02  8:04 ` [PATCH 23/23] drm/i915/dp: Always enable AS SDP if supported by source + sink Ankit Nautiyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ac5D3IJnVfx6Xpdn@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=animesh.manna@intel.com \
    --cc=ankit.k.nautiyal@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jouni.hogander@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox