Re: [PATCH] drm/virtgpu: Add PM support for suspend/resume

[Dmitry Osipenko <dmitry.osipenko@collabora.com>]

On 4/17/26 12:40, Morris Pan (潘泰為) wrote:
> On Wed, 2026-04-08 at 15:59 +0300, Dmitry Osipenko wrote:
>> Hi,
>>
>> On 4/1/26 09:10, Morris Pan wrote:
>>> diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c
>>> b/drivers/gpu/drm/virtio/virtgpu_drv.c
>>> index a5ce96fb8a1d..fbca0a82958c 100644
>>> --- a/drivers/gpu/drm/virtio/virtgpu_drv.c
>>> +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c
>>> @@ -145,6 +145,40 @@ static void virtio_gpu_config_changed(struct
>>> virtio_device *vdev)
>>>  	schedule_work(&vgdev->config_changed_work);
>>>  }
>>>  
>>> +#ifdef CONFIG_PM_SLEEP
>>> +static int virtgpu_freeze(struct virtio_device *vdev)
>>> +{
>>> +	vdev->config->del_vqs(vdev);
>>> +	virtio_reset_device(vdev);
>>> +
>>> +	return 0;
>>> +}
>>
>> VirtIO-GPU shouldn't be reset freely. See [1] and follow previous
>> hibernation-support discussions on the ML.
>>
>> [1[
>> https://lore.kernel.org/dri-devel/20260107182745.229481-1-dongwon.kim@intel.com/
>>  
>>
> 
> Hi Dmitry,
> 
> Thank you for the guidance and for pointing me to that thread.
> 
> I have looked into the series you mentioned, specifically "PATCH v7
> 1/3: drm/virtio: Freeze and restore hooks to support suspend and
> resume" (link).
> I have verified that this change resolves the issue I was experiencing
> in my envirronment.
> 
> I will keep an eye on that series and follow its progress. Thank you
> for your time and help.

You're welcome. There is now v8 sent by Kim [2], feel free to test it
and reply with your review and/or tested-by on the patches.

[2]
https://lore.kernel.org/dri-devel/20260429204729.993669-1-dongwon.kim@intel.com/

-- 
Best regards,
Dmitry