From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9EFAC83F26 for ; Thu, 24 Jul 2025 11:39:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 362C510E1F5; Thu, 24 Jul 2025 11:39:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=qualcomm.com header.i=@qualcomm.com header.b="btqezY8p"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5281D10E934 for ; Thu, 24 Jul 2025 11:39:31 +0000 (UTC) Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 56O9J15u022078 for ; Thu, 24 Jul 2025 11:39:30 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oqSerAH08mV+bu18I/AJbmlNy8XOCWAaqntFX3ows/0=; b=btqezY8pJgbADaRU scEYcRojeNpyXK+P8q8dFPu5gGoh7D/jOaR/MtgR4VpicfK4BCZ85M2rrImgK7kJ Ec0Q+znmi4C1uN7BzyrhTSFx6VauxEkKxHhRSRnm+fHeM90yyQ4Ve2rho90VofRK xly/1DSOsAqhafmpoRD67mxKDypFGkhs0pHWwlnU/WzLPtErI6oBYNJnQ0YT71SB tb9lYpdHBgEXRBoD8nCAI3gHQKZwzqXcDNGzlMAC2j1OfzXBym1EmEA3Fyy0f+yC omV67354n7tPn5p3Uf7SgMxm/NE8hF+SVx6Lgaj3fo2FEzROiTNZkLJLVYmMzqnS XigT7w== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 48313kk7m7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 24 Jul 2025 11:39:30 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-4ae762426d8so749211cf.2 for ; Thu, 24 Jul 2025 04:39:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753357169; x=1753961969; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=oqSerAH08mV+bu18I/AJbmlNy8XOCWAaqntFX3ows/0=; b=PGAgsU+odQb8/cJf0h2qbD4IES/1+EngxI2WMacPLnSkkmZ473S+H2B+dDF8HNOlds Npty+BJ+GvNpTAaVnZOSRKNbAD0B4SNRiTgz4lf536upK24eRw6Vmou0X0RU7bpRGeHU oE6xRcJB+4OCZJWKSzurFxMBAlU0QVuC0thaoCHVKa/5q4J/r+TbKHXHLuSJbTl38V5D d6JrYq5zvBZbpydS/U1gGSRrL8PRAX/2G1VS136bGncZ4sFmv6cS6FnN7I/sMd4MIwNy 5F69fTPu1SE4PHkx7iGs2Ght85ib/yxVCrUnJafjReau/xyfPFv5tA89+jBy9uEnGKJs ozyQ== X-Forwarded-Encrypted: i=1; AJvYcCWbQRO+SouA1N+O2hlhPmHGqTrFr+9ie0plfdt5wadPFiLgkB1yoLS9hPqlPM+SjwTkDd9y9a+OqqQ=@lists.freedesktop.org X-Gm-Message-State: AOJu0YyaY7/2+lUvJlvxpXIaNvZ9jGVU4wSuRsyoNWwoEuBLr4slmMUo WLko1WczXf8Z0PkhBkmtX4/BEOWljilDvNJ7BNig6M3R8l3TcnP9RfoHpkerk+RTygfJAzD6InB C9thJUX+VHqsE7i1hQYRgak5WVYjSXS8LfWPsnV0LAzCrUZ+msi/3tvzzZ5BuklYqDL+/FFo= X-Gm-Gg: ASbGncuneHvXqYTc+Ajep90/N8LQtyTenFmWPCKljbvCGDdG+liLcz4qpNRMgigD5hX KtJpTn+m+oE43le7a3ybzAAv15uXkTl+eYs4zAufvb8heUIzat9YRtR9OTvx3zUkkkcz7RzCJ4+ u3Nv+IHDoOm7Y1/8QjsU/ySBZdtg8ZtwMPPCaS8XQfgqSpVVIJlKpyBRB1AubqiEs9Wz6RRdyzk KferXvEG2VxdDi5FX0CYh22A5dA/Z6NL+ZD9VAivOA/i9Gf6oD3Q3pTRSrH+pCz+ptBpPBzKlD+ TmMsqfBTvQ8rFblZMZiFCUXrAticYQag7D/NdmXhJKxCcb2Q3z6oS6+ptWOc6LehNTv9U4brdep CvoN43c++/5BBmHnsfw== X-Received: by 2002:a05:620a:1010:b0:7e2:ee89:2059 with SMTP id af79cd13be357-7e62a161c98mr301780585a.4.1753357169373; Thu, 24 Jul 2025 04:39:29 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHrXXj7nS41J4tzvt5vYVWROB7LrrdrXAgkyDwKGD/CaWyzImC+WopFcS+OfvIBt6ZwiO1KzA== X-Received: by 2002:a05:620a:1010:b0:7e2:ee89:2059 with SMTP id af79cd13be357-7e62a161c98mr301778885a.4.1753357168938; Thu, 24 Jul 2025 04:39:28 -0700 (PDT) Received: from [192.168.43.16] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-614cd31ac41sm703041a12.54.2025.07.24.04.39.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Jul 2025 04:39:28 -0700 (PDT) Message-ID: Date: Thu, 24 Jul 2025 13:39:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/17] drm/msm/a6xx: Poll additional DRV status To: Akhil P Oommen , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter Cc: linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20250720-ifpc-support-v1-0-9347aa5bcbd6@oss.qualcomm.com> <20250720-ifpc-support-v1-4-9347aa5bcbd6@oss.qualcomm.com> <9778efad-e9a8-4934-9b70-b0429bcfe63e@oss.qualcomm.com> <002eb889-87cb-4b8c-98fb-6826c6977868@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <002eb889-87cb-4b8c-98fb-6826c6977868@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNzI0MDA4NyBTYWx0ZWRfX9OddT97pfp2P 8HJxGghbVGH9wEzsxc5/FxwZxjEyPhfdOgOJoK3h+HztsSmBC8kqGtvjEjF2BArj4lRJi5jflir OsZxFRAhUUjdsmhwBlj4gtWaoY03XVO5TfrRQTLoUx69kLtWcrG85r5UjFSpHiDxXk8c0iUW3Bl HaBhXsv10s78A1f2UtvU3pnl2mGo7aaXmvdTMp2FgKX2MLDg4Zc/7PDG35q21GKcqVS8tOHVHcr xD1AESCizYhlnu76izkwKopwT29mTzROQfzqW4wvCtwbvyx+uW9Mr8wHIo5NYYJHrJIPQt2F8wj 2j/t3Y0Geu8VwqhNgbe63j7EP3khi09RjgFpNlt1E+0TVbKqBCtUDWb38QtzUXxX4Vwt0EpzM7+ glDhqo2Hg9loP7qyMlRa2dfhjcX2yEQfsncdr123X0s9U1d18MNCbnKvhtij054ycZMBDRc9 X-Proofpoint-ORIG-GUID: pQD6p4TbyUVeYRoya_HG1rgvrGYJa__Q X-Proofpoint-GUID: pQD6p4TbyUVeYRoya_HG1rgvrGYJa__Q X-Authority-Analysis: v=2.4 cv=C/TpyRP+ c=1 sm=1 tr=0 ts=68821b72 cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Wb1JkmetP80A:10 a=EUspDBNiAAAA:8 a=0a86huQbBvxycGr4qhYA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-07-24_01,2025-07-24_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 adultscore=0 mlxscore=0 clxscore=1015 impostorscore=0 mlxlogscore=999 bulkscore=0 priorityscore=1501 phishscore=0 suspectscore=0 malwarescore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2507240087 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 7/23/25 9:28 PM, Akhil P Oommen wrote: > On 7/23/2025 3:31 PM, Konrad Dybcio wrote: >> On 7/20/25 2:16 PM, Akhil P Oommen wrote: >>> A7XX_GEN2 generation has additional TCS slots. Poll the respective >>> DRV status registers before pm suspend. >>> >>> Signed-off-by: Akhil P Oommen >>> --- >>> drivers/gpu/drm/msm/adreno/a6xx_gmu.c | 16 ++++++++++++++++ >>> 1 file changed, 16 insertions(+) >>> >>> diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >>> index 790ef2f94a0b0cd40433d7edb6a89e4f04408bf5..3bebb6dd7059782ceca29f2efd2acee24d3fc930 100644 >>> --- a/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >>> +++ b/drivers/gpu/drm/msm/adreno/a6xx_gmu.c >>> @@ -987,6 +987,22 @@ static void a6xx_gmu_rpmh_off(struct a6xx_gmu *gmu) >>> val, (val & 1), 100, 10000); >>> gmu_poll_timeout_rscc(gmu, REG_A6XX_RSCC_TCS3_DRV0_STATUS + seqmem_off, >>> val, (val & 1), 100, 1000); > > 1000us here is a typo and I copied the same mistake below. I will update > all of these timeout values to a common 10000us in the next revision. > >>> + >>> + if (!adreno_is_a740_family(adreno_gpu)) >>> + return; >>> + >>> + gmu_poll_timeout_rscc(gmu, REG_A7XX_RSCC_TCS4_DRV0_STATUS + seqmem_off, >>> + val, (val & 1), 100, 10000); >>> + gmu_poll_timeout_rscc(gmu, REG_A7XX_RSCC_TCS5_DRV0_STATUS + seqmem_off, >>> + val, (val & 1), 100, 10000); >>> + gmu_poll_timeout_rscc(gmu, REG_A7XX_RSCC_TCS6_DRV0_STATUS + seqmem_off, >>> + val, (val & 1), 100, 10000); >>> + gmu_poll_timeout_rscc(gmu, REG_A7XX_RSCC_TCS7_DRV0_STATUS + seqmem_off, >>> + val, (val & 1), 100, 1000); >>> + gmu_poll_timeout_rscc(gmu, REG_A7XX_RSCC_TCS8_DRV0_STATUS + seqmem_off, >>> + val, (val & 1), 100, 10000); >>> + gmu_poll_timeout_rscc(gmu, REG_A7XX_RSCC_TCS9_DRV0_STATUS + seqmem_off, >>> + val, (val & 1), 100, 1000); >> >> FWIW there are places downstream where it polls for 1 ms >> (gen7_gmu_pwrctrl_suspend) / 2 ms (gen7_gmu_power_off) ms (as opposed >> to 1 or 10 ms here), but the timeouts are all the same across registers >> (unlike TCS3 and TCS9 above) >> >> Ultimately it's a timeout, so a value too big shouldn't matter, but >> let's make sure the other threshold is ok > > They are fine. We can try to reduce the timeout 2ms in a separate patch > outside of this series. Great, thanks for confirming! Konrad