From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1856ECDD1D2 for ; Fri, 27 Sep 2024 20:30:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7981210ED19; Fri, 27 Sep 2024 20:30:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=quicinc.com header.i=@quicinc.com header.b="jJc6qn35"; dkim-atps=neutral Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id AEF5010ED19 for ; Fri, 27 Sep 2024 20:30:27 +0000 (UTC) Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 48RGDpYM026591; Fri, 27 Sep 2024 20:30:23 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= drXPxk9zMaDWUyeLZ7I4RXN5+TyVWVZ68rPNTXtK2/Y=; b=jJc6qn35nZtkvqtj 4pzrz0/u42KPY0uSnqmdEMVlDM7nVrqXV1X2UPe0g0ikD9SBvj60LhuNEkB+kFuX LH2OiefS0skzbzuMwYmkjVmjFBFq5sWhNUl87vRgoc8lxVJfGjGBWhaSxtaNEFJd 71TnIhTQGq6AW31EAITv94sdiEPJO8P9C3pxpu6J+48Kpm+UGevMLAEBF9cXNKzs vVRN+pe93KdRJOuft1IhJjptG0iRtRTyu/AL33Q5ADHl25aZW1aPqbuO/O+Twfuj Ukla1irGhNCXUJ6kvV21xxPPz/SOOpaMTZOOFOTHdooLYXVGVPDFl3psu989dYW0 iIHVWw== Received: from nalasppmta04.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 41sn5c4669-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 20:30:23 +0000 (GMT) Received: from nalasex01a.na.qualcomm.com (nalasex01a.na.qualcomm.com [10.47.209.196]) by NALASPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 48RKULhp017034 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Fri, 27 Sep 2024 20:30:21 GMT Received: from [10.226.59.182] (10.80.80.8) by nalasex01a.na.qualcomm.com (10.47.209.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Fri, 27 Sep 2024 13:30:21 -0700 Message-ID: Date: Fri, 27 Sep 2024 14:30:20 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH 04/29] accel/ivpu: Refactor FW log Content-Language: en-US To: Jacek Lawrynowicz , CC: , Tomasz Rusinowicz References: <20240924081754.209728-1-jacek.lawrynowicz@linux.intel.com> <20240924081754.209728-5-jacek.lawrynowicz@linux.intel.com> From: Jeffrey Hugo In-Reply-To: <20240924081754.209728-5-jacek.lawrynowicz@linux.intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01a.na.qualcomm.com (10.47.209.196) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: JcaS14HdMi-TegJLb0e0C3yR5957IZNi X-Proofpoint-GUID: JcaS14HdMi-TegJLb0e0C3yR5957IZNi X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.60.29 definitions=2024-09-06_09,2024-09-06_01,2024-09-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 suspectscore=0 adultscore=0 impostorscore=0 malwarescore=0 mlxlogscore=697 spamscore=0 mlxscore=0 priorityscore=1501 bulkscore=0 phishscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2408220000 definitions=main-2409270150 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 9/24/2024 2:17 AM, Jacek Lawrynowicz wrote: > - use read_wrap_count from new FW Boot API > - fix logic issues in fw_log_print_buffer What issues? Fixes tag? > - remove unused functions/structures > - rename some of the functions for better readability Feels like this should be 4 separate patches. Removing unused functions does not seem to be directly related to readability from naming for example. -Jeff