From: "Christian König" <ckoenig.leichtzumerken@gmail.com>
To: "Christian König" <christian.koenig@amd.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
dri-devel@lists.freedesktop.org
Cc: "Signed-off-by : Alex Sierra" <alex.sierra@amd.com>,
Leo Li <sunpeng.li@amd.com>,
Felix Kuehling <Felix.Kuehling@amd.com>,
amd-gfx@lists.freedesktop.org,
Alex Deucher <alexander.deucher@amd.com>,
Bhawanpreet Lakha <Bhawanpreet.Lakha@amd.com>
Subject: Re: [PATCH] drm: amdgpu: fix kernel-doc struct warning
Date: Tue, 21 Apr 2020 16:34:44 +0200 [thread overview]
Message-ID: <aeecb841-c5a4-36c7-e511-eb7250e9ece1@gmail.com> (raw)
In-Reply-To: <128ebc30-e62b-b928-cf92-9ca331bfb6b5@amd.com>
Am 21.04.20 um 16:33 schrieb Christian König:
> Am 20.04.20 um 03:50 schrieb Randy Dunlap:
>> Fix a kernel-doc warning of missing struct field desription:
>>
>> ../drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:92: warning: Function
>> parameter or member 'vm' not described in 'amdgpu_vm_eviction_lock'
>
> Can't we just document the function parameter instead? Should only be
> one IIRC.
On the other hand forget that, the format doesn't match a proper
kernel-doc for a function anyway.
Reviewed-by: Christian König <christian.koenig@amd.com>
>
> Thanks,
> Christian.
>
>>
>> Fixes: a269e44989f3 ("drm/amdgpu: Avoid reclaim fs while eviction lock")
>> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
>> Cc: Signed-off-by: Alex Sierra <alex.sierra@amd.com>
>> Cc: Felix Kuehling <Felix.Kuehling@amd.com>
>> Cc: Christian König <christian.koenig@amd.com>
>> Cc: Alex Deucher <alexander.deucher@amd.com>
>> Cc: David (ChunMing) Zhou <David1.Zhou@amd.com>
>> Cc: amd-gfx@lists.freedesktop.org
>> ---
>> drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- lnx-57-rc2.orig/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> +++ lnx-57-rc2/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>> @@ -82,7 +82,7 @@ struct amdgpu_prt_cb {
>> struct dma_fence_cb cb;
>> };
>> -/**
>> +/*
>> * vm eviction_lock can be taken in MMU notifiers. Make sure no
>> reclaim-FS
>> * happens while holding this lock anywhere to prevent deadlocks when
>> * an MMU notifier runs in reclaim-FS context.
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-04-21 14:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 1:50 [PATCH] drm: amd: display: fix kernel-doc struct warning Randy Dunlap
2020-04-20 1:50 ` [PATCH] drm: amdgpu: " Randy Dunlap
2020-04-21 14:13 ` Harry Wentland
2020-04-21 14:33 ` Christian König
2020-04-21 14:34 ` Christian König [this message]
2020-04-22 20:04 ` Alex Deucher
2020-04-21 14:12 ` [PATCH] drm: amd: display: " Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeecb841-c5a4-36c7-e511-eb7250e9ece1@gmail.com \
--to=ckoenig.leichtzumerken@gmail.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Felix.Kuehling@amd.com \
--cc=alex.sierra@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=rdunlap@infradead.org \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox