From: "Christian König" <christian.koenig@amd.com>
To: Mauro Carvalho Chehab <mauro.chehab@linux.intel.com>
Cc: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Karolina Stolarek" <karolina.stolarek@intel.com>,
dri-devel@lists.freedesktop.org,
"Andi Shyti" <andi.shyti@linux.intel.com>,
"Shuah Khan" <shuah@kernel.org>,
"Nirmoy Das" <nirmoy.das@intel.com>
Subject: Re: [RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool
Date: Tue, 4 Jul 2023 08:57:54 +0200 [thread overview]
Message-ID: <af0107cb-64c1-337f-7427-631e735acfa5@amd.com> (raw)
In-Reply-To: <20230704085035.7a4ec164@maurocar-mobl2>
Am 04.07.23 um 08:50 schrieb Mauro Carvalho Chehab:
> On Mon, 3 Jul 2023 13:21:43 +0200
> Christian König <christian.koenig@amd.com> wrote:
>
>>> + /* We don't need this BO later, release it */
>>> + ttm_bo_put(bo);
>> That won't work. A BO must always outlive the TT object allocated for it.
>>
>> Otherwise you can get crashes during TT release.
> Just my two cents: shouldn't the TT object be increasing Kobj refcount then,
> in order to properly manage the BO object lifetime?
No, because you then get a circle reference.
The TT object is usually destroyed when the BO which is referencing it
is destroyed.
Regards,
Christian.
>
> Regards,
> Mauro
prev parent reply other threads:[~2023-07-04 6:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-03 7:58 [RFC v3 0/3] Introduce KUnit tests for TTM subsystem Karolina Stolarek
2023-07-03 7:58 ` [RFC v3 1/3] drm/ttm: Introduce KUnit tests Karolina Stolarek
2023-07-03 7:58 ` [RFC v3 2/3] drm/ttm/tests: Add tests for ttm_device Karolina Stolarek
2023-07-03 7:58 ` [RFC v3 3/3] drm/ttm/tests: Add tests for ttm_pool Karolina Stolarek
2023-07-03 11:21 ` Christian König
2023-07-04 6:35 ` Karolina Stolarek
2023-07-04 7:01 ` Christian König
2023-07-04 7:23 ` Karolina Stolarek
2023-07-04 6:50 ` Mauro Carvalho Chehab
2023-07-04 6:57 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=af0107cb-64c1-337f-7427-631e735acfa5@amd.com \
--to=christian.koenig@amd.com \
--cc=andi.shyti@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=karolina.stolarek@intel.com \
--cc=mauro.chehab@linux.intel.com \
--cc=nirmoy.das@intel.com \
--cc=shuah@kernel.org \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox