dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dmitry Ilvokhin <d@ilvokhin.com>
To: Mike Marciniszyn <mike.marciniszyn@gmail.com>
Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Alex Deucher <alexander.deucher@amd.com>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Andrew Lunn <andrew@lunn.ch>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	Mike Marciniszyn <mmarcini@meta.com>,
	Jakub Kicinski <kuba@kernel.org>
Subject: Re: [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb()
Date: Fri, 8 May 2026 12:55:46 +0000	[thread overview]
Message-ID: <af3dUohsYKMSZK6V@shell.ilvokhin.com> (raw)
In-Reply-To: <afzkApARAHVuAcLW@PF5YBGDS.localdomain>

On Thu, May 07, 2026 at 03:12:02PM -0400, Mike Marciniszyn wrote:
> On Thu, May 07, 2026 at 06:10:12PM +0000, Dmitry Ilvokhin wrote:
> > On Fri, May 01, 2026 at 04:43:13PM -0400, mike.marciniszyn@gmail.com wrote:
> > > From: Mike Marciniszyn <mmarcini@meta.com>
> > >
> > > When CONFIG_DRM_FBDEV_EMULATION  is not defined this error results
> > > when building amdgpu_display.c with CONFIG_DRM_AMDGPU:
> > >
> > > error: call to undeclared function 'drm_fb_helper_gem_is_fb'; ISO C99 and
> > > later do not support implicit function
> > > declarations [-Wimplicit-function-declaration]
> > >
> > >  1777 |  if (!drm_fb_helper_gem_is_fb(dev->fb_helper, fb->obj[0])) {
> > >
> > > Cc: stable@vger.kernel.org
> > > Signed-off-by: Mike Marciniszyn <mmarcini@meta.com>
> >
> > Just hit the same problem, thanks for the fix.
> >
> > Reviewed-by: Dmitry Ilvokhin <d@ilvokhin.com>
> 
> Thanks, but actually there was already a fix.
> 
> Take a look at linux.git/master:
> 
> commit 927011b65a875302d08709bbe82eaf4d0d96c5d5
> Author: Yury Norov <ynorov@nvidia.com>
> Date:   Mon Apr 27 22:49:41 2026 -0400
> 
>     drm/amdgpu: fix build for CONFIG_DRM_FBDEV_EMULATION=n
> 
> I encountered this in net-next, but the above has yet to be put into net-next.
> 
> Mike

Indeed. Thanks, Mike.

      reply	other threads:[~2026-05-10 10:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-01 20:43 [PATCH] drm/fbdev-helper: Fix deletion of stub for drm_fb_helper_gem_is_fb() mike.marciniszyn
2026-05-07 18:10 ` Dmitry Ilvokhin
2026-05-07 19:12   ` Mike Marciniszyn
2026-05-08 12:55     ` Dmitry Ilvokhin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=af3dUohsYKMSZK6V@shell.ilvokhin.com \
    --to=d@ilvokhin.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=andrew@lunn.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=javierm@redhat.com \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mike.marciniszyn@gmail.com \
    --cc=mmarcini@meta.com \
    --cc=mripard@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox