From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 71D5AFF8868 for ; Tue, 28 Apr 2026 10:56:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C183910E312; Tue, 28 Apr 2026 10:56:21 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.b="iz76jsin"; dkim-atps=neutral Received: from mail-wm1-f74.google.com (mail-wm1-f74.google.com [209.85.128.74]) by gabe.freedesktop.org (Postfix) with ESMTPS id 914BE10E312 for ; Tue, 28 Apr 2026 10:56:20 +0000 (UTC) Received: by mail-wm1-f74.google.com with SMTP id 5b1f17b1804b1-488c2a4e257so86693925e9.3 for ; Tue, 28 Apr 2026 03:56:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1777373779; x=1777978579; darn=lists.freedesktop.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=skvItkywmwm64idEbCIVWYyh8/nR+fu703k8dUmR+9k=; b=iz76jsinJf5NRKaRKfmhE5GflY4ezCTvh25emgkP0sCyI+PT4GhlQ80VLLv6eroRa8 9q/d4rvLIu5lXvIP0dOYZoWdVgLT25XjZ5LgzNkgo9y0gEpKbfZMwjXRSm0eeTxyEeNx BYwqrb0l5WQaGttHnqe4UDZb/1D5y+mbnCFXrwDEyj2XEWrg4mYVvm5iuuIfA6l//xO5 jwj41imb4GnoEbb3cngT6JP+lg6QyXvCetL67m4wg8uRuXLj6y6W8FvRGufu3BD+p6S3 hWSBuA2Y4dpuprcWOhACvxy5T5uPBayP7HwImW6U08/bJVkA8jBNYRQVUdUd4CiNpgUc LGXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1777373779; x=1777978579; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=skvItkywmwm64idEbCIVWYyh8/nR+fu703k8dUmR+9k=; b=GSZQHxJJ2LZOeSE9hZcvAkyzJll1pC3zJKVfVDAcb98zldB246i7PQ9u7cUsPXs5q/ lGb1BTnXdoerdq6zAZwz0Zl76gGo35WQxMaP5JbAF7BS2uvCJmFfLEGekvNPszQ1nZEW I4jsqxJWmMuamZ71QTY5rHEh/lf4dwnxUnlLBUwDJG1zpsRGTW9H7VblK7PrEnu3FAFC /dLEJnqbFYXQVDYAWRIAw67YTrwVrKDfs9lwGnO7VTH5gpXNzidQ2UiN4mzplr6KhDhj QVVw0yNTTK5ttQTB+vZ5d+yJgEceV9rE9wzXGK8jdkAeGvJt6xQoYmyo/5kyxNKgrJFd XpAw== X-Forwarded-Encrypted: i=1; AFNElJ+KgrLgn3ARK9adxOPhPBjC4jRVySep8INa/tgWL03swuW48HkJC8GXM6LZ/iZHwq+aIskoO3xxy/U=@lists.freedesktop.org X-Gm-Message-State: AOJu0YwRuI5wcuQ5QmAKhgAAtVUCSAt7KUzZlhqC1bjevSpaBhhpg8E1 9du82FFV6g/XyG+KUEho4D5qkbudEgStNDVSY9qCHBMweq7sLVx3djkeDvMM8/PvC/Q7HZaeqL8 rkXizPkxzIA49w9/zow== X-Received: from wmbz10.prod.google.com ([2002:a05:600c:c08a:b0:488:c127:b938]) (user=aliceryhl job=prod-delivery.src-stubby-dispatcher) by 2002:a05:600c:83c5:b0:488:c744:49b with SMTP id 5b1f17b1804b1-48a77aed600mr40391315e9.7.1777373778671; Tue, 28 Apr 2026 03:56:18 -0700 (PDT) Date: Tue, 28 Apr 2026 10:56:17 +0000 In-Reply-To: <20260427100704.02190859@fedora> Mime-Version: 1.0 References: <20260424-b4-fw-boot-v4-v4-0-a5d91050789d@collabora.com> <20260427100704.02190859@fedora> Message-ID: Subject: Re: [PATCH v4 00/20] drm/tyr: firmware loading and MCU boot support From: Alice Ryhl To: Boris Brezillon Cc: Deborah Brouwer , Daniel Almeida , Danilo Krummrich , David Airlie , Simona Vetter , Benno Lossin , Gary Guo , Miguel Ojeda , Boqun Feng , "=?utf-8?B?QmrDtnJu?= Roy Baron" , Andreas Hindborg , Trevor Gross , FUJITA Tomonori , Frederic Weisbecker , Thomas Gleixner , Anna-Maria Behnsen , John Stultz , Stephen Boyd , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, beata.michalska@arm.com, lyude@redhat.com, acourbot@nvidia.com, work@onurozkan.dev, alvin.sun@linux.dev Content-Type: text/plain; charset="utf-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Apr 27, 2026 at 10:07:04AM +0200, Boris Brezillon wrote: > On Fri, 24 Apr 2026 16:38:54 -0700 > Deborah Brouwer wrote: > > > This series adds firmware loading and MCU boot support to the Tyr DRM > > driver. It includes: > > - A parser for the Mali CSF firmware binary format > > - A kernel-managed BO type (KernelBo) for internal driver allocations > > - GPU virtual memory (VM) integration using drm_gpuvm > > - An MMU module and a generic slot manager > > - Shmem-backed GEM support for Tyr > > - Loading firmware, VM activation, and MCU boot at probe() > > - Initialization of Command Stream Frontend (CSF) firmware interfaces > > > > Dependencies: > > - [PATCH v12 0/5] Rust bindings for gem shmem > > https://lore.kernel.org/rust-for-linux/20260421235346.672794-1-lyude@redhat.com > > > > - [PATCH v6 0/5] Rust GPUVM immediate mode > > https://lore.kernel.org/rust-for-linux/20260409-gpuvm-rust-v6-0-b16e6ada7261@google.com/ > > > > - [PATCH v6 0/5] Introduce DeviceContext > > https://lore.kernel.org/rust-for-linux/20260320233645.950190-1-lyude@redhat.com/ > > > > - [PATCH v5 0/6] drm/tyr: Use register! macro > > https://lore.kernel.org/rust-for-linux/20260409-b4-tyr-use-register-macro-v5-v5-0-8abfff8a0204@collabora.com/ > > > > Other Prerequisites: > > This series also depends on additional prerequisite fixes not included in > > this posting. The full stack (base + prerequisites + this series) is > > available here: > > https://gitlab.freedesktop.org/dbrouwer/linux/-/tree/dbrouwer/fw-boot > > > > Development history / discussion: > > https://gitlab.freedesktop.org/panfrost/linux/-/merge_requests/56 > > > > > > --- > > Changes in v4: > > New commits: > > - drm/tyr: program CSF global interface > > - rust: time: add arch_timer_get_rate wrapper > > - drm/tyr: add CSF firmware interface support > > - drm/tyr: validate presence of CSF shared section > > - drm/tyr: wait for global interface readiness > > - drm/tyr: add Job IRQ handling > > - drm/tyr: add Wait type for GPU events > > > > The existing commits from v3 remain unchanged. > > - Link to v3: https://lore.kernel.org/r/20260413-b4-fw-boot-v3-v3-0-b422f3c03885@collabora.com > > > > Changes in v3: > > New commits: > > - drm/tyr: remove unused device from platform data > > - drm/tyr: use shmem GEM object type in TyrDrmDriver > > > > drm/tyr: select required dependencies in Kconfig > > - Rename commit since the dependencies are not limited to DRM. > > - Select new RUST_DRM_GEM_SHMEM_HELPER instead of DRM_GEM_SHMEM_HELPER. > > > > drm/tyr: set DMA mask using GPU physical address > > - Use register macro to read pa_bits instead of separate helper function. > > > > drm/tyr: add MMU module > > - Switch MMU code to typed register APIs (TRANSCFG, MEMATTR, STATUS, LOCKADDR, etc.). > > - Use MmuCommand enum for MMU commands instead of raw constants. > > - Minor cleanups and renaming (MAX_AS, AS_PRESENT handling). > > > > drm/tyr: add GPU virtual memory module > > - Extract VA/PA bits via typed MMU_FEATURES register. > > - Update the VM code to match the new GPUVM v6 and shmem GEM v10 APIs. > > > > drm/tyr: add a kernel buffer object > > - Reject zero-sized KernelBo allocations up front. > > > > drm/tyr: add firmware loading and MCU boot support > > - Use typed GPU control registers. > > - Pass iomem by Arc into Firmware::new() since we store it eventually. > > > > - Link to v2: https://lore.kernel.org/rust-for-linux/20260302232500.244489-1-deborah.brouwer@collabora.com/ > > > > Changes in v2: > > - The whole series is rebased on drm-rust-next including v7.0-rc1. > > - Each patch has its own changelog. > > > > Link to v1: https://lore.kernel.org/rust-for-linux/20260212013713.304343-1-deborah.brouwer@collabora.com/ > > > > Signed-off-by: Deborah Brouwer > > > > --- > > Alvin Sun (1): > > drm/tyr: use shmem GEM object type in TyrDrmDriver > > > > Beata Michalska (1): > > drm/tyr: set DMA mask using GPU physical address > > > > Boris Brezillon (5): > > drm/tyr: select required dependencies in Kconfig > > drm/tyr: rename TyrObject to BoData > > drm/tyr: Add generic slot manager > > drm/tyr: add MMU module > > drm/tyr: add GPU virtual memory module > > > > Daniel Almeida (1): > > drm/tyr: add parser for firmware binary > > > > Deborah Brouwer (12): > > drm/tyr: remove unused device from platform data > > drm/tyr: move clock cleanup into Clocks Drop impl > > drm/tyr: add shmem backing for GEM objects > > drm/tyr: add a kernel buffer object > > drm/tyr: add firmware loading and MCU boot support > > drm/tyr: add Wait type for GPU events > > drm/tyr: add Job IRQ handling > > drm/tyr: wait for global interface readiness > > drm/tyr: validate presence of CSF shared section > > drm/tyr: add CSF firmware interface support > > rust: time: add arch_timer_get_rate wrapper > > drm/tyr: program CSF global interface > > This series starts to be quite big, and it seems new features have been > added to v4 (interactions with the FW). I'd recommend that we extract > the uncontroversial bits (I'd say patch 1-2, 4-7) or have them applied > to drm-rust-next right away. I know it's tempting to add features > between revisions, but the more you do that the longer it will take to > get the foundation merged. How about I pick up patches 1, 3, 4, 5, 6, 7 for drm-rust-next now? Otherwise yeah I agree it's better to split up work and have multiple series that depend on each other, because then I can just pick up whole series on their own as they reach a finished state. Alice