From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 0/5] omapdrm: fences and zpos Date: Tue, 3 Jan 2017 14:06:45 +0200 Message-ID: References: <20170102232946.7597-1-laurent.pinchart@ideasonboard.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0001023636==" Return-path: Received: from lelnx193.ext.ti.com (lelnx193.ext.ti.com [198.47.27.77]) by gabe.freedesktop.org (Postfix) with ESMTPS id 511456E56F for ; Tue, 3 Jan 2017 12:06:52 +0000 (UTC) In-Reply-To: <20170102232946.7597-1-laurent.pinchart@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0001023636== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="USCnMGP8D5D7EdGquaVdBXwcapM3t1qeb" --USCnMGP8D5D7EdGquaVdBXwcapM3t1qeb Content-Type: multipart/mixed; boundary="eRlUaxCbCQBURuJUfNgVLhExXHQQKXe2t"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart , dri-devel@lists.freedesktop.org Message-ID: Subject: Re: [PATCH 0/5] omapdrm: fences and zpos References: <20170102232946.7597-1-laurent.pinchart@ideasonboard.com> In-Reply-To: <20170102232946.7597-1-laurent.pinchart@ideasonboard.com> --eRlUaxCbCQBURuJUfNgVLhExXHQQKXe2t Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 03/01/17 01:29, Laurent Pinchart wrote: > Hello, >=20 > This patch series contains two completely unrelated features that just = happen > to have been developed one right after the other. >=20 > Patches 1/5 to 3/5 implement explicit fences support. The first patch f= ixes > event handling in the omapdrm driver as required by the atomic commit h= elper > (and the DRM atomic update API). The second patch replace the hand-roll= ed > atomic commit handler with the DRM core atomic commit helper, bringing = fences > support as a bonus. The third patch then removes the omapdrm custom syn= c > support that has no user in the mainline kernel. >=20 > Patches 4/5 and 5/5 clean up zpos handling by switching to the standard= zpos > property implemented in the DRM core. The omapdrm-specific zorder prope= rty is > kept for backward compatibility as an alias and should be removed later= after > a long enough grace period for userspace to be updated. >=20 > As fence support is implemented completely inside the atomic commit hel= per I > have only tested it lightly using the sw-sync driver. No issue has been= > noticed. >=20 > The patches are based on top of my previous omapdrm series that has bee= n fully > acked and should thus be merged in v4.11. It also requires the "drm: Co= nstify > drm_mode_config atomic helper private pointer" patch that I have sent t= o the > dri-devel mailing list today. >=20 > Laurent Pinchart (5): > drm: omapdrm: Handle events when enabling/disabling CRTCs > drm: omapdrm: Use DRM core's atomic commit helper > drm: omapdrm: Remove legacy buffer synchronization support > drm: omapdrm: Store the Z order in the plane state zpos field > drm: omapdrm: Add zpos property >=20 > drivers/gpu/drm/omapdrm/omap_crtc.c | 30 +++-- > drivers/gpu/drm/omapdrm/omap_drv.c | 163 ++++---------------------- > drivers/gpu/drm/omapdrm/omap_drv.h | 14 +-- > drivers/gpu/drm/omapdrm/omap_gem.c | 215 ---------------------------= -------- > drivers/gpu/drm/omapdrm/omap_plane.c | 74 ++---------- > include/uapi/drm/omap_drm.h | 4 +- > 6 files changed, 55 insertions(+), 445 deletions(-) >=20 I got this with your series. AM5 EVM, dual display, I run "kmstest --flip= " and then exit by pressing enter, which is when I see the warning. It happens only = sometimes, but having lots of cpu load (I used "stress -c 4") makes the driver spam = the warning. [ 67.207223] ------------[ cut here ]------------ [ 67.211937] WARNING: CPU: 1 PID: 324 at drivers/gpu/drm/omapdrm/omap_g= em.c:1085 omap_gem_free_object+0x270/0x2d4 [omapdrm] [ 67.223138] Modules linked in: omapdrm drm_kms_helper drm panel_dsi_cm= panel_dpi connector_analog_tv connector_dvi connector_hdmi encoder_tp d12s015 encoder_tfp410 omapdss cfbfillrect cfbimgblt cfbcopyarea [last un= loaded: omapdss] [ 67.243953] CPU: 1 PID: 324 Comm: kmstest Not tainted 4.9.0-rc8-00163-= g55f4a6c2d775 #135 [ 67.252084] Hardware name: Generic DRA74X (Flattened Device Tree) [ 67.258207] Backtrace:=20 [ 67.260691] [] (dump_backtrace) from [] (show_stac= k+0x18/0x1c) [ 67.268301] r7:c0d830d8 r6:60070013 r5:00000000 r4:c0d830d8 [ 67.273997] [] (show_stack) from [] (dump_stack+0x= a8/0xdc) [ 67.281263] [] (dump_stack) from [] (__warn+0xdc/0= x108) [ 67.288263] r9:bf292048 r8:0000043d r7:00000009 r6:bf2972cc r5:000000= 00 r4:00000000 [ 67.296050] [] (__warn) from [] (warn_slowpath_nul= l+0x28/0x30) [ 67.303661] r9:c00464b4 r8:ed0a4800 r7:00000000 r6:ed0a4838 r5:ee6d17= 9c r4:ed09c700 [ 67.311467] [] (warn_slowpath_null) from [] (omap_= gem_free_object+0x270/0x2d4 [omapdrm]) [ 67.321482] [] (omap_gem_free_object [omapdrm]) from [] (drm_gem_object_free+0x4c/0x6c [drm]) [ 67.331796] r10:ed0a4800 r9:c00464b4 r8:00000001 r7:00000000 r6:ed0a4= 838 r5:ed09c700 [ 67.339664] r4:ed0a4800 [ 67.342422] [] (drm_gem_object_free [drm]) from []= (drm_gem_object_unreference_unlocked+0x128/0x13c [drm]) [ 67.353867] r5:00000000 r4:ed09c700 [ 67.357671] [] (drm_gem_object_unreference_unlocked [drm]) f= rom [] (drm_gem_object_handle_unreference_unlocked+0x74/0xb0 [drm]) [ 67.370949] r8:ed1d181c r7:ed1d1954 r6:ed0a4e30 r5:00000000 r4:ed09c7= 00 [ 67.377892] [] (drm_gem_object_handle_unreference_unlocked [= drm]) from [] (drm_gem_object_release_handle+0x58/0x90 [drm] ) [ 67.390646] r7:ed1d1954 r6:ed0a4800 r5:ed1d1800 r4:ed09c700 [ 67.396543] [] (drm_gem_object_release_handle [drm]) from [<= bf1dd9d0>] (drm_gem_handle_delete+0x60/0x8c [drm]) [ 67.407465] r7:ed09c700 r6:00000002 r5:ed1d1800 r4:ed1d1854 [ 67.413361] [] (drm_gem_handle_delete [drm]) from [] (drm_gem_dumb_destroy+0x14/0x18 [drm]) [ 67.423500] r9:c00464b4 r8:ed1d1800 r7:bf1ff980 r6:00000004 r5:ee7efe= 50 r4:00000000 [ 67.431490] [] (drm_gem_dumb_destroy [drm]) from [= ] (drm_mode_destroy_dumb_ioctl+0x30/0x3c [drm]) [ 67.442408] [] (drm_mode_destroy_dumb_ioctl [drm]) from [] (drm_ioctl+0x210/0x424 [drm]) [ 67.452392] [] (drm_ioctl [drm]) from [] (do_vfs_i= octl+0x9c/0xa88) [ 67.460352] r10:00000000 r9:00000003 r8:00000003 r7:c02d15f4 r6:ed14b= 180 r5:ed5feac8 [ 67.468219] r4:be95c44c [ 67.470771] [] (do_vfs_ioctl) from [] (SyS_ioctl+0= x74/0x84) [ 67.478120] r10:00000000 r9:00000003 r8:be95c44c r7:c00464b4 r6:ed14b= 180 r5:ed14b180 [ 67.485987] r4:00000000 [ 67.488541] [] (SyS_ioctl) from [] (ret_fast_sysca= ll+0x0/0x1c) [ 67.496151] r9:ee7ee000 r8:c0108c04 r7:00000036 r6:c00464b4 r5:be95c4= 4c r4:0005de78 [ 67.504143] ---[ end trace 11d19f8e7a3544b1 ]--- --eRlUaxCbCQBURuJUfNgVLhExXHQQKXe2t-- --USCnMGP8D5D7EdGquaVdBXwcapM3t1qeb Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYa5PVAAoJEPo9qoy8lh718pQP/2HGxM3wzqzuxnPg3GcBdUhA kZ1A9R1OuSjRZdfarZX4y/WlLs0E/VF+DN6eTuAw48Rl8I+4waOczJuMQ+LHbrY6 o35V9o/STN7IL+kRpdDFyshZqsN+xGuBoVUCfd7OpIselMKcOXPLaAw8otRbBhlH vm+2LXrs4XOVFvRKxKM2KOnopsGigi1um9bxYG/V2qWka0oTwAw4ewCoZ5T6Gzw/ Z2DyJW6qiHQxHvtfU/A8vak+6W99y5eF5x9M58AshlmyqCdjifNS+0pjLGU3Ctbb +FKuNamAPb2MJ6U5aHciDaB3ebI1W8rDTtnRXYJdTdUxfY3B/UzKpPXCp93EZfql G6SqmtiDGa98fxyKh/6Sm2IGqeVf3bRoRxSbfNe8+BW6iFhEV8lkkA2Hfjx2WHCo SO+xIR39FpUZqeytCU/oSvK1wNZ52iQ6mArtuyja3eEmpHDHt9L7N+VhtJJFy/dk yg2oRS+mz49a++Wj/2TG1r8rDNBzx2BwbqpE8CE3G5/TSd0MPYBGAU8pi+6YODqB Fdh2i6EDgVahL41UmGah1dPJuCkWwE21nbsSdEggsOPzxiJS93UWs7zc8n36j2lX 00OCo3RQpQ6WQFYgDuo4eZlXzI6C9DPzZYqFDQVUJdF5i+VvMjG9pImikLrVv5kl QLE3bZtvaNFZ20qBo8NO =6UMn -----END PGP SIGNATURE----- --USCnMGP8D5D7EdGquaVdBXwcapM3t1qeb-- --===============0001023636== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0001023636==--