From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 061B21067042 for ; Thu, 12 Mar 2026 15:11:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5C17C10EA34; Thu, 12 Mar 2026 15:10:59 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.b="GW0ZruuM"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="B+aDT5r9"; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.b="Z2kdlF6X"; dkim=permerror (0-bit key) header.d=suse.de header.i=@suse.de header.b="1QvHvArc"; dkim-atps=neutral Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3866410EA34 for ; Thu, 12 Mar 2026 15:10:58 +0000 (UTC) Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D1DFF5BCEA; Thu, 12 Mar 2026 15:10:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773328257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dfx7RDm71zA9Rk6pTBN0qMKiF6/2jPv0Xnef1zAwimg=; b=GW0ZruuMRQxZV2xGGWs+Dhvg7/TNn9lDsYXEOCMu1EgHneZvoTnfzqX3DIwI5QWFlRL7hG oM16DtmmvOKtMbfXSsze2rUBz2g7JGzdq3eRRmwILwGVsJM4T7wV6VeX+mEGeH7Ri9cgQ1 aBDU48EManOselqp4atXN+D4eYQf0ck= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773328257; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dfx7RDm71zA9Rk6pTBN0qMKiF6/2jPv0Xnef1zAwimg=; b=B+aDT5r9k18fiEiENemInBz0EvPeAjeFQx61p7fWrvi9FgQkFob0mtQt993CzpyNEJ2cme atUoMxOifSwJaNCQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1773328256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dfx7RDm71zA9Rk6pTBN0qMKiF6/2jPv0Xnef1zAwimg=; b=Z2kdlF6XBT+VNtzlti+MtXsSqlS0CXWFrJf2gvqj8NSUpj830Dalt1tldjykdexfWmKk3K rR8X1hEF8uOIk4ARbAsxO/0jM0cdPnxAx7PYqBGz6bpRvhKvgmRkXxVdQ1ulm/iUpf+nZQ aO33p5u20nrHw9wNqIyYru6/mZwBDvU= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1773328256; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Dfx7RDm71zA9Rk6pTBN0qMKiF6/2jPv0Xnef1zAwimg=; b=1QvHvArcq3xwX6ZFCntzAOU7nG+t6FOJsgy4WclVNcj9lKb1zZprBf17Oaj3LMwPNStyI+ cSItODasVjXxr2AA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 982B940021; Thu, 12 Mar 2026 15:10:56 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id VzLxI4DXsmnTIwAAD6G6ig (envelope-from ); Thu, 12 Mar 2026 15:10:56 +0000 Message-ID: Date: Thu, 12 Mar 2026 16:10:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] fbdev/hga: Request memory region before ioremap To: Hardik Phalet , Ferenc Bakonyi , Helge Deller Cc: Shuah Khan , Brigham Campbell , linux-nvidia@lists.surfsouth.com, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20260310123004.888132-1-hardik.phalet@pm.me> <3d58e520-0308-44c7-a43a-e438548e9c40@suse.de> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-0.998]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FREEMAIL_TO(0.00)[pm.me,drama.obuda.kando.hu,gmx.de]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_SEVEN(0.00)[9]; FUZZY_RATELIMITED(0.00)[rspamd.com]; MID_RHS_MATCH_FROM(0.00)[]; FREEMAIL_ENVRCPT(0.00)[gmx.de]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:email, suse.com:url, pm.me:email, imap1.dmz-prg2.suse.org:helo] X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Am 12.03.26 um 16:04 schrieb Hardik Phalet: > On Tue Mar 10, 2026 at 6:38 PM IST, Thomas Zimmermann wrote: >> Hi, >> >> thanks for the patch. Let's hope there are no conflicts with other >> hardware.  IDK if anyone still uses this driver. > Hi Thomas, > > Thanks for reviewing this. > > Since I currently do not have access to the hardware needed to test the > change properly, I will drop this patch for now. I may revisit it once I > can validate the behavior on real hardware. Good luck. That's the Hercules framebuffer driver. Finding such ancient hardware that can run modern Linux is nigh impossible. But we can merge the patch. If it breaks anyone's setup, they will send a bug report. Helge will pick up the fix if he's ok with it. Best regards Thomas > > Thanks again for your feedback. > > Best regards, > Hardik >> Am 10.03.26 um 13:30 schrieb Hardik Phalet: >>> The driver calls ioremap() on the HGA video memory at 0xb0000 without >>> first reserving the physical address range. This leaves the kernel >>> resource tree incomplete and can cause silent conflicts with other >>> drivers claiming the same range. >>> >>> Add a devm_request_mem_region() call before ioremap() in >>> hga_card_detect() to reserve the memory region. >>> >>> Signed-off-by: Hardik Phalet >> Reviewed-by: Thomas Zimmermann >> >> Best regards >> Thomas >> >>> --- >>> Changes in v3: >>> - Used dev_err() to log memory region request, based on another review >>> comment by Thomas [2]. >>> Changes in v2: >>> - Used devm_request_mem_region instead of request_mem_region, based on a >>> review comment by Thomas [1]. >>> >>> v1: https://lore.kernel.org/all/20260310064124.602848-1-hardik.phalet@pm.me/ >>> v2: https://lore.kernel.org/all/20260310113810.789575-1-hardik.phalet@pm.me/ >>> [1]: https://lore.kernel.org/all/5f9749ba-18a8-4b6b-a6e7-a011a3871bfb@suse.de/ >>> [2]: https://lore.kernel.org/all/ec635591-c861-4aa8-a259-718690ddaa4e@suse.de/ >>> >>> drivers/video/fbdev/hgafb.c | 9 +++++++-- >>> 1 file changed, 7 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/video/fbdev/hgafb.c b/drivers/video/fbdev/hgafb.c >>> index 14418aa3791a..d32fd1c5217c 100644 >>> --- a/drivers/video/fbdev/hgafb.c >>> +++ b/drivers/video/fbdev/hgafb.c >>> @@ -276,7 +276,7 @@ static void hga_blank(int blank_mode) >>> spin_unlock_irqrestore(&hga_reg_lock, flags); >>> } >>> >>> -static int hga_card_detect(void) >>> +static int hga_card_detect(struct platform_device *pdev) >>> { >>> int count = 0; >>> void __iomem *p, *q; >>> @@ -284,6 +284,11 @@ static int hga_card_detect(void) >>> >>> hga_vram_len = 0x08000; >>> >>> + if (!devm_request_mem_region(&pdev->dev, 0xb0000, hga_vram_len, "hgafb")) { >>> + dev_err(&pdev->dev, "cannot reserve video memory at 0xb0000\n"); >>> + return -EBUSY; >>> + } >>> + >>> hga_vram = ioremap(0xb0000, hga_vram_len); >>> if (!hga_vram) >>> return -ENOMEM; >>> @@ -568,7 +573,7 @@ static int hgafb_probe(struct platform_device *pdev) >>> struct fb_info *info; >>> int ret; >>> >>> - ret = hga_card_detect(); >>> + ret = hga_card_detect(pdev); >>> if (ret) >>> return ret; >>> >> -- >> -- >> Thomas Zimmermann >> Graphics Driver Developer >> SUSE Software Solutions Germany GmbH >> Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com >> GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg) > > -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)