From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2477CD6E57 for ; Tue, 2 Jun 2026 11:05:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6338610EF41; Tue, 2 Jun 2026 11:05:28 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="i9wS+XhQ"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5CF9810EF41 for ; Tue, 2 Jun 2026 11:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1780398327; x=1811934327; h=date:from:to:cc:subject:message-id:references: mime-version:content-transfer-encoding:in-reply-to; bh=334jL2lAPjuPlqw0djaN2J2L0UdWoI+uZoHt6zyLO1c=; b=i9wS+XhQxWjMPUM2zuh8A6KQPchyKLj1Hq4UCVSyast7a+3cTl7uiS3d ODtqt5jgCY478osJiJU+jO7nSMu63hGg7gCEZnUVVxyWcskhYIClITAeK eL8QSUAfelyanCwlVnV2kAZ7JtfLsQOy1Wx+Da8IuPGnzkeEvaIPkSiVd kRDOxsSMKUTdmsguMGkzhVz6fMMYbapZIMK1a3mXsXQvkYkxNdsGxASsL FLCvZKfL4vdqx32u/WLTYSW/RiDIM9ofLsCEitIj3eaCJjD5gJmBTpQy2 KHUV4+SItX23g1yD6oVkUW7GYiYnDwTynJxtwZsskEBQ/sqEKX1xT35QZ g==; X-CSE-ConnectionGUID: cDUk4I+yTz6S8YbzqabuRg== X-CSE-MsgGUID: EsSJmbe3R7SDGSc4skSgMQ== X-IronPort-AV: E=McAfee;i="6800,10657,11804"; a="85035813" X-IronPort-AV: E=Sophos;i="6.24,183,1774335600"; d="scan'208";a="85035813" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2026 04:05:26 -0700 X-CSE-ConnectionGUID: 3MDQwoTqTGO+0B9MM5EZIQ== X-CSE-MsgGUID: F/HgBAMISWmlXhvc9MCs9A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.24,183,1774335600"; d="scan'208";a="239709107" Received: from mkosciow-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.245.229]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Jun 2026 04:05:22 -0700 Date: Tue, 2 Jun 2026 14:05:20 +0300 From: Andy Shevchenko To: Svyatoslav Ryhel Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jonathan Cameron , David Lechner , Nuno =?iso-8859-1?Q?S=E1?= , Andy Shevchenko , Helge Deller , Johan Hovold , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-fbdev@vger.kernel.org Subject: Re: [PATCH v3 05/11] mfd: lm3533: Convert to use OF bindings Message-ID: References: <20260601151831.76350-1-clamor95@gmail.com> <20260601151831.76350-6-clamor95@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs, Bertel Jungin Aukio 5, 02600 Espoo X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jun 02, 2026 at 01:31:44PM +0300, Svyatoslav Ryhel wrote: > вт, 2 черв. 2026 р. о 11:24 Andy Shevchenko пише: > > On Mon, Jun 01, 2026 at 06:18:25PM +0300, Svyatoslav Ryhel wrote: ... > > > + device_for_each_child_node_scoped(lm3533->dev, child) { > > > > > + if (!fwnode_device_is_available(child)) > > > + continue; > > > > Do we need this check? > > This is nice to have if the node is disabled. If we assume that there > are no disabled nodes, I can remove it. It's already implied. See static struct fwnode_handle * of_fwnode_get_next_child_node(const struct fwnode_handle *fwnode, struct fwnode_handle *child) { return of_fwnode_handle(of_get_next_available_child(to_of_node(fwnode), to_of_node(child))); } And I believe it's written somewhere in the documentation (if not, feel free to patch that). ... > > > + ret = sysfs_create_group(&dev->kobj, &lm3533_attribute_group); > > > > No way. You should use .dev_groups. > > I did not change how driver does this, just swapped lm3533->dev to > dev. I will set is back as it was. This is a serious race condition that needs to be addressed. Since you are touching this driver the fixes against known issues probably are the first things that have to be done. > > > + if (ret) { > > > + dev_err(dev, "failed to create sysfs attributes\n"); > > > goto err_unregister; > > > } ... > > Can you think on how to split this change to smaller steps? I believe it's > > possible. > > No, I am done with tinkering with this patchset. It is broken enough > and it has inflated enough. Probably you don't want this to be reviewed then? I believe other kernel developers and maintainers will ask you the same. -- With Best Regards, Andy Shevchenko