From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4ACE5C43327 for ; Fri, 26 Jun 2026 13:13:41 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A11F710E7D0; Fri, 26 Jun 2026 13:13:40 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.b="CpZHVSal"; dkim-atps=neutral Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by gabe.freedesktop.org (Postfix) with ESMTP id 7E32810E7D0 for ; Fri, 26 Jun 2026 13:13:38 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 8B0E916A3 for ; Fri, 26 Jun 2026 06:13:33 -0700 (PDT) Received: from [192.168.0.1] (usa-sjc-imap-foss1.foss.arm.com [10.121.207.14]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id DEAFE3F632 for ; Fri, 26 Jun 2026 06:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arm.com; s=foss; t=1782479618; bh=KZm+A3dUTVk2rUvBJtk9nlzzGKmjPS2+xc9eht5/ax4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=CpZHVSaleUUOzaqtY03rRqjq1dEMekpOhl2LyvwWLVd0lEkcKFpU5JCOeRJ/mep5S 1mHebRFLT6YkdRzWOAoyk/RrUf5tFDfIKTRGVcWZzpsUI8or+pbp2iw+SkE7vMV5ia in6wYDuRlU3tVA1ocbt0PtuBLpd7AiRbO0GlYYhQ= Date: Fri, 26 Jun 2026 14:13:27 +0100 From: Liviu Dudau To: Boris Brezillon Cc: Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Nicolas Frattaroli , Chia-I Wu , Karunika Choo , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, sashiko-bot@kernel.org Subject: Re: [PATCH 05/11] drm/panthor: Fix theoretical IOMEM access in suspended state Message-ID: References: <20260625-panthor-misc-fixes-v1-0-b67ed973fea6@collabora.com> <20260625-panthor-misc-fixes-v1-5-b67ed973fea6@collabora.com> <20260626134028.518607ea@fedora-2.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260626134028.518607ea@fedora-2.home> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Jun 26, 2026 at 01:40:28PM +0200, Boris Brezillon wrote: > On Fri, 26 Jun 2026 10:29:54 +0100 > Liviu Dudau wrote: > > > On Thu, Jun 25, 2026 at 02:40:31PM +0200, Boris Brezillon wrote: > > > In theory, our hardirq handler can be called while the device (and > > > thus the panthor_irq) is suspended, because the IRQ line is shared. > > > In practice though, in all the designs we've seen, the line is only > > > shared within the GPU, and because sub-component suspend state is > > > consistent (all-suspended or all-resumed), we shouldn't end up with > > > an interrupt triggered while we're suspended. > > > > > > Fix the problem anyway, if nothing else, for our sanity. > > > > > > Fixes: 0b2d86670a84 ("drm/panthor: Rework panthor_irq::suspended into panthor_irq::state") > > > Reported-by: sashiko-bot@kernel.org > > > Closes: https://sashiko.dev/#/patchset/20260625-panthor-signal-from-irq-v4-0-3d2908912afa@collabora.com?part=1 > > > Signed-off-by: Boris Brezillon > > > --- > > > drivers/gpu/drm/panthor/panthor_device.h | 10 +++++++--- > > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/gpu/drm/panthor/panthor_device.h b/drivers/gpu/drm/panthor/panthor_device.h > > > index 35679bfa1f3a..a39386bd6382 100644 > > > --- a/drivers/gpu/drm/panthor/panthor_device.h > > > +++ b/drivers/gpu/drm/panthor/panthor_device.h > > > @@ -512,9 +512,6 @@ static irqreturn_t panthor_ ## __name ## _irq_raw_handler(int irq, void *data) > > > struct panthor_irq *pirq = data; \ > > > enum panthor_irq_state old_state; \ > > > \ > > > - if (!gpu_read(pirq->iomem, INT_STAT)) \ > > > - return IRQ_NONE; \ > > > - \ > > > guard(spinlock_irqsave)(&pirq->mask_lock); \ > > > old_state = atomic_cmpxchg(&pirq->state, \ > > > PANTHOR_IRQ_STATE_ACTIVE, \ > > > @@ -522,6 +519,13 @@ static irqreturn_t panthor_ ## __name ## _irq_raw_handler(int irq, void *data) > > > if (old_state != PANTHOR_IRQ_STATE_ACTIVE) \ > > > return IRQ_NONE; \ > > > \ > > > + if (!gpu_read(pirq->iomem, INT_STAT)) { \ > > > + atomic_cmpxchg(&pirq->state, \ > > > + PANTHOR_IRQ_STATE_PROCESSING, \ > > > + PANTHOR_IRQ_STATE_ACTIVE); \ > > > + return IRQ_NONE; \ > > > + } \ > > > > Hmm, > > > > I get it that you're trying to revert the effect of the previous atomic_cmpxchg() here but it feels > > like a better option would be to not do the swap at all if the state is not ACTIVE. > > That's what [1] does, but it's not possible until we've made this > atomic -> lock-based transition, and I want a fix that's not dependent > on non-Fixes patches so we can backport it. > > [1]https://lore.kernel.org/dri-devel/20260625-panthor-signal-from-irq-v5-8-8836a74e0ef9@collabora.com/ I see. Reviewed-by: Liviu Dudau Best regards, Liviu -- ==================== | I would like to | | fix the world, | | but they're not | | giving me the | \ source code! / --------------- ¯\_(ツ)_/¯