Re: [PATCH] drm: Use named initializers for arrays of i2c_device_data

["Uwe Kleine-König (The Capable Hub)" <u.kleine-koenig@baylibre.com>]

[-- Attachment #1: Type: text/plain, Size: 2145 bytes --]

Hello Luca,

On Mon, Jun 22, 2026 at 04:50:06PM +0200, Luca Ceresoli wrote:
> On Wed Jun 10, 2026 at 7:15 PM CEST, Uwe Kleine-König (The Capable Hub) wrote:
> > On Mon, May 18, 2026 at 12:04:01PM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> >> While being less compact, using named initializers allows to more easily
> >> see which members of the structs are assigned which value without having
> >> to lookup the declaration of the struct. And it's also more robust
> >> against changes to the struct definition.
> >>
> >> The mentioned robustness is relevant for a planned change to struct
> >> i2c_device_id that replaces .driver_data by an anonymous union.
> >>
> >> While touching all these arrays, unify usage of whitespace in the list
> >> terminator and drop trailing commas there.
> >>
> >> This patch doesn't modify the compiled arrays, only their representation
> >> in source form benefits. The former was confirmed with x86 and arm64
> >> builds.
> >>
> >> Signed-off-by: Uwe Kleine-König (The Capable Hub) <u.kleine-koenig@baylibre.com>
> >
> > who feels responsible to pick up this patch?
> 
> The affected files are mostly in drm-misc so I could apply it, but I think
> we'd need an ack from files belonging lsewhere (should be just nouveau and
> sitronix at quick glance).
> 
> >> base-commit: 254f49634ee16a731174d2ae34bc50bd5f45e731
> >> prerequisite-patch-id: 7779c63f16ef6f7247cdb71c89e66b27e299eb74
> >> prerequisite-patch-id: 6f920b6f8c31dc0ad1689200c37680755c20ce8b
> ...
> >> prerequisite-patch-id: 915b7a2276c5a38944107c84bb282271d0bf28f4
> >> prerequisite-patch-id: 76d499a624150588f7ef07dc087e70eca6f33419
> >
> > FTR: These are bogous, there are no dependencies, I just wasn't
> > attentive enough to drop these lines.
> 
> And 'b4 shazam' messes up because of these lines.
> 
> Overall I think it's better if you resend after splitting by tree, and
> removing the prerequisite-patch-id lines. You can keep my R-by on all the
> patches if you just split them without further changes.

Thanks for considering to merge, will rework as suggested.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]