From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66432C43458 for ; Mon, 29 Jun 2026 11:20:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A3E5B10E062; Mon, 29 Jun 2026 11:20:08 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="isRnHms0"; dkim-atps=neutral Received: from tor.source.kernel.org (tor.source.kernel.org [172.105.4.254]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB76A10E062 for ; Mon, 29 Jun 2026 11:20:06 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id CA44F60008; Mon, 29 Jun 2026 11:20:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 785D81F00A3E; Mon, 29 Jun 2026 11:19:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782732005; bh=B6cSgDNUNCaJrq5YwzbaI3oA+4ARO04BNnR9PnfFHCo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=isRnHms082rD0YpFSEFNAirC9nvfh4Nn4Wukfgndq3I2Za6wZ3cZIX3OAtKqyJ7Jk QbxmpIhxp4Zme+ZJuosxaLE4+d9zsfz/skW1tPR2ZZfSPRqJmpRppDTWUgZyVS1CHB 5QsW3n3TKw6RWILA0r+sB1OCe6Mi/a2ArdZ+CsZawVZxFaC5s8Q66AfZ53Z96KwYuW uZGsBXS1+y0VFETJSXBfuVdng+45W1oD9ZySufSdDejxCtS40h2780fAI1q4GM1Tvr c3+dPOqi24Z4+uI+6dYF9faK4Re6IYH+Fd0D81x/uqCCnIeztFgIByQ88ta8CCLLl0 zIbUQJ18s/EdQ== Date: Mon, 29 Jun 2026 13:19:43 +0200 From: Ingo Molnar To: Arnd Bergmann Cc: Juergen Gross , linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, "linux-edac@vger.kernel.org" , x86@kernel.org, linux-acpi@vger.kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-pci@vger.kernel.org, virtualization@lists.linux.dev, linux-ide@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-crypto@vger.kernel.org, "open list:GPIO SUBSYSTEM" , linux-hyperv@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-mtd@lists.infradead.org, platform-driver-x86@vger.kernel.org, "Rafael J . Wysocki" , Daniel Lezcano , Zhang Rui , "lukasz.luba@arm.com" , Jason Baron , Borislav Petkov , Tony Luck , Yazen Ghannam , Len Brown , Pavel Machek , Thomas Gleixner , Ingo Molnar , Dave Hansen , "H. Peter Anvin" , Sean Christopherson , Paolo Bonzini , "Kirill A. Shutemov" , Rick Edgecombe , Pu Wen , Bjorn Helgaas , Ajay Kaher , Alexey Makhalov , Broadcom internal kernel review list , Viresh Kumar , Reinette Chatre , Dave Martin , James Morse , Babu Moger , Tony W Wang-oc , Damien Le Moal , Niklas Cassel , Dave Airlie , Helge Deller , linux-geode@lists.infradead.org, Olivia Mackall , Herbert Xu , Linus Walleij , Bartosz Golaszewski , Greg Kroah-Hartman , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Long Li , Guenter Roeck , Peter Zijlstra , Arnaldo Carvalho de Melo , Namhyung Kim , Mark Rutland , Alexander Shishkin , Jiri Olsa , Ian Rogers , Adrian Hunter , James Clark , Josh Poimboeuf , Pawan Gupta , Vitaly Kuznetsov , Andy Lutomirski , Boris Ostrovsky , Huang Rui , Mario Limonciello , Perry Yuan , K Prateek Nayak , "srinivas.pandruvada@linux.intel.com" , Artem Bityutskiy , Artem Bityutskiy , Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , Ashok Raj , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Rajneesh Bhardwaj , David E Box , xen-devel@lists.xenproject.org Subject: Re: [PATCH 00/32] x86/msr: Drop 32-bit MSR interfaces Message-ID: References: <20260629060526.3638272-1-jgross@suse.com> <7332feff-2649-496c-8e49-b0a19eb54a32@app.fastmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7332feff-2649-496c-8e49-b0a19eb54a32@app.fastmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" * Arnd Bergmann wrote: > >>> Note that most patches of this series are independent from each other. > >>> Only the patches removing a specific interface (patches 7, 15, 26 and > >>> 30) and the last two patches of the series depend on all previous > >>> patches. > >> > >> It looks like you are touching most files twice or more here, to > >> first convert from rdmsr to rdmsrq and then to change the > >> two-argument rdmsrq() macro to a single-argument inline. If you > >> introduce the inline version of rdmsrq() first, you should be > >> able to skip the second step (patch 31) as they could be able > >> to coexist. > > > > I've discussed how to structure the series with Ingo Molnar before [1]. The > > current approach was his preference. > > Ok. Note that the individual patches are IMO significantly easier to review through the actual 32-bit => 64-bit variable assignment changes done in isolation (which sometimes include minor cleanups), while the Coccinelle semantic patch: { a(b,c) => c = a(b) } which changes both the function signature and the order of terms as well, is just a single add-on treewide patch. Thanks, Ingo