From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Anas Khan <anxkhn28@gmail.com>
Cc: "Matthew Brost" <matthew.brost@intel.com>,
"Thomas Hellström" <thomas.hellstrom@linux.intel.com>,
"Lucas De Marchi" <demarchi@kernel.org>,
intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/xe: remove duplicate <kunit/test-bug.h> include
Date: Fri, 3 Jul 2026 14:23:44 -0400 [thread overview]
Message-ID: <akf-MOs-gKIcGQ-9@intel.com> (raw)
In-Reply-To: <20260702112820.34675-1-anxkhn28@gmail.com>
On Thu, Jul 02, 2026 at 04:58:20PM +0530, Anas Khan wrote:
> xe_pci.c includes <kunit/test-bug.h> twice, separated only by the
> <kunit/test.h> include. Drop the redundant second include; this is a
> non-functional cleanup flagged by scripts/checkincludes.pl.
>
> Fixes: 6cad22853cb8 ("drm/xe/kunit: Add stub to read_gmdid")
> Signed-off-by: Anas Khan <anxkhn28@gmail.com>
> ---
> drivers/gpu/drm/xe/tests/xe_pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/tests/xe_pci.c b/drivers/gpu/drm/xe/tests/xe_pci.c
> index 9240aff779da..c2c686aed1cb 100644
> --- a/drivers/gpu/drm/xe/tests/xe_pci.c
> +++ b/drivers/gpu/drm/xe/tests/xe_pci.c
> @@ -9,7 +9,6 @@
>
> #include <kunit/test-bug.h>
> #include <kunit/test.h>
> -#include <kunit/test-bug.h>
Thanks for the patch, pushed to drm-xe-next
> #include <kunit/visibility.h>
>
> #define PLATFORM_CASE(platform__, graphics_step__) \
> --
> 2.54.0
>
prev parent reply other threads:[~2026-07-03 18:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 11:28 [PATCH] drm/xe: remove duplicate <kunit/test-bug.h> include Anas Khan
2026-07-03 18:23 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=akf-MOs-gKIcGQ-9@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=anxkhn28@gmail.com \
--cc=demarchi@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew.brost@intel.com \
--cc=thomas.hellstrom@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox