dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julia Lawall <julia.lawall@lip6.fr>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: intel-gfx@lists.freedesktop.org,
	Matthew Auld <matthew.auld@intel.com>,
	dri-devel@lists.freedesktop.org, kbuild-all@01.org
Subject: [drm-intel:drm-intel-next-queued 13/14] drivers/gpu/drm/i915/intel_guc.c:230:12-17: WARNING: Unsigned expression compared with zero: level < 0 (fwd)
Date: Tue, 20 Mar 2018 09:44:52 +0100 (CET)	[thread overview]
Message-ID: <alpine.DEB.2.20.1803200943520.3003@hadrien> (raw)

[-- Attachment #1: Type: text/plain, Size: 2846 bytes --]

Level is unsigned, so not less than 0 (line 230).

julia

---------- Forwarded message ----------
Date: Tue, 20 Mar 2018 16:39:16 +0800
From: kbuild test robot <fengguang.wu@intel.com>
To: kbuild@01.org
Cc: Julia Lawall <julia.lawall@lip6.fr>
Subject: [drm-intel:drm-intel-next-queued 13/14]
    drivers/gpu/drm/i915/intel_guc.c:230:12-17: WARNING: Unsigned expression
    compared with zero: level < 0

CC: kbuild-all@01.org
CC: intel-gfx@lists.freedesktop.org
CC: dri-devel@lists.freedesktop.org
TO: Chris Wilson <chris@chris-wilson.co.uk>
CC: Matthew Auld <matthew.auld@intel.com>

tree:   git://anongit.freedesktop.org/drm-intel drm-intel-next-queued
head:   873d66fb9b1d4f4cd441f84068abb5457c60f127
commit: 46b863325c2f58b564463c4d6e66ee0d4f2f3244 [13/14] drm/i915: Prefer memset64() when filling the iomap
:::::: branch date: 16 hours ago
:::::: commit date: 18 hours ago

>> drivers/gpu/drm/i915/intel_guc.c:230:12-17: WARNING: Unsigned expression compared with zero: level < 0

git remote add drm-intel git://anongit.freedesktop.org/drm-intel
git remote update drm-intel
git checkout 46b863325c2f58b564463c4d6e66ee0d4f2f3244
vim +230 drivers/gpu/drm/i915/intel_guc.c

5d53be45 Michal Wajdeczko 2017-10-16  224
cb5d64e9 Michał Winiarski 2018-03-19  225  static u32 get_log_control_flags(void)
0ed87953 Michal Wajdeczko 2018-01-11  226  {
cb5d64e9 Michał Winiarski 2018-03-19  227  	u32 level = i915_modparams.guc_log_level;
cb5d64e9 Michał Winiarski 2018-03-19  228  	u32 flags = 0;
0ed87953 Michal Wajdeczko 2018-01-11  229
cb5d64e9 Michał Winiarski 2018-03-19 @230  	GEM_BUG_ON(level < 0);
cb5d64e9 Michał Winiarski 2018-03-19  231
cb5d64e9 Michał Winiarski 2018-03-19  232  	if (!GUC_LOG_LEVEL_TO_ENABLED(level))
cb5d64e9 Michał Winiarski 2018-03-19  233  		flags |= GUC_LOG_DEFAULT_DISABLED;
cb5d64e9 Michał Winiarski 2018-03-19  234
cb5d64e9 Michał Winiarski 2018-03-19  235  	if (!GUC_LOG_LEVEL_TO_VERBOSE(level))
cb5d64e9 Michał Winiarski 2018-03-19  236  		flags |= GUC_LOG_DISABLED;
cb5d64e9 Michał Winiarski 2018-03-19  237  	else
cb5d64e9 Michał Winiarski 2018-03-19  238  		flags |= GUC_LOG_LEVEL_TO_VERBOSITY(level) <<
cb5d64e9 Michał Winiarski 2018-03-19  239  			 GUC_LOG_VERBOSITY_SHIFT;
0ed87953 Michal Wajdeczko 2018-01-11  240
cb5d64e9 Michał Winiarski 2018-03-19  241  	return flags;
0ed87953 Michal Wajdeczko 2018-01-11  242  }
0ed87953 Michal Wajdeczko 2018-01-11  243

:::::: The code at line 230 was first introduced by commit
:::::: cb5d64e9f13e0dd817c3ae2dbe73c3b8c6c13f95 drm/i915/guc: Allow user to control default GuC logging

:::::: TO: Michał Winiarski <michal.winiarski@intel.com>
:::::: CC: Chris Wilson <chris@chris-wilson.co.uk>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

                 reply	other threads:[~2018-03-20  8:52 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alpine.DEB.2.20.1803200943520.3003@hadrien \
    --to=julia.lawall@lip6.fr \
    --cc=chris@chris-wilson.co.uk \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=kbuild-all@01.org \
    --cc=matthew.auld@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox