Re: [Outreachy kernel] [PATCH DRM] drm: Shift * to be adjacent to pointer name

[Julia Lawall <julia.lawall@lip6.fr>]

On Tue, 16 Oct 2018, Mamta Shukla wrote:

> Shift * to be adjacent to pointer name to follow Linux coding style.
> Issue found with checkpatch.pl
> ERROR: "foo * bar" should be "foo *bar"

The patch looks OK, but at this point, you know how to send a patch, so it
would be better to focus on changes that are more complex than whitespace
issues.

julia


>
> Signed-off-by: Mamta Shukla <mamtashukla555@gmail.com>
> ---
>  drivers/gpu/drm/drm_memory.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_memory.c b/drivers/gpu/drm/drm_memory.c
> index d69e4fc..40c4349 100644
> --- a/drivers/gpu/drm/drm_memory.c
> +++ b/drivers/gpu/drm/drm_memory.c
> @@ -51,7 +51,7 @@
>  #endif
>
>  static void *agp_remap(unsigned long offset, unsigned long size,
> -		       struct drm_device * dev)
> +		       struct drm_device *dev)
>  {
>  	unsigned long i, num_pages =
>  	    PAGE_ALIGN(size) / PAGE_SIZE;
> @@ -94,26 +94,26 @@ static void *agp_remap(unsigned long offset, unsigned long size,
>  }
>
>  /** Wrapper around agp_free_memory() */
> -void drm_free_agp(struct agp_memory * handle, int pages)
> +void drm_free_agp(struct agp_memory *handle, int pages)
>  {
>  	agp_free_memory(handle);
>  }
>
>  /** Wrapper around agp_bind_memory() */
> -int drm_bind_agp(struct agp_memory * handle, unsigned int start)
> +int drm_bind_agp(struct agp_memory *handle, unsigned int start)
>  {
>  	return agp_bind_memory(handle, start);
>  }
>
>  /** Wrapper around agp_unbind_memory() */
> -int drm_unbind_agp(struct agp_memory * handle)
> +int drm_unbind_agp(struct agp_memory *handle)
>  {
>  	return agp_unbind_memory(handle);
>  }
>
>  #else /*  CONFIG_AGP  */
>  static inline void *agp_remap(unsigned long offset, unsigned long size,
> -			      struct drm_device * dev)
> +			      struct drm_device *dev)
>  {
>  	return NULL;
>  }
> --
> 1.9.1
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181015212644.GA28579%40armorer.
> For more options, visit https://groups.google.com/d/optout.
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel