From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julia Lawall Subject: [PATCH] drm/panfrost: fix odd_ptr_err.cocci warnings Date: Mon, 1 Apr 2019 21:36:12 +0200 (CEST) Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: Sender: linux-kernel-owner@vger.kernel.org To: Neil Armstrong Cc: Rob Herring , David Airlie , Daniel Vetter , "Marty E. Plummer" , Tomeu Vizoso , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, kbuild-all@01.org List-Id: dri-devel@lists.freedesktop.org From: kbuild test robot PTR_ERR should access the value just tested by IS_ERR Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci Fixes: 10f21de123ac ("drm/panfrost: add support for reset lines") CC: Neil Armstrong Signed-off-by: kbuild test robot Signed-off-by: Julia Lawall --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git panfrost-rebase-v2 head: 10f21de123ac13b8c257528b0b1222ebb5650510 commit: 10f21de123ac13b8c257528b0b1222ebb5650510 [7/7] drm/panfrost: add support for reset lines :::::: branch date: 10 hours ago :::::: commit date: 10 hours ago Please take the patch only if it's a positive warning. Thanks! panfrost_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/gpu/drm/panfrost/panfrost_device.c +++ b/drivers/gpu/drm/panfrost/panfrost_device.c @@ -21,7 +21,8 @@ static int panfrost_reset_init(struct pa pfdev->rstc = devm_reset_control_array_get(pfdev->dev, false, true); if (IS_ERR(pfdev->rstc)) { - dev_err(pfdev->dev, "get reset failed %ld\n", PTR_ERR(pfdev->clock)); + dev_err(pfdev->dev, "get reset failed %ld\n", + PTR_ERR(pfdev->rstc)); return PTR_ERR(pfdev->rstc); }