From mboxrd@z Thu Jan 1 00:00:00 1970 From: Finn Thain Subject: Re: [PATCH 09/12] nubus: use for_each_if Date: Mon, 9 Jul 2018 20:17:29 +1000 (AEST) Message-ID: References: <20180709083650.23549-1-daniel.vetter@ffwll.ch> <20180709083650.23549-9-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Return-path: In-Reply-To: <20180709083650.23549-9-daniel.vetter@ffwll.ch> Sender: linux-kernel-owner@vger.kernel.org To: Daniel Vetter Cc: LKML , DRI Development , Intel Graphics Development , Daniel Vetter , linux-m68k@lists.linux-m68k.org List-Id: dri-devel@lists.freedesktop.org On Mon, 9 Jul 2018, Daniel Vetter wrote: > Avoids the inverted check compared to the open-coded version. > > Signed-off-by: Daniel Vetter > Cc: Finn Thain > Cc: linux-m68k@lists.linux-m68k.org Acked-by: Finn Thain > --- > include/linux/nubus.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/nubus.h b/include/linux/nubus.h > index eba50b057f6f..17fd07578ef7 100644 > --- a/include/linux/nubus.h > +++ b/include/linux/nubus.h > @@ -127,7 +127,7 @@ struct nubus_rsrc *nubus_next_rsrc_or_null(struct nubus_rsrc *from); > for (f = nubus_first_rsrc_or_null(); f; f = nubus_next_rsrc_or_null(f)) > > #define for_each_board_func_rsrc(b, f) \ > - for_each_func_rsrc(f) if (f->board != b) {} else > + for_each_func_rsrc(f) for_each_if (f->board == b) > > /* These are somewhat more NuBus-specific. They all return 0 for > success and -1 for failure, as you'd expect. */ >