From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ross Zwisler Subject: Re: [PATCH] drm: Missed clflushopt in drm_clflush_virt_range Date: Mon, 21 Apr 2014 14:28:41 -0600 (MDT) Message-ID: References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 7276F6E161 for ; Mon, 21 Apr 2014 13:28:43 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ross Zwisler Cc: willy@linux.intel.com, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Wed, 2 Apr 2014, Ross Zwisler wrote: > With this commit: > > 2a0788dc9bc4 x86: Use clflushopt in drm_clflush_virt_range > > If clflushopt is available on the system, we use it instead of clflush > in drm_clflush_virt_range. There were two calls to clflush in this > function, but only one was changed to clflushopt. This patch changes > the other clflush call to clflushopt. > > Signed-off-by: Ross Zwisler > Reported-by: Matthew Wilcox > --- > drivers/gpu/drm/drm_cache.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/drm_cache.c b/drivers/gpu/drm/drm_cache.c > index 534cb89..041b73b 100644 > --- a/drivers/gpu/drm/drm_cache.c > +++ b/drivers/gpu/drm/drm_cache.c > @@ -138,7 +138,7 @@ drm_clflush_virt_range(char *addr, unsigned long length) > char *end = addr + length; > mb(); > for (; addr < end; addr += boot_cpu_data.x86_clflush_size) > - clflush(addr); > + clflushopt(addr); > clflushopt(end - 1); > mb(); > return; > -- > 1.7.10.4 Ping? :)