From: Meelis Roos <mroos@linux.ee>
To: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] radeon kms: fix uninitialised hotplug work usage in r100_irq_process()
Date: Thu, 29 Aug 2013 13:55:21 +0300 (EEST) [thread overview]
Message-ID: <alpine.SOC.1.00.1308291250350.2723@math.ut.ee> (raw)
In-Reply-To: <20130829092935.GB2235@swordfish>
> Reported-by: Meelis Roos <mroos@linux.ee>
> Signed-off-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
It works, thank you for quick response!
Tested-by: Meelis Roos <mroos@linux.ee>
> drivers/gpu/drm/radeon/radeon_irq_kms.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_irq_kms.c b/drivers/gpu/drm/radeon/radeon_irq_kms.c
> index 081886b..cc9e848 100644
> --- a/drivers/gpu/drm/radeon/radeon_irq_kms.c
> +++ b/drivers/gpu/drm/radeon/radeon_irq_kms.c
> @@ -275,17 +275,19 @@ int radeon_irq_kms_init(struct radeon_device *rdev)
> dev_info(rdev->dev, "radeon: using MSI.\n");
> }
> }
> +
> + INIT_WORK(&rdev->hotplug_work, radeon_hotplug_work_func);
> + INIT_WORK(&rdev->audio_work, r600_audio_update_hdmi);
> + INIT_WORK(&rdev->reset_work, radeon_irq_reset_work_func);
> +
> rdev->irq.installed = true;
> r = drm_irq_install(rdev->ddev);
> if (r) {
> rdev->irq.installed = false;
> + flush_work(&rdev->hotplug_work);
> return r;
> }
>
> - INIT_WORK(&rdev->hotplug_work, radeon_hotplug_work_func);
> - INIT_WORK(&rdev->audio_work, r600_audio_update_hdmi);
> - INIT_WORK(&rdev->reset_work, radeon_irq_reset_work_func);
> -
> DRM_INFO("radeon: irq initialized.\n");
> return 0;
> }
>
--
Meelis Roos (mroos@linux.ee)
next prev parent reply other threads:[~2013-08-29 10:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 21:23 3.11-rc3: radeon WARNING at kernel/workqueue.c:1378 __queue_work+0x132/0x16d() Meelis Roos
2013-08-19 8:58 ` Meelis Roos
2013-08-29 7:19 ` Meelis Roos
2013-08-29 8:34 ` Sergey Senozhatsky
2013-08-29 9:29 ` [PATCH] radeon kms: fix uninitialised hotplug work usage in r100_irq_process() Sergey Senozhatsky
2013-08-29 10:55 ` Meelis Roos [this message]
2013-08-29 18:27 ` Alex Deucher
2013-08-29 20:07 ` Greg Kroah-Hartman
2013-08-29 20:06 ` Alex Deucher
2013-08-29 20:28 ` Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.SOC.1.00.1308291250350.2723@math.ut.ee \
--to=mroos@linux.ee \
--cc=alexander.deucher@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergey.senozhatsky@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox