From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0475DC5AE5D for ; Mon, 10 Aug 2026 10:43:40 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3E07910E1DB; Mon, 10 Aug 2026 10:43:39 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="N5YCJPqk"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 859AF10E1DB for ; Mon, 10 Aug 2026 10:43:38 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 204DB43460; Mon, 10 Aug 2026 10:43:38 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3AA21F000E9; Mon, 10 Aug 2026 10:43:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1786358617; bh=GgZ70L0wlgjg35CbCp9eIm1NV7cv1FWYClANFiFsvW8=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=N5YCJPqkc9MoVS1gejFwO5Or9z7HmV3NM0Y2+2quFgMl9VygR13TRpA7IMNitvcKo m88VhiTNIhqNuaspNE8OFtVh3c/pD1nIxshzCJjjp1Qrgr32veAbtBXcX0ZMs0glcx AgN0JdC63xjiltCUc4tAPnUBNty8g2K3u3C6gLxwFtworLqJR4dvoJyOthaJFrpNJA dvIzaNqFRCsB0o2zqDQtw3GlRtUiWNTsn/2qeXj+WU9A9+HttMQS3vf9tKmLfa9zkV WVBfGYDTdDk8mOAw5pL2i5pw/ug6l9VXaVcH/l+ASWR5pUN72MZKT88TF1TQdndszl UY7KNvHFJY3Cg== Date: Mon, 10 Aug 2026 11:43:30 +0100 From: Daniel Thompson To: Ramiro Oliveira Cc: Lee Jones , Linus Walleij , Bartosz Golaszewski , Guenter Roeck , Andi Shyti , Jingoo Han , Helge Deller , Wim Van Sebroeck , "Rafael J. Wysocki" , Daniel Lezcano , Zhang Rui , Lukasz Luba , linux-kernel@vger.kernel.org, mfd@lists.linux.dev, linux-gpio@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-i2c@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-pm@vger.kernel.org, Wenkai Chung , Francisco Aragon-Trivino , Hongzhi Wang , Mikhail Tsukerman , Thomas Kastner Subject: Re: [PATCH v2 5/8] Add Advantech EIO Backlight driver Message-ID: References: <20260714-upstream-v2-v2-0-76e5e41026db@advantech.com> <20260714-upstream-v2-v2-5-76e5e41026db@advantech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260714-upstream-v2-v2-5-76e5e41026db@advantech.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jul 14, 2026 at 05:54:19PM +0200, Ramiro Oliveira wrote: > diff --git a/drivers/video/backlight/eio_bl.c b/drivers/video/backlight/eio_bl.c > new file mode 100644 > index 000000000000..c2826400de45 > --- /dev/null > +++ b/drivers/video/backlight/eio_bl.c > @@ -0,0 +1,243 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Backlight driver for Advantech EIO Embedded controller. > + * > + * Copyright (C) 2025 Advantech Corporation. All rights reserved. > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define PMC_BL_WRITE 0x20 > +#define PMC_BL_READ 0x21 > + > +#define BL_CTRL_STATUS 0x00 > +#define BL_CTRL_ENABLE 0x12 > +#define BL_CTRL_ENABLE_INVERT 0x13 > +#define BL_CTRL_DUTY 0x14 > +#define BL_CTRL_INVERT 0x15 > +#define BL_CTRL_FREQ 0x16 > + > +#define BL_MAX 2 > + > +#define BL_STATUS_AVAIL 0x01 > +#define BL_ENABLE_OFF 0x00 > +#define BL_ENABLE_ON 0x01 > +#define BL_ENABLE_AUTO BIT(1) > + > +#define USE_DEFAULT -1 > +#define THERMAL_MAX 100 > + > +static uint bri_freq = USE_DEFAULT; > +module_param(bri_freq, uint, 0444); > +MODULE_PARM_DESC(bri_freq, "Setup backlight PWM frequency.\n"); > + > +static int bri_invert = USE_DEFAULT; > +module_param(bri_invert, int, 0444); > +MODULE_PARM_DESC(bri_invert, "Setup backlight PWM polarity.\n"); > + > +static int bl_power_invert = USE_DEFAULT; > +module_param(bl_power_invert, int, 0444); > +MODULE_PARM_DESC(bl_power_invert, "Setup backlight enable pin polarity.\n"); There is still pending feedback on the module parameters and I can't see any reaction anywhere. : Module parameters are not really expected these days and are : pretty user hostile. : : Are they really needed? AFAICT this is a firmware based device. Why : doesn't the firmware provide this information if the drivers need it : (either directly or via PNP ID and a lookup table)? Please don't ignore feedback! Daniel.