From: Brian Norris <briannorris@chromium.org>
To: Sean Rhodes <sean@starlabs.systems>
Cc: chrome-platform@lists.linux.dev, corentin.chary@gmail.com,
luke@ljones.dev, denis.benato@linux.dev, hansg@kernel.org,
ilpo.jarvinen@linux.intel.com, prasanth.ksr@dell.com,
jorge.lopez2@hp.com, mpearson-lenovo@squebb.ca,
derekjohn.clark@gmail.com, josh@joshuagrisham.com,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org, Dell.Client.Kernel@dell.com,
florian.fainelli@broadcom.com, chenhuacai@kernel.org,
mst@redhat.com, wenst@chromium.org, tzungbi@kernel.org,
jwerner@chromium.org, tzimmermann@suse.de, javierm@redhat.com,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
airlied@gmail.com, simona@ffwll.ch,
krzysztof.kozlowski@oss.qualcomm.com, andersson@kernel.org,
geert@linux-m68k.org, dmitry.baryshkov@oss.qualcomm.com,
arnd@arndb.de, ebiggers@kernel.org, luca.weiss@fairphone.com,
michal.simek@amd.com, sven@kernel.org,
u.kleine-koenig@baylibre.com, bhelgaas@google.com,
dakr@kernel.org, o-takashi@sakamocchi.jp,
titouan.ameline@gmail.com, kees@kernel.org,
dri-devel@lists.freedesktop.org, oliver@liuxiaozhen.dev
Subject: Re: [PATCH v12 3/4] firmware: Rename google firmware directory to coreboot
Date: Tue, 11 Aug 2026 11:52:49 -0700 [thread overview]
Message-ID: <antvgf6pF8JbW9BA@google.com> (raw)
In-Reply-To: <CABtds-3MAA8y5ksGcps6s-iLx8dOF7EoJEJH9079Y_E+-bJB4A@mail.gmail.com>
Hi Sean,
On Thu, Aug 06, 2026 at 01:28:26PM -0700, Sean Rhodes wrote:
> Most drivers in drivers/firmware/google are coreboot table drivers rather
> than Google-specific firmware drivers. Rename the directory to coreboot
> and update the Kconfig prompt, build path and maintainer entry.
>
> Keep the existing CONFIG_GOOGLE_* symbols to avoid user configuration
> churn in this mechanical move.
>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
> ---
> MAINTAINERS | 4 ++--
> drivers/firmware/Kconfig | 2 +-
> drivers/firmware/Makefile | 2 +-
> drivers/firmware/{google => coreboot}/Kconfig | 6 +++---
> drivers/firmware/{google => coreboot}/Makefile | 0
> drivers/firmware/{google => coreboot}/cbmem.c | 0
> drivers/firmware/{google => coreboot}/coreboot_table.c | 0
> drivers/firmware/{google => coreboot}/coreboot_table.h | 0
> .../firmware/{google => coreboot}/framebuffer-coreboot.c | 0
> drivers/firmware/{google => coreboot}/gsmi.c | 0
> drivers/firmware/{google => coreboot}/memconsole-coreboot.c | 0
> .../firmware/{google => coreboot}/memconsole-x86-legacy.c | 0
> drivers/firmware/{google => coreboot}/memconsole.c | 0
> drivers/firmware/{google => coreboot}/memconsole.h | 6 +++---
> drivers/firmware/{google => coreboot}/vpd.c | 0
> drivers/firmware/{google => coreboot}/vpd_decode.c | 0
> drivers/firmware/{google => coreboot}/vpd_decode.h | 0
> 17 files changed, 10 insertions(+), 10 deletions(-)
> rename drivers/firmware/{google => coreboot}/Kconfig (94%)
> rename drivers/firmware/{google => coreboot}/Makefile (100%)
> rename drivers/firmware/{google => coreboot}/cbmem.c (100%)
> rename drivers/firmware/{google => coreboot}/coreboot_table.c (100%)
> rename drivers/firmware/{google => coreboot}/coreboot_table.h (100%)
> rename drivers/firmware/{google => coreboot}/framebuffer-coreboot.c (100%)
> rename drivers/firmware/{google => coreboot}/gsmi.c (100%)
> rename drivers/firmware/{google => coreboot}/memconsole-coreboot.c (100%)
> rename drivers/firmware/{google => coreboot}/memconsole-x86-legacy.c (100%)
> rename drivers/firmware/{google => coreboot}/memconsole.c (100%)
> rename drivers/firmware/{google => coreboot}/memconsole.h (82%)
> rename drivers/firmware/{google => coreboot}/vpd.c (100%)
> rename drivers/firmware/{google => coreboot}/vpd_decode.c (100%)
> rename drivers/firmware/{google => coreboot}/vpd_decode.h (100%)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e6a8c271e79d..62ddee473f55 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11069,14 +11069,14 @@ S: Maintained
> F: Documentation/networking/device_drivers/ethernet/google/gve.rst
> F: drivers/net/ethernet/google
>
> -GOOGLE FIRMWARE DRIVERS
> +COREBOOT FIRMWARE DRIVERS
I won't weigh in on the Google-to-Coreboot naming, but if you're doing
it...
...this leaves MAINTAINERS sorted incorrectly. You'll need to move this
entry between "CONTROL GROUP ..." and "CORETEMP ...".
> M: Tzung-Bi Shih <tzungbi@kernel.org>
> R: Brian Norris <briannorris@chromium.org>
> R: Julius Werner <jwerner@chromium.org>
> L: chrome-platform@lists.linux.dev
> S: Maintained
> T: git git://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git
> -F: drivers/firmware/google/
> +F: drivers/firmware/coreboot/
> F: include/linux/coreboot.h
>
> GOOGLE TENSOR SoC SUPPORT
...
> diff --git a/drivers/firmware/google/Makefile
> b/drivers/firmware/coreboot/Makefile
I think something about how you sent v12 has broken a few things:
1) some aritificial line-breaks; the above 2 lines should be 1 line.
This breaks `git am`
2) the email threading seems missing
v11 and most (all?) previous versions didn't have this problem.
Brian
prev parent reply other threads:[~2026-08-11 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 20:28 [PATCH v12 3/4] firmware: Rename google firmware directory to coreboot Sean Rhodes
2026-08-11 18:52 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=antvgf6pF8JbW9BA@google.com \
--to=briannorris@chromium.org \
--cc=Dell.Client.Kernel@dell.com \
--cc=airlied@gmail.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=chenhuacai@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=corentin.chary@gmail.com \
--cc=dakr@kernel.org \
--cc=denis.benato@linux.dev \
--cc=derekjohn.clark@gmail.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiggers@kernel.org \
--cc=florian.fainelli@broadcom.com \
--cc=geert@linux-m68k.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jorge.lopez2@hp.com \
--cc=josh@joshuagrisham.com \
--cc=jwerner@chromium.org \
--cc=kees@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=luke@ljones.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=mripard@kernel.org \
--cc=mst@redhat.com \
--cc=o-takashi@sakamocchi.jp \
--cc=oliver@liuxiaozhen.dev \
--cc=platform-driver-x86@vger.kernel.org \
--cc=prasanth.ksr@dell.com \
--cc=sean@starlabs.systems \
--cc=simona@ffwll.ch \
--cc=sven@kernel.org \
--cc=titouan.ameline@gmail.com \
--cc=tzimmermann@suse.de \
--cc=tzungbi@kernel.org \
--cc=u.kleine-koenig@baylibre.com \
--cc=wenst@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox