From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DED6BC61DBD for ; Wed, 26 Aug 2026 06:07:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E71AA10E1ED; Wed, 26 Aug 2026 06:07:24 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="ec8j9Kuu"; dkim-atps=neutral Received: from sea.source.kernel.org (sea.source.kernel.org [172.234.252.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id 32A1E10E1ED for ; Wed, 26 Aug 2026 06:07:23 +0000 (UTC) Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 8FCEB4363B; Wed, 26 Aug 2026 06:07:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2787D1F000E9; Wed, 26 Aug 2026 06:07:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1787724442; bh=Sz6PqnW19SjpOwoLfiJCtjkUAIIP+g2E+lZPpGrN7vE=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=ec8j9KuuhQ1aODrKh1IPPW+t5WNcQsJOuDmTb7EYk3BlxAjuBgWd1vM1s+lyrnECR oEt2GQDNHfmzo5g7hXaH7L0douvY7fjdP0QkraRH3OHgMhBrmjArbgk4CZf7cnsNvn aHTM7H8r5TPzyZvKI8A6uy7HJ/+Hc7T6p46c9yqWUM61UQih0nnbRAWnhdPCgVlijm prY2wsx1oAKoWxEnzYNMYJrBZreDK3jZA48HXBYzJbpZLzqvMKyTPqwwGwBhQkAWux mBj+1ZNWkXaWBrkUiQxOsV/dVnhzGDLA8nPR6+qiZEqgkywzF+VGu1B2tZcfDVjoNE E4BFhWg9UIoGQ== Date: Wed, 26 Aug 2026 06:07:14 +0000 From: Tzung-Bi Shih To: Sean Rhodes Cc: linux-kernel@vger.kernel.org, Corentin Chary , "Luke D. Jones" , Denis Benato , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Prasanth Ksr , Jorge Lopez , Mark Pearson , "Derek J. Clark" , Joshua Grisham , platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com, "Michael S. Tsirkin" , Chen-Yu Tsai , Huacai Chen , Brian Norris , Julius Werner , Thomas Zimmermann , Javier Martinez Canillas , Maarten Lankhorst , Maxime Ripard , David Airlie , Simona Vetter , Florian Fainelli , Danilo Krummrich , Uwe =?iso-8859-1?Q?Kleine-K=F6nig_=28The_Capable_Hub=29?= , Titouan Ameline de Cadeville , Takashi Sakamoto , Kees Cook , Bjorn Helgaas , chrome-platform@lists.linux.dev, dri-devel@lists.freedesktop.org, Krzysztof Kozlowski , Bjorn Andersson , Dmitry Baryshkov , Geert Uytterhoeven , Arnd Bergmann , Eric Biggers , Luca Weiss , Michal Simek , Sven Peter Subject: Re: [PATCH v13 RESEND 1/5] platform/x86: Sort firmware attributes class includes Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, Aug 24, 2026 at 04:08:58PM +0100, Sean Rhodes wrote: > Move firmware_attributes_class.h into the main include block and sort the > affected includes. This lets the header move replace each include in place. ... > diff --git a/drivers/platform/x86/asus-armoury.c b/drivers/platform/x86/asus-armoury.c > index 495dc1e31d40..f3d8c5a85762 100644 > --- a/drivers/platform/x86/asus-armoury.c > +++ b/drivers/platform/x86/asus-armoury.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include "firmware_attributes_class.h" > #include > #include > #include I don't really follow why it is beneficial to make the firmware_attributes_class.h replacement in-place. Moving relative includes like "firmware_attributes_class.h" into the block creates an awkward intermediate state. How about drop patch 1 and simply update the includes directly in patch 2?