dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Andi Shyti <andi.shyti@kernel.org>
To: Krzysztof Karas <krzysztof.karas@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	 Jani Nikula <jani.nikula@linux.intel.com>,
	Andi Shyti <andi.shyti@linux.intel.com>,
	 Janusz Krzysztofik <janusz.krzysztofik@linux.intel.com>,
	Sebastian Brzezinka <sebastian.brzezinka@intel.com>,
	 Krzysztof Niemiec <krzysztof.niemiec@intel.com>
Subject: Re: [PATCH v2 3/8] drm/i915/selftests: Use drm_* prints in live selftests
Date: Fri, 28 Aug 2026 01:32:51 +0200	[thread overview]
Message-ID: <apDIqBvvWCSJugXb@zenone.zhora.eu> (raw)
In-Reply-To: <20260818095624.3254368-4-krzysztof.karas@intel.com>

Hi Krzysztof,

> @@ -71,11 +73,11 @@ static int populate_ggtt(struct i915_ggtt *ggtt, struct list_head *objects)
>  		quirk_add(obj, objects);
>  		count++;
>  	} while (1);
> -	pr_debug("Filled GGTT with %lu pages [%llu total]\n",
> -		 count, ggtt->vm.total / PAGE_SIZE);
> +	drm_dbg(&ggtt->vm.i915->drm, "Filled GGTT with %lu pages [%llu total]\n",
> +		count, ggtt->vm.total / PAGE_SIZE);
>  
>  	if (list_empty(&ggtt->vm.bound_list)) {
> -		pr_err("No objects on the GGTT inactive list!\n");
> +		drm_err(&ggtt->vm.i915->drm, "No objects on the GGTT inactive list!\n");

Instead of using these long ->...->...->... just save drm locally
and you even save characters to comply with Janusz review. Same
goes for the rest.

Thanks,
Andi

  parent reply	other threads:[~2026-08-27 23:32 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-18  9:56 [PATCH v2 0/8] drm/i915/selftests: Modernize printing in i915 selftests Krzysztof Karas
2026-08-18  9:56 ` [PATCH v2 1/8] drm/i915/selftests: Use drm_* prints in mock selftests Krzysztof Karas
2026-08-18 10:05   ` sashiko-bot
2026-08-24  7:10   ` Janusz Krzysztofik
2026-08-18  9:56 ` [PATCH v2 2/8] drm/i915/selftest: Fix a typo in alloc_workqueue call Krzysztof Karas
2026-08-24  7:11   ` Janusz Krzysztofik
2026-08-27 23:28   ` Andi Shyti
2026-08-18  9:56 ` [PATCH v2 3/8] drm/i915/selftests: Use drm_* prints in live selftests Krzysztof Karas
2026-08-24  8:31   ` Janusz Krzysztofik
2026-08-27 23:32   ` Andi Shyti [this message]
2026-08-18  9:56 ` [PATCH v2 4/8] drm/i915/selftests: Use drm_* prints in selftest helpers Krzysztof Karas
2026-08-27 23:34   ` Andi Shyti
2026-08-18  9:56 ` [PATCH v2 5/8] drm/i915/gt/selftests: Use drm_* prints in aggregated gt selftests Krzysztof Karas
2026-08-27 23:38   ` Andi Shyti
2026-08-28  9:08     ` Janusz Krzysztofik
2026-08-18  9:56 ` [PATCH v2 6/8] drm/i915/gt/selftests: Use drm_* prints in gt standalone tests Krzysztof Karas
2026-08-27 23:41   ` Andi Shyti
2026-08-18  9:56 ` [PATCH v2 7/8] drm/i915/gt/selftests: Use drm_* prints in gt selftest helpers Krzysztof Karas
2026-08-27 23:44   ` Andi Shyti
2026-08-18  9:56 ` [PATCH v2 8/8] drm/i915/selftests: Use drm_* prints in selftest headers Krzysztof Karas
2026-08-18 10:08   ` sashiko-bot
2026-08-18 10:09   ` Krzysztof Karas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=apDIqBvvWCSJugXb@zenone.zhora.eu \
    --to=andi.shyti@kernel.org \
    --cc=andi.shyti@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=janusz.krzysztofik@linux.intel.com \
    --cc=krzysztof.karas@intel.com \
    --cc=krzysztof.niemiec@intel.com \
    --cc=sebastian.brzezinka@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox