From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Sean Rhodes <sean@starlabs.systems>
Cc: linux-kernel@vger.kernel.org, "Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Corentin Chary" <corentin.chary@gmail.com>,
"Luke D. Jones" <luke@ljones.dev>,
"Denis Benato" <denis.benato@linux.dev>,
"Prasanth Ksr" <prasanth.ksr@dell.com>,
"Jorge Lopez" <jorge.lopez2@hp.com>,
"Mark Pearson" <mpearson-lenovo@squebb.ca>,
"Derek J. Clark" <derekjohn.clark@gmail.com>,
"Joshua Grisham" <josh@joshuagrisham.com>,
"Will Deacon" <will@kernel.org>,
"Douglas Anderson" <dianders@chromium.org>,
"Kiryl Shutsemau (Meta)" <kas@kernel.org>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Chen-Yu Tsai" <wenst@chromium.org>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
platform-driver-x86@vger.kernel.org, Dell.Client.Kernel@dell.com,
"Brian Norris" <briannorris@chromium.org>,
"Julius Werner" <jwerner@chromium.org>,
"Javier Martinez Canillas" <javierm@redhat.com>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"Uwe Kleine-König (The Capable Hub)"
<u.kleine-koenig@baylibre.com>,
"Titouan Ameline de Cadeville" <titouan.ameline@gmail.com>,
"Laxman Acharya Padhya" <acharyalaxman8848@gmail.com>,
"Yidi Lin" <yidilin@google.com>, "Kees Cook" <kees@kernel.org>,
"Takashi Sakamoto" <o-takashi@sakamocchi.jp>,
chrome-platform@lists.linux.dev,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>,
dri-devel@lists.freedesktop.org,
"Krzysztof Kozlowski" <krzysztof.kozlowski@oss.qualcomm.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"Geert Uytterhoeven" <geert@linux-m68k.org>,
"Arnd Bergmann" <arnd@arndb.de>,
"Eric Biggers" <ebiggers@kernel.org>,
"Luca Weiss" <luca.weiss@fairphone.com>,
"Michal Simek" <michal.simek@amd.com>,
"Sven Peter" <sven@kernel.org>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Linus Walleij" <linusw@kernel.org>,
"Drew Fustini" <fustini@kernel.org>,
linux-arm-kernel@lists.infradead.org, soc@lists.linux.dev
Subject: Re: [PATCH v14 1/5] firmware: Move firmware attributes class helper
Date: Wed, 2 Sep 2026 10:14:27 +0000 [thread overview]
Message-ID: <apf3AwibD6RiYlwk@google.com> (raw)
In-Reply-To: <5682c2228fa4a784d3953664b56a06e0dd9ccdef.1788284852.git.sean@starlabs.systems>
On Tue, Sep 01, 2026 at 06:48:02PM +0100, Sean Rhodes wrote:
> Move the firmware attributes class helper from drivers/platform/x86 to
> drivers/firmware and expose its class declaration through a public Linux
> header.
>
> The helper is not x86-specific. Keeping it in drivers/firmware lets
> coreboot firmware drivers use the standard firmware-attributes ABI without
> living under platform/x86.
>
> Replace the affected drivers' relative helper includes directly with the
> new public header.
>
> Suggested-by: Derek J. Clark <derekjohn.clark@gmail.com>
> Reviewed-by: Mark Pearson <mpearson-lenovo@squebb.ca>
> Reviewed-by: Derek J. Clark <derekjohn.clark@gmail.com>
> Tested-by: Oliver Lin <oliver@liuxiaozhen.dev>
> Signed-off-by: Sean Rhodes <sean@starlabs.systems>
LGTM,
Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
next prev parent reply other threads:[~2026-09-02 10:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 17:48 [PATCH v14 0/5] coreboot CFR firmware attributes Sean Rhodes
2026-09-01 17:48 ` [PATCH v14 1/5] firmware: Move firmware attributes class helper Sean Rhodes
2026-09-02 10:14 ` Tzung-Bi Shih [this message]
2026-09-01 17:48 ` [PATCH v14 2/5] firmware: Rename google firmware directory to coreboot Sean Rhodes
2026-09-01 17:48 ` [PATCH v14 3/5] drm/sysfb: Update coreboot framebuffer Kconfig symbol Sean Rhodes
2026-09-04 9:10 ` Thomas Zimmermann
2026-09-01 17:48 ` [PATCH v14 4/5] firmware: coreboot: Add CFR firmware attributes driver Sean Rhodes
2026-09-01 17:48 ` [PATCH v14 5/5] arm64: defconfig: Update coreboot firmware symbols Sean Rhodes
2026-09-02 10:01 ` (subset) [PATCH v14 0/5] coreboot CFR firmware attributes Tzung-Bi Shih
2026-09-02 10:01 ` Sean Rhodes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=apf3AwibD6RiYlwk@google.com \
--to=tzungbi@kernel.org \
--cc=Dell.Client.Kernel@dell.com \
--cc=acharyalaxman8848@gmail.com \
--cc=airlied@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=briannorris@chromium.org \
--cc=chenhuacai@kernel.org \
--cc=chrome-platform@lists.linux.dev \
--cc=corentin.chary@gmail.com \
--cc=dakr@kernel.org \
--cc=denis.benato@linux.dev \
--cc=derekjohn.clark@gmail.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ebiggers@kernel.org \
--cc=fustini@kernel.org \
--cc=geert@linux-m68k.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=javierm@redhat.com \
--cc=jorge.lopez2@hp.com \
--cc=josh@joshuagrisham.com \
--cc=jwerner@chromium.org \
--cc=kas@kernel.org \
--cc=kees@kernel.org \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linusw@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=luke@ljones.dev \
--cc=maarten.lankhorst@linux.intel.com \
--cc=michal.simek@amd.com \
--cc=mpearson-lenovo@squebb.ca \
--cc=mripard@kernel.org \
--cc=o-takashi@sakamocchi.jp \
--cc=platform-driver-x86@vger.kernel.org \
--cc=prasanth.ksr@dell.com \
--cc=sean@starlabs.systems \
--cc=simona@ffwll.ch \
--cc=soc@lists.linux.dev \
--cc=sven@kernel.org \
--cc=titouan.ameline@gmail.com \
--cc=tzimmermann@suse.de \
--cc=u.kleine-koenig@baylibre.com \
--cc=wenst@chromium.org \
--cc=will@kernel.org \
--cc=yidilin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox