From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23787C624D4 for ; Wed, 2 Sep 2026 15:40:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 64B7B10F293; Wed, 2 Sep 2026 15:40:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=collabora.com header.i=adrian.larumbe@collabora.com header.b="jkNXlx62"; dkim-atps=neutral Received: from sender6-op-o11.zoho.com (sender6-op-o11.zoho.com [165.173.180.11]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3296C10F293 for ; Wed, 2 Sep 2026 15:40:50 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1788363641; cv=none; d=zohomail.com; s=zohoarc; b=ILCIbY9Qtl+4SN8TsR0Q8EkU7PO2wG7DDY24PhJB6w76lz7Uh2gI2NS69Lc6LigxGp9QabyvaDZTjSNzM4Ky8rsKeesKbHUs4rQeNrPe6te/gL9jCyqU9ZW6XlZzuMpp0PU9EkemZjOhF6MSmwpzn5QHM1zO4b1kt3QwKvRQvAI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1788363641; h=Content-Type:Content-Transfer-Encoding:Cc:Cc:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:Subject:Subject:To:To:Message-Id:Reply-To; bh=J3INOkfEBcY2jrUN32fay3pZ8r/lpRUuqtPv/+3HQmw=; b=krOrEa0nbpGHZVhfoA0H5NCvgZ7DDuSbJ281NvhWQAMXgoN2Y4HLsjeWtpOTGgvsEAnjUOysPR94Uu7QC+lrYRMgWekOVzqsdmI16HUs6ON5heM82t+JEOb4eMsS7LBlM/81OtvDc/zzwWs0fB0QDo+4/0T5Jkd/y6327aZuf+I= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=collabora.com; spf=pass smtp.mailfrom=adrian.larumbe@collabora.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1788363641; s=zohomail; d=collabora.com; i=adrian.larumbe@collabora.com; h=Date:Date:From:From:To:To:Cc:Cc:Subject:Subject:Message-ID:MIME-Version:Content-Type:Content-Transfer-Encoding:In-Reply-To:Message-Id:Reply-To; bh=J3INOkfEBcY2jrUN32fay3pZ8r/lpRUuqtPv/+3HQmw=; b=jkNXlx62mBk6t4LO/YAPV5ruhcemaYR8Z1YFEbQ8Ll5ONzBDZUgXGnSz30t6ZYsy 4hQTG88oUYB5M73QyS2X7DLoEmS1rtZlxvw58fLNPYrLwGMSbH+pVkU8rtatMJvliFt tSjjzjrrEQ8WILjZVHjKWiMPJiTyAAtyZ3rwTKbs= Received: by mx.zohomail.com with SMTPS id 178836363895380.82453922758862; Wed, 2 Sep 2026 08:40:38 -0700 (PDT) Date: Wed, 2 Sep 2026 16:40:32 +0100 From: =?utf-8?Q?Adri=C3=A1n?= Larumbe To: Boris Brezillon Cc: Rob Herring , Steven Price , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Faith Ekstrand , "Marty E. Plummer" , Tomeu Vizoso , Eric Anholt , Alyssa Rosenzweig , Robin Murphy , Philipp Zabel , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Collabora Kernel Team , Neil Armstrong Subject: Re: [PATCH v7 04/17] drm/panfrost: Move debugfs initialisation to relevant subsystems Message-ID: References: <20260828-claude-fixes-v7-0-72a13b2c125d@collabora.com> <20260828-claude-fixes-v7-4-72a13b2c125d@collabora.com> <20260901143057.47497b30@fedora-21.home> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260901143057.47497b30@fedora-21.home> X-Zoho-Virus-Status: 1 X-Zoho-AV-Stamp: zmail-av-0.2.13.1.5.4/288.352.18 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 01.09.2026 14:30, Boris Brezillon wrote: > On Fri, 28 Aug 2026 21:56:44 +0100 > Adrián Larumbe wrote: > > > @@ -757,4 +758,28 @@ void panfrost_gem_debugfs_print_bos(struct panfrost_device *pfdev, > > seq_printf(m, "Total size: %zd, Total resident: %zd, Total reclaimable: %zd\n", > > totals.size, totals.resident, totals.reclaimable); > > } > > + > > +static int panfrost_gems_show(struct seq_file *m, void *data) > > +{ > > + struct drm_info_node *node = m->private; > > + struct panfrost_device *pfdev = to_panfrost_device(node->minor->dev); > > + > > + panfrost_gem_debugfs_print_bos(pfdev, m); > > + > > + return 0; > > +} > > + > > +static struct drm_info_list panfrost_debugfs_list[] = { > > + {"gems", > > + panfrost_gems_show, 0, NULL}, > > +}; > > + > > +int panfrost_gems_debugfs_init(struct drm_minor *minor) > > > nit: I would rename that one panfrost_gem_debugfs_init(). Will do. > The rest looks good > > Reviewed-by: Boris Brezillon > > > +{ > > + drm_debugfs_create_files(panfrost_debugfs_list, > > + ARRAY_SIZE(panfrost_debugfs_list), > > + minor->debugfs_root, minor); > > + > > + return 0; > > +} Adrian Larumbe