From: Ian Ray <ian.ray@gehealthcare.com>
To: Jonas Karlman <jonas@kwiboo.se>
Cc: Andrzej Hajda <andrzej.hajda@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Robert Foss <rfoss@kernel.org>,
Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
Lucas Stach <l.stach@pengutronix.de>,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 2/3] drm/bridge: dw-hdmi: optionally ignore rxsense when detecting hotplug
Date: Wed, 2 Sep 2026 20:08:27 +0300 [thread overview]
Message-ID: <aphYC5J0ggfKzLZJ@zeus> (raw)
In-Reply-To: <7b26a257-534b-4bb1-a6a4-17d3d41aa374@kwiboo.se>
On Wed, Sep 02, 2026 at 05:38:34PM +0200, Jonas Karlman wrote:
> Hi Ian,
>
> On 9/2/2026 3:01 PM, Ian Ray wrote:
> > Commit da09daf88108 ("drm: bridge: dw_hdmi: only trigger hotplug event
> > on link change") changed the way hotplug is detected to take into
> > consideration rxsense.
> >
> > That change is problematic for boards where rxsense is always detected,
> > such as when an HDMI to DP converter is used.
>
> I have a series [1] with a patch [2] that tries to fully remove the
> rxsense part from the dw-hdmi driver, any help to test that series is
> welcomed. Should likely solve the issue you are trying to workaround
> here.
>
> Planning on sending out a v8 next few days now that v7.3-rc1 have landed.
>
> [1] https://lore.kernel.org/all/20260518180206.2480119-1-jonas@kwiboo.se/
> [2] https://lore.kernel.org/all/20260518180206.2480119-21-jonas@kwiboo.se/
Thank you -- your series does indeed solve my problem.
I will reply to [2] with a Tested-by: tag.
>
> Regards,
> Jonas
>
> >
> > Introduce an optional property 'ignore-rxsense' to handle such boards.
> >
> > Fixes: da09daf88108 ("drm: bridge: dw_hdmi: only trigger hotplug event on link change")
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Ian Ray <ian.ray@gehealthcare.com>
> > ---
> > drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 6 ++++++
> > 1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > index 34c5f583e910..a9337d1f4b88 100644
> > --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> > @@ -171,6 +171,7 @@ struct dw_hdmi {
> > bool disabled; /* DRM has disabled our bridge */
> > bool bridge_is_on; /* indicates the bridge is on */
> > bool rxsense; /* rxsense state */
> > + bool ignore_rxsense; /* use HPD only, ignore rxsense for detect */
> > u8 phy_mask; /* desired phy int mask settings */
> > u8 mc_clkdis; /* clock disable register */
> >
> > @@ -3156,6 +3157,9 @@ static irqreturn_t dw_hdmi_irq(int irq, void *dev_id)
> > if (phy_stat & HDMI_PHY_HPD)
> > status = connector_status_connected;
> >
> > + if (hdmi->ignore_rxsense)
> > + phy_stat &= ~HDMI_PHY_RX_SENSE;
> > +
> > if (!(phy_stat & (HDMI_PHY_HPD | HDMI_PHY_RX_SENSE)))
> > status = connector_status_disconnected;
> > }
> > @@ -3362,6 +3366,8 @@ struct dw_hdmi *dw_hdmi_probe(struct platform_device *pdev,
> > mutex_init(&hdmi->cec_notifier_mutex);
> > spin_lock_init(&hdmi->audio_lock);
> >
> > + hdmi->ignore_rxsense = of_property_read_bool(np, "ignore-rxsense");
> > +
> > ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
> > if (ddc_node) {
> > hdmi->ddc = of_get_i2c_adapter_by_node(ddc_node);
>
next prev parent reply other threads:[~2026-09-03 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-02 13:01 [PATCH v1 1/3] dt-bindings: display: synopsys, dw-hdmi: add ignore-rxsense Ian Ray
2026-09-02 13:01 ` [PATCH v1 2/3] drm/bridge: dw-hdmi: optionally ignore rxsense when detecting hotplug Ian Ray
2026-09-02 13:16 ` sashiko-bot
2026-09-02 15:38 ` Jonas Karlman
2026-09-02 17:08 ` Ian Ray [this message]
2026-09-02 17:32 ` [PATCH v1 1/3] dt-bindings: display: synopsys,dw-hdmi: add ignore-rxsense Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aphYC5J0ggfKzLZJ@zeus \
--to=ian.ray@gehealthcare.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=l.stach@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.ceresoli@bootlin.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox