From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 98552C624D3 for ; Fri, 4 Sep 2026 14:42:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CECC210E574; Fri, 4 Sep 2026 14:42:22 +0000 (UTC) X-Greylist: delayed 502 seconds by postgrey-1.36 at gabe; Fri, 04 Sep 2026 14:42:21 UTC Received: from relay01.th.seeweb.it (relay01.th.seeweb.it [5.144.164.162]) by gabe.freedesktop.org (Postfix) with ESMTPS id 913BD10E574 for ; Fri, 4 Sep 2026 14:42:21 +0000 (UTC) Received: from SoMainline.org (94-211-6-86.cable.dynamic.v4.ziggo.nl [94.211.6.86]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 24E12201F5; Fri, 4 Sep 2026 16:33:56 +0200 (CEST) Date: Fri, 4 Sep 2026 16:33:54 +0200 From: Marijn Suijten To: Linus Walleij Cc: Neil Armstrong , Sam Ravnborg , David Airlie , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Simona Vetter , Casey Connolly , Rob Herring , Krzysztof Kozlowski , Simona Vetter , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Martin Botka , Jami Kettunen , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, Abhinav Kumar , Kuogee Hsieh , Jessica Zhang , AngeloGioacchino Del Regno , Konrad Dybcio , Konrad Dybcio , Dmitry Baryshkov Subject: Re: [PATCH v2 00/11] drm/panel: Add 5 DDIC panel drivers for 14 Sony phones Message-ID: References: <20251222-drm-panels-sony-v2-0-82a87465d163@somainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Linus, On 2026-09-03 00:22:41, Linus Walleij wrote: > Hi Marijn, > > On Mon, Dec 22, 2025 at 12:32 AM Marijn Suijten > wrote: > > > This is the second version of a largely reshaped series that brings 5 > > new DDIC panel drivers (4 Samsung, 1 LGD) that are compatible with 14 > > Sony phones: > > What's up with this series? This is repeatedly blocked on the request to factor out a generic Samsung panel library. While commands look very similar across drivers, the same commands are given (sometimes) different names [1] and without spec I simply don't feel comfortable writing such a library as that'd sound like claiming I definitively know exactly what each of those commands mean / are named. I don't. [1]: https://lore.kernel.org/linux-arm-msm/aU6XXi2HmgjZY8CY@SoMainline.org/ And I'd argue that DRM/MSM has seen a lot of breakage especially around the DSC and dual-DSI paths that my panels/devices rely on [2], turning a simple rebase-and-test in a multi-evening debug session. [2]: https://lore.kernel.org/linux-arm-msm/?q=f%3Amarijn+fixes+dsc > I am officially a fan of these drivers and I liked the work done so far > a lot, is there something in particular stalling these from rebasing > and merging? And there have been many small comments left and right - including my own observations and self-review - that all need to get addressed. Not a lot of work, but they add up and it's easy enough to miss something which will make a reviewer "unhappy" ;) Coincidentally I submitted 10 of the 14 Sony devices to postmarketOS just last week, specifically as an extra motivator to show the world that we can truly run all these devices with completely functional panels straight from mainline. I'll definitely be submitting a (rebased) v3 to drive that, but it might take a little more time. - Marijn