From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 809FDC982FA for ; Tue, 22 Sep 2026 09:52:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9EC7810E66A; Tue, 22 Sep 2026 09:52:51 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=riscstar-com.20251104.gappssmtp.com header.i=@riscstar-com.20251104.gappssmtp.com header.b="uSqmGk3t"; dkim-atps=neutral Received: from mail-wm2-f13.google.com (mail-wm2-f13.google.com [74.125.225.141]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8B72810E68A for ; Tue, 22 Sep 2026 09:52:49 +0000 (UTC) Received: by mail-wm2-f13.google.com with SMTP id 5b1f17b1804b1-49ccfd61ecaso34270775e9.3 for ; Tue, 22 Sep 2026 02:52:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=riscstar-com.20251104.gappssmtp.com; s=20251104; t=1790070768; x=1790675568; darn=lists.freedesktop.org; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to:content-type; bh=QYbygSoXTPt7jaWPgoihIOPAkjKBdxHc4l1yrHc4AGQ=; b=uSqmGk3t/jofgbo9QMR9O7qrsOf6ak67ZVONB/pseJeDtf+ifoI0Ayl836kloOhfko JUmzFEJzGd1GOyeJl5zwEl1gpGFnm11pM2XCT6vK7wd6I5iHqAzqf+S42MsxDOYZ6U7l 9A7dArVBToBLVvMPbqsxThCeApzbLUb8I7gdHvqdS5eBxjlTIko1sHbQn8ZPeVYeGWCf utTMeIV6GUgGBZBQSkCtAQBK0jQ1+b0D0/Nx9KxmIfWOs3M1Fc6eny8SDdydLk7fCFEf 5sF90dk4xf0BIUHUwcdsXyCEjEW5z/pHDD3KkAIfJTptiOTUzUYhG2ZkOd+TXWjdNV/S Pacg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790070768; x=1790675568; h=in-reply-to:content-transfer-encoding:content-disposition :content-type:mime-version:references:message-id:subject:cc:to:from :date:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to:content-type; bh=QYbygSoXTPt7jaWPgoihIOPAkjKBdxHc4l1yrHc4AGQ=; b=ldl5By4fvip2Mixj1zBY9GotiCuyDT9zjKUpBDvzxvb6TCEAJAjOyladw3xVw+BLXn bsLYslG64cAI6pMR7G0xgCKVKPIlVqDX0hU0/FM801m88xcGD615iOenXkipHRUPvLgE m+Y538Go5ujdeDBXACkcVCDPvxVEnZ8+8Ove7w3J/F5CtI1ZV4WMFaE337hNkDBJEFY1 KLf3XduAdgQQacU3G1FyK0yKW7fPHTq4lKbBqEHh56EuGe1jzLzDYwvCg213R2cGdLYd 3rJYGsBsYrV4nJLOr5ATdJclrpuEiNISAMNEAUklnOhMu2P7kYzYFmXcsS7NfJveIpD0 BbgA== X-Forwarded-Encrypted: i=1; AKwUvBykSN1Eor4Xn8q4Cat2zGWb5p76TBXKleCYTY2cnI38wB3JQcuI3HKU4GnVUOzft7na1pBQ+uWmDn8=@lists.freedesktop.org X-Gm-Message-State: AFuF++kjT6Bvg9ppiBfdZ3Pr7LmdHvFgX1NAMuTtQ598V1vzbhY4j2Uh uL0GpbPLqUmpGtTZR37dIYN/bDF9zwPVbAae4h0M7/FWHKzProdA1d19OuvBKt7MoLs= X-Gm-Gg: AYBFou0QFTX42S3V1JJK5BO3B/zNjqPFnabRsGty70Sel0e8BCmlKRy72HSaqC15mNO 2U5RQl7fpbc1gyouL032Eg6RpHy0HUnEESWQfhsWp4JGebRa4rcorOFjovXCOCOJ+iBsyfP57a6 aKFASCuJhj/WbUmTBkhLxnzpf52imzFjItiklCuo7KVLRV+StiinHjNb9KDqSYAfOSLqzZ4neis DNpNGnRU60KPLSTsHLiAs/BpdQYlno4kS/Vzp6S0kEOFA+nuZoqYV6Fz8U0u3PoSZ36a54k8zXc pgah4qdkzEdSpOWFdsDPAlV3EJ8ITAQkHZ/yU6CrTDi9VtJo/YIz3c2rrTnpHcZqK5/qKFvcV2q yK23tjR+yeaaxD4NzwL9l5SPrC2mqmhIzAkXGF6NYGbYJmtl3rczFDdaGVdVBTHG3fAFXTpUpEb i3rx9hhtR5ZTdyJxDI07DUwpXtsW8H5uLWvx/YjQVW54wQhY72usxshYewAqxrAE8rl5pZKwMPV 5wPipLVuMo+BDRLYelZlOrYDdI8yzuRpaE7FSORvDFyz/e5sMvC5Wy8Nd+tLPBjsgli7Oj//mM5 XXXRj7k1DpVRZQmCSFt5uB4H6p4TLIMFSclRbcZDoxygNlbFY08X5S7YQ4s= X-Received: by 2002:a05:600c:46cf:b0:49c:de80:b833 with SMTP id 5b1f17b1804b1-49fc5687b6cmr202804085e9.2.1790070767607; Tue, 22 Sep 2026 02:52:47 -0700 (PDT) Received: from aspen.lan (aztw-33-b2-v4wan-169864-cust3247.vm26.cable.virginm.net. [92.239.204.176]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49fdaa9dbd6sm42235115e9.2.2026.09.22.02.52.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2026 02:52:46 -0700 (PDT) Date: Tue, 22 Sep 2026 10:52:44 +0100 From: Daniel Thompson To: kavakliyigitcan@gmail.com Cc: Lee Jones , Daniel Thompson , Jingoo Han , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Helge Deller , Liam Girdwood , Mark Brown , Sumit Semwal , Neil Armstrong , Jessica Zhang , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Dmitry Torokhov , Henrik Rydberg , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Sean Paul , Marijn Suijten , Bjorn Andersson , Konrad Dybcio , dri-devel@lists.freedesktop.org, linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org, linux-input@vger.kernel.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH RFC 02/10] backlight: add Kinetic KTD3136 driver Message-ID: References: <20260911-ginkgo-submission-final-v1-0-0e68e63a18d4@gmail.com> <20260911-ginkgo-submission-final-v1-2-0e68e63a18d4@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20260911-ginkgo-submission-final-v1-2-0e68e63a18d4@gmail.com> X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Sep 11, 2026 at 11:50:59AM +0300, YİĞİTCAN KAVAKLI via B4 Relay wrote: > obj-$(CONFIG_BACKLIGHT_LM3630A) += lm3630a_bl.o > diff --git a/drivers/video/backlight/ktd3136-backlight.c b/drivers/video/backlight/ktd3136-backlight.c > new file mode 100644 > index 0000000000000000000000000000000000000000..a8ebe3b23c99f3ada9f45c60688f8b8c78d72def > --- /dev/null > +++ b/drivers/video/backlight/ktd3136-backlight.c > @@ -0,0 +1,262 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Kinetic Technologies KTD3136 3-Channel LED Backlight Driver > + * > + * Copyright (C) 2026 > + */ > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#define KTD3136_REG_DEV_ID 0x00 > +#define KTD3136_REG_SW_RESET 0x01 > +#define KTD3136_REG_MODE 0x02 > +#define KTD3136_REG_CONTROL 0x03 > +#define KTD3136_REG_RATIO_LSB 0x04 > +#define KTD3136_REG_RATIO_MSB 0x05 > +#define KTD3136_REG_PWM 0x06 > +#define KTD3136_REG_STATUS 0x0A > + > +#define KTD3136_DEV_ID_VAL 0x18 > +#define KTD3136_DEV_ID_VAL2 0x19 > + > +#define KTD3136_MODE_ON 0xC9 /* Boost ON, 3 channels enabled */ > +#define KTD3136_MODE_STANDBY 0x98 /* Standby mode */ > +#define KTD3136_CONTROL_LINEAR 0x02 /* Linear dimming mapping */ > +#define KTD3136_PWM_DEFAULT 0x1B /* Default PWM/boost frequency */ > + > +#define KTD3136_DEFAULT_MAX_BRIGHTNESS 2047 /* 11-bit resolution */ > +#define KTD3136_DEFAULT_BRIGHTNESS 2047 > + > +struct ktd3136_data { > + struct i2c_client *client; > + struct backlight_device *bd; > + struct gpio_desc *enable_gpio; > + struct regulator *vin; > + /* Protects chip registers and state */ > + struct mutex lock; > + bool is_enabled; > +}; > + > +static int ktd3136_write(struct ktd3136_data *chip, u8 reg, u8 val) > +{ > + int ret; > + > + ret = i2c_smbus_write_byte_data(chip->client, reg, val); > + if (ret < 0) > + dev_err(&chip->client->dev, "failed to write reg 0x%02x: %d\n", reg, ret); > + > + return ret; > +} > + > +static int ktd3136_read(struct ktd3136_data *chip, u8 reg) > +{ > + int ret; > + > + ret = i2c_smbus_read_byte_data(chip->client, reg); > + if (ret < 0) > + dev_err(&chip->client->dev, "failed to read reg 0x%02x: %d\n", reg, ret); > + > + return ret; > +} > + > +static int ktd3136_power_on(struct ktd3136_data *chip) > +{ > + int ret; > + > + if (chip->is_enabled) > + return 0; > + > + if (chip->enable_gpio) { > + gpiod_set_value_cansleep(chip->enable_gpio, 1); > + /* Allow oscillator and internal logic to stabilize */ > + usleep_range(2000, 3000); > + } > + > + ret = ktd3136_write(chip, KTD3136_REG_CONTROL, KTD3136_CONTROL_LINEAR); > + if (ret < 0) > + goto err_off; > + > + ret = ktd3136_write(chip, KTD3136_REG_PWM, KTD3136_PWM_DEFAULT); > + if (ret < 0) > + goto err_off; > + > + chip->is_enabled = true; > + return 0; > + > +err_off: > + if (chip->enable_gpio) > + gpiod_set_value_cansleep(chip->enable_gpio, 0); > + return ret; > +} > + > +static void ktd3136_power_off(struct ktd3136_data *chip) > +{ > + if (!chip->is_enabled) > + return; > + > + ktd3136_write(chip, KTD3136_REG_MODE, KTD3136_MODE_STANDBY); > + > + if (chip->enable_gpio) > + gpiod_set_value_cansleep(chip->enable_gpio, 0); Why does this powering off leave the regulator active? > + > + chip->is_enabled = false; > +} > + > +static int ktd3136_update_status(struct backlight_device *bd) > +{ > + struct ktd3136_data *chip = bl_get_data(bd); > + int brightness = backlight_get_brightness(bd); > + int ret = 0; > + u8 lsb, msb; > + > + mutex_lock(&chip->lock); > + > + if (backlight_is_blank(bd) || brightness == 0) { > + ktd3136_power_off(chip); > + goto out; > + } > + > + ret = ktd3136_power_on(chip); > + if (ret < 0) > + goto out; > + > + lsb = brightness & 0x07; > + msb = (brightness >> 3) & 0xFF; > + > + ret = ktd3136_write(chip, KTD3136_REG_RATIO_LSB, lsb); > + if (ret < 0) > + goto out; > + > + ret = ktd3136_write(chip, KTD3136_REG_RATIO_MSB, msb); > + if (ret < 0) > + goto out; > + > + ret = ktd3136_write(chip, KTD3136_REG_MODE, KTD3136_MODE_ON); > + > +out: > + mutex_unlock(&chip->lock); > + return ret; > +} > + > +static const struct backlight_ops ktd3136_backlight_ops = { > + .options = BL_CORE_SUSPENDRESUME, > + .update_status = ktd3136_update_status, > +}; > + > +static int ktd3136_probe(struct i2c_client *client) > +{ > + struct device *dev = &client->dev; > + struct backlight_properties props; > + struct ktd3136_data *chip; > + int ret, val; > + u32 def_brightness = KTD3136_DEFAULT_BRIGHTNESS; > + u32 max_brightness = KTD3136_DEFAULT_MAX_BRIGHTNESS; > + > + chip = devm_kzalloc(dev, sizeof(*chip), GFP_KERNEL); > + if (!chip) > + return -ENOMEM; > + > + chip->client = client; > + mutex_init(&chip->lock); > + > + chip->vin = devm_regulator_get_optional(dev, "vin"); > + if (IS_ERR(chip->vin)) { > + ret = PTR_ERR(chip->vin); > + if (ret != -ENODEV) > + return dev_err_probe(dev, ret, "Failed to get vin regulator\n"); > + chip->vin = NULL; > + } > + > + if (chip->vin) { > + ret = regulator_enable(chip->vin); > + if (ret) > + return dev_err_probe(dev, ret, "Failed to enable vin regulator\n"); > + } Why is the regulator managed here rather than in the power_on/off functions? Also, you need to keep track of the regulator state. You must "put" the regulator before allowing devm to clean it up (handling the regulator state in power_on/off would solve this). > + > + chip->enable_gpio = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_HIGH); > + if (IS_ERR(chip->enable_gpio)) > + return dev_err_probe(dev, PTR_ERR(chip->enable_gpio), > + "Failed to get enable GPIO\n"); > + > + if (chip->enable_gpio) > + usleep_range(2000, 3000); > + > + val = ktd3136_read(chip, KTD3136_REG_DEV_ID); > + if (val < 0) > + return dev_err_probe(dev, val, "Failed to read device ID\n"); > + > + if (val != KTD3136_DEV_ID_VAL && val != KTD3136_DEV_ID_VAL2) { > + dev_err(dev, "Unknown device ID: 0x%02x\n", val); > + return -ENODEV; > + } > + > + dev_info(dev, "Kinetic KTD3136 detected (ID: 0x%02x)\n", val); Remove this. Happy noises are still noise! > + > + device_property_read_u32(dev, "max-brightness", &max_brightness); > + if (max_brightness > KTD3136_DEFAULT_MAX_BRIGHTNESS) > + max_brightness = KTD3136_DEFAULT_MAX_BRIGHTNESS; > + > + device_property_read_u32(dev, "default-brightness", &def_brightness); > + if (def_brightness > max_brightness) > + def_brightness = max_brightness; > + > + memset(&props, 0, sizeof(props)); > + props.type = BACKLIGHT_RAW; > + props.max_brightness = max_brightness; > + props.brightness = def_brightness; The scale property needs to be set here. Daniel.