dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <error27@gmail.com>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: dri-devel@lists.freedesktop.org
Subject: [bug report] drm/display: hdmi: Add HDMI 2.0 scrambling management helpers
Date: Tue, 22 Sep 2026 14:39:24 +0300	[thread overview]
Message-ID: <arJo7A7L5hud3tyc@stanley.mountain> (raw)

Hello Cristian Ciocaltea,

Commit d653818324ed ("drm/display: hdmi: Add HDMI 2.0 scrambling
management helpers") from Sep 1, 2026, leads to the following Smatch
complaint:

    drivers/gpu/drm/display/drm_hdmi_helper.c:663 drm_connector_hdmi_sync_scdc()
    warn: variable dereferenced before check 'connector' (see line 657)

drivers/gpu/drm/display/drm_hdmi_helper.c
   656		struct drm_connector_hdmi *hdmi = &connector->hdmi;
   657		struct drm_device *dev = connector->dev;
                                         ^^^^^^^^^^^^^^
Dereference.

   658		struct drm_connector_state *conn_state;
   659		struct drm_crtc *crtc;
   660		u8 config;
   661		int ret;
   662	
   663		if (!connector || !plugged || !ctx)
                     ^^^^^^^^^
Checked too late.

   664			return 0;
   665	

This email is a free service from the Smatch-CI project [smatch.sf.net].

regards,
dan carpenter

             reply	other threads:[~2026-09-22 11:39 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-22 11:39 Dan Carpenter [this message]
2026-10-01 22:38 ` [bug report] drm/display: hdmi: Add HDMI 2.0 scrambling management helpers Cristian Ciocaltea

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=arJo7A7L5hud3tyc@stanley.mountain \
    --to=error27@gmail.com \
    --cc=cristian.ciocaltea@collabora.com \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox