dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org,
	Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>,
	Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v4 20/20] drm/rcar-du: Allow VSP and writeback build with COMPILE_TEST=y
Date: Thu, 19 Nov 2026 00:32:15 +0200	[thread overview]
Message-ID: <av4nb98f3ewe2rV3@intel.com> (raw)
In-Reply-To: <20261118221114.GI1923307@killaraus.ideasonboard.com>

On Thu, Nov 19, 2026 at 12:11:14AM +0200, Laurent Pinchart wrote:
> On Wed, Nov 18, 2026 at 11:45:17PM +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > 
> > Make DRM_RCAR_VSP selectable with COMPILE_TEST=y, and enable the hidden
> > DRM_RCAR_WRITEBACK option by default, so the VSP and writeback code gets
> > built for greater coverage. Builds fine on x86, x86_64, arm and arm64 at
> > least.
> 
> Let's see what build bots will report on more exotic architectures. I
> may volunteer you to send a fix if I'm too busy when the builders start
> yelling :-)
> 
> > Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > Cc: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
> > Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Magnus Damm <magnus.damm@gmail.com>
> > Cc: linux-renesas-soc@vger.kernel.org
> > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > ---
> >  drivers/gpu/drm/renesas/rcar-du/Kconfig | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/renesas/rcar-du/Kconfig b/drivers/gpu/drm/renesas/rcar-du/Kconfig
> > index 80bd770ae0f6..5394f131c58f 100644
> > --- a/drivers/gpu/drm/renesas/rcar-du/Kconfig
> > +++ b/drivers/gpu/drm/renesas/rcar-du/Kconfig
> > @@ -76,7 +76,7 @@ config DRM_RCAR_MIPI_DSI
> >  	select RESET_CONTROLLER
> >  
> >  config DRM_RCAR_VSP
> > -	bool "R-Car DU VSP Compositor Support" if ARM
> > +	bool "R-Car DU VSP Compositor Support" if ARM || COMPILE_TEST
> 
> This will make it possible to disable the option when ARM64 &&
> COMPILE_TEST, which will break operation on Gen3 and up. It would be
> best to avoid that.

Break operation, as in when running on real hardware?
People actually do that with COMPILE_TEST=y kernels?

> 
> >  	default y if ARM64
> >  	depends on DRM_RCAR_DU
> >  	depends on VIDEO_RENESAS_VSP1=y || (VIDEO_RENESAS_VSP1 && DRM_RCAR_DU=m)
> > @@ -85,5 +85,5 @@ config DRM_RCAR_VSP
> >  
> >  config DRM_RCAR_WRITEBACK
> >  	bool
> > -	default y if ARM64
> > +	default y if ARM64 || COMPILE_TEST
> >  	depends on DRM_RCAR_DU
> 
> -- 
> Regards,
> 
> Laurent Pinchart

-- 
Ville Syrjälä
Intel

  reply	other threads:[~2026-11-18 22:32 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-18 21:44 [PATCH v4 00/20] drm: Increase COMPILE_TEST=y coverage Ville Syrjala
2026-11-18 21:44 ` [PATCH v4 01/20] drm/tilcdc: Allow build without __iowmb() Ville Syrjala
2026-11-18 21:44 ` [PATCH v4 02/20] drm/tilcdc: Drop volatile from the mmio pointer in tilcdc_write64() Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 03/20] drm/tilcdc: Use __le64 for the fallback 64bit write Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 04/20] drm/tilcdc: Fix endpoint node names in the legacy panel overlay Ville Syrjala
2026-11-19  9:32   ` Kory Maincent
2026-11-18 21:45 ` [PATCH v4 05/20] drm/tilcdc: Allow build with COMPILE_TEST=y Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 06/20] drm/armada: Fix printk arguments Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 07/20] drm/armada: Fix armada_debugfs_crtc_reg_write() return type Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 08/20] drm/armada: Fix sparse __iomem address space warnings Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 09/20] drm/armada: Allow build with COMPILE_TEST=y Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 10/20] drm/fsl-dcu: " Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 11/20] drm/adp: Include linux/bitfield.h Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 12/20] drm/adp: Allow build with COMPILE_TEST=y Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 13/20] drm/imagination: Include io-64-nonatomic-lo-hi.h Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 14/20] drm/imagination: Use rcu_access_pointer() for dma_fence::ops Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 15/20] drm/imagination: Allow build with COMPILE_TEST=y Ville Syrjala
2026-11-18 21:58   ` sashiko-bot
2026-11-18 22:30     ` Ville Syrjälä
2026-11-18 21:45 ` [PATCH v4 16/20] drm/imagination: Drop stale kernel-doc for pvr_mmu_backing_page.pvr_dev Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 17/20] drm/imagination: Fix kernel-doc for pvr_mmu_op_context anonymous structs Ville Syrjala
2026-11-18 21:45 ` [PATCH v4 18/20] drm/ingenic: Allow ingenic-dw-hdmi build with COMPILE_TEST=y Ville Syrjala
2026-11-19  9:31   ` Paul Cercueil
2026-11-18 21:45 ` [PATCH v4 19/20] drm/nouveau: Allow platform driver " Ville Syrjala
2026-11-18 21:57   ` sashiko-bot
2026-11-18 22:28     ` Ville Syrjälä
2026-11-18 21:45 ` [PATCH v4 20/20] drm/rcar-du: Allow VSP and writeback " Ville Syrjala
2026-11-18 22:11   ` Laurent Pinchart
2026-11-18 22:32     ` Ville Syrjälä [this message]
2026-11-18 22:39       ` Laurent Pinchart
2026-11-18 22:57         ` Ville Syrjälä
2026-11-18 23:14           ` Laurent Pinchart
2026-11-19  7:38           ` Geert Uytterhoeven
2026-11-19  8:16             ` Laurent Pinchart
2026-11-19  8:23               ` Geert Uytterhoeven
2026-11-19  7:33   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=av4nb98f3ewe2rV3@intel.com \
    --to=ville.syrjala@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=geert+renesas@glider.be \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=tomi.valkeinen+renesas@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox