Re: [PATCH v14 01/15] dt-bindings: mediatek,dpi: Add DP_INTF compatible

[CK Hu <ck.hu@mediatek.com>]

On Mon, 2022-06-27 at 17:07 +0800, Rex-BC Chen wrote:
> On Mon, 2022-06-27 at 15:50 +0800, CK Hu wrote:
> > Hi, Bo-Chen:
> > 
> > On Fri, 2022-06-24 at 11:09 +0800, Bo-Chen Chen wrote:
> > > From: Markus Schneider-Pargmann <msp@baylibre.com>
> > > 
> > > DP_INTF is similar to DPI but does not have the exact same
> > > feature
> > > set
> > > or register layouts.
> > > 
> > > DP_INTF is the sink of the display pipeline that is connected to
> > > the
> > > DisplayPort controller and encoder unit. It takes the same clocks
> > > as
> > > DPI.
> > > 
> > > Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>
> > > Signed-off-by: Guillaume Ranquet <granquet@baylibre.com>
> > > [Bo-Chen: Modify reviewers' comments.]
> > 
> > Except this line,
> > 
> > Reviewed-by: CK Hu <ck.hu@mediatek.com>
> > 
> 
> Hello CK,
> 
> What do you mean?
> Do you mean I should drop this line?

Yes, drop this line. I think every patch is reviewed and modified, so
this line is redundant.

Regards,
CK

> 
> BRs,
> Bo-Chen
> > > Signed-off-by: Bo-Chen Chen <rex-bc.chen@mediatek.com>
> > > Reviewed-by: AngeloGioacchino Del Regno <
> > > angelogioacchino.delregno@collabora.com>
> > > ---
> > >  .../bindings/display/mediatek/mediatek,dpi.yaml       | 11
> > > ++++++-
> > > --
> > > --
> > >  1 file changed, 6 insertions(+), 5 deletions(-)
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > index 77ee1b923991..8e526a4b134e 100644
> > > ---
> > > a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi
> > > .y
> > > am
> > > l
> > > @@ -4,16 +4,16 @@
> > >  $id: 
> > > http://devicetree.org/schemas/display/mediatek/mediatek,dpi.yaml#
> > >  $schema: http://devicetree.org/meta-schemas/core.yaml#
> > >  
> > > -title: mediatek DPI Controller Device Tree Bindings
> > > +title: mediatek DPI and DP_INTF Controller
> > >  
> > >  maintainers:
> > >    - CK Hu <ck.hu@mediatek.com>
> > >    - Jitao shi <jitao.shi@mediatek.com>
> > >  
> > >  description: |
> > > -  The Mediatek DPI function block is a sink of the display
> > > subsystem
> > > and
> > > -  provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422 pixel data on
> > > a
> > > parallel
> > > -  output bus.
> > > +  The Mediatek DPI and DP_INTF function blocks are a sink of the
> > > display
> > > +  subsystem and provides 8-bit RGB/YUV444 or 8/10/10-bit YUV422
> > > pixel data on a
> > > +  parallel output bus.
> > >  
> > >  properties:
> > >    compatible:
> > > @@ -24,6 +24,7 @@ properties:
> > >        - mediatek,mt8183-dpi
> > >        - mediatek,mt8186-dpi
> > >        - mediatek,mt8192-dpi
> > > +      - mediatek,mt8195-dp-intf
> > >  
> > >    reg:
> > >      maxItems: 1
> > > @@ -55,7 +56,7 @@ properties:
> > >      $ref: /schemas/graph.yaml#/properties/port
> > >      description:
> > >        Output port node. This port should be connected to the
> > > input
> > > port of an
> > > -      attached HDMI or LVDS encoder chip.
> > > +      attached HDMI, LVDS or DisplayPort encoder chip.
> > >  
> > >  required:
> > >    - compatible
> > 
> > 
> 
>