From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 737C7C5475B for ; Fri, 1 Mar 2024 22:30:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 82E6310ED41; Fri, 1 Mar 2024 22:30:22 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (1024-bit key; unprotected) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="IB6EwWyo"; dkim-atps=neutral Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by gabe.freedesktop.org (Postfix) with ESMTPS id 27A9810ED40 for ; Fri, 1 Mar 2024 22:30:19 +0000 (UTC) Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-7c495be1924so11760939f.1 for ; Fri, 01 Mar 2024 14:30:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1709332219; x=1709937019; darn=lists.freedesktop.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=T8x2mxeFdohQWYY3zMglPyZFTN/Kq6RqRSv1UGmerBI=; b=IB6EwWyohonKUDO6HnRbMuaIcezb2W9p4lAf9va9+vcuIi69Ch3mwHJFf1z110y9hJ gttUWcr4YEio+2PAARkJnk17ZBsF7Z0OK6O0oMjmYFe0VcAQjgsxSXuvtb/8KW9QLA3K r5t0HmzccIU67rE7jJG4Oo34ilUmKpAjZFhKM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709332219; x=1709937019; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=T8x2mxeFdohQWYY3zMglPyZFTN/Kq6RqRSv1UGmerBI=; b=QjLVyiCa/P03h7fyTL09+YdXFoRIi3HE38WEKAvoY0QrobnmnUaSuODfB0TY+uYZaT 3jUphGzjgkU3gHs/pp/D987NcPMGnVTEhJcaaQqC+qtFgcKcbr7yQEhJE3zabKupNoQA yPbhOLRZZcylrMO2RiEu7gxrCucoJiyam8Jr78x9sTnOdasxNHGzzSDWWclm4kbzwGYY BUZWqWzUZs0UsUsadHqhXisZV0MNOnfyExYvOxbRbgd8g9Q3x5Y3K7LSfV0A6Q8+zmvh EsmJtpanRiAmP0o4nIVdd7I1zt2Z0Q+plN2pq11pRcGJvu8oG5W3FG3kG3GuHvVSj4Xg F8+w== X-Forwarded-Encrypted: i=1; AJvYcCUTUuIRnENRETYpNHfb1iajM7VzdX/2ctIVj6mPRhSuH0RreRppagO0/0PDpiKelSTD2toXietaauYqdbzuVqrz3qFReHeYCIHNoKanZO2Z X-Gm-Message-State: AOJu0YzZSFykNDvCJVuiAUJAM2HxUgn8qsaRo4W/w3yj1FDI8c2uu2lQ ICKL47rpirwZmeVwk2UkB3nQWQhefNccddoTCOdWsa1lEkS7VEv9A0oDM4UNG2k= X-Google-Smtp-Source: AGHT+IHgWkGCfWnHsje4/UxTkcI+GY6iZPTcibjb9fiZXNTMC/s9IGJS4fzp6cW5nIoplalJJpzPjA== X-Received: by 2002:a6b:6615:0:b0:7c8:1ede:72ea with SMTP id a21-20020a6b6615000000b007c81ede72eamr3027448ioc.0.1709332218959; Fri, 01 Mar 2024 14:30:18 -0800 (PST) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id x4-20020a029704000000b004747cb8b342sm1006814jai.15.2024.03.01.14.30.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Mar 2024 14:30:18 -0800 (PST) Message-ID: Date: Fri, 1 Mar 2024 15:30:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: linux-next: build failure after merge of the kunit-next tree Content-Language: en-US To: Stephen Rothwell , David Gow Cc: Brendan Higgins , Daniel Vetter , Intel Graphics , DRI , =?UTF-8?Q?Christian_K=C3=B6nig?= , Matthew Auld , Linux Kernel Mailing List , Linux Next Mailing List , Dave Airlie , Shuah Khan References: <20240229152653.09ecf771@canb.auug.org.au> <20240301214358.7fdecd66@canb.auug.org.au> <86d87830-100f-4f29-bb7f-9a612b90866a@linuxfoundation.org> <20240302074643.6e1086ff@canb.auug.org.au> From: Shuah Khan In-Reply-To: <20240302074643.6e1086ff@canb.auug.org.au> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Stephen, On 3/1/24 13:46, Stephen Rothwell wrote: > Hi Shuah, > > On Fri, 1 Mar 2024 09:05:57 -0700 Shuah Khan wrote: >> >> On 3/1/24 03:43, Stephen Rothwell wrote: >>> Hi all, >>> >>> On Fri, 1 Mar 2024 15:15:02 +0800 David Gow wrote: >>>> >>>> On Thu, 29 Feb 2024 at 23:07, Shuah Khan wrote: >>>>> >>>>> I can carry the fix through kselftest kunit if it works >>>>> for all. >>>> >>>> I'm happy for this to go in with the KUnit changes if that's the best >>>> way to keep all of the printk formatting fixes together. > > Unfortunately you can't fix this in the kunit-next tree without pulling > in Linus' tree (or the drm-fixes tree) - which seems excessive. > >>> I am pretty sure that the proper fix has been applied to the >>> drm-fixes tree today (in the merge of the drm-misc-fixes tree). >>> >> >> What's the commit id for this fix? I Would like to include the details >> in my pull request to Linus. > > My mistake, I misread the merge commit. It has not been fixed in the > drm-misc-fixes tree or the drm-fixes tree (or Linus' tree since the > drm-fixes tree has been merged there) :-( > > The problem in this case is not with the format string types, but with > a missing argument i.e. there is another argument required by the > format string. It really should be fixed in the drm-misc-fixes tree > and sent to Linus post haste. > > At least the change in the kunit-next tree will stop this happening in > the future. > Thank you for looking into it. David, please send a fix in as you suggested earlier. I will apply it to avoid compile errors. thanks, -- Shuah