From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Foss Subject: Re: [PATCH libdrm 02/10] xf86drm: introduce drm_device_has_rdev() helper Date: Thu, 28 Jun 2018 12:14:01 +0200 Message-ID: References: <20180625173626.8046-1-emil.l.velikov@gmail.com> <20180625173626.8046-2-emil.l.velikov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 816E86ECB8 for ; Thu, 28 Jun 2018 10:14:05 +0000 (UTC) In-Reply-To: <20180625173626.8046-2-emil.l.velikov@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Emil Velikov , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org RmVlbCBmcmVlIHRvIGFkZCBteSByLWIgdG8gdGhpcyBwYXRjaC4KCk9uIDIwMTgtMDYtMjUgMTk6 MzYsIEVtaWwgVmVsaWtvdiB3cm90ZToKPiBGcm9tOiBFbWlsIFZlbGlrb3YgPGVtaWwudmVsaWtv dkBjb2xsYWJvcmEuY29tPgo+IAo+IEN1cnJlbnRseSB3ZSBtYXRjaCB0aGUgb3BlbmVkIGRybURl dmljZSBmZCB3aXRoIGVhY2ggZHJtRGV2aWNlIHdlCj4gcHJvY2Vzcy4KPiAKPiBNb3ZlIHRoYXQg YWZ0ZXIgYWxsIHRoZSBkZXZpY2VzIGFyZSBwcm9jZXNzZWQgYW5kIGZvbGRlZCwgdmlhIHRoZQo+ IGRybV9kZXZpY2VfaGFzX3JkZXYoKS4gVGhpcyBtYWtlcyB0aGUgY29kZSBlYXNpZXIgdG8gZm9s bG93IGFuZCBhbGxvd3MKPiB1cyB0byB1bmlmeSB0aGUgbWFzc2l2ZSBwcm9jZXNzIGxvb3AgYWNy b3NzIGRybUdldERldmljZTIgYW5kCj4gZHJtR2V0RGV2aWNlczIuIFRoYXQgaW4gaXRzZWxmIGlz IGNvbWluZyB3aXRoIGEgbGF0ZXIgY29tbWl0Lgo+IAo+IFNpZ25lZC1vZmYtYnk6IEVtaWwgVmVs aWtvdiA8ZW1pbC52ZWxpa292QGNvbGxhYm9yYS5jb20+Cj4gLS0tCj4gICB4Zjg2ZHJtLmMgfCAz NCArKysrKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwg MjUgaW5zZXJ0aW9ucygrKSwgOSBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGY4NmRy bS5jIGIveGY4NmRybS5jCj4gaW5kZXggZTFiYmJlOTkuLmNiYzBhNDA4IDEwMDY0NAo+IC0tLSBh L3hmODZkcm0uYwo+ICsrKyBiL3hmODZkcm0uYwo+IEBAIC0zNzA1LDYgKzM3MDUsMjEgQEAgZHJt X2RldmljZV92YWxpZGF0ZV9mbGFncyh1aW50MzJfdCBmbGFncykKPiAgICAgICAgICAgcmV0dXJu IChmbGFncyAmIH5EUk1fREVWSUNFX0dFVF9QQ0lfUkVWSVNJT04pOwo+ICAgfQo+ICAgCj4gK3N0 YXRpYyBib29sCj4gK2RybV9kZXZpY2VfaGFzX3JkZXYoZHJtRGV2aWNlUHRyIGRldmljZSwgZGV2 X3QgZmluZF9yZGV2KQo+ICt7Cj4gKyAgICBzdHJ1Y3Qgc3RhdCBzYnVmOwo+ICsKPiArICAgIGZv ciAoaW50IGkgPSAwOyBpIDwgRFJNX05PREVfTUFYOyBpKyspIHsKPiArICAgICAgICBpZiAoZGV2 aWNlLT5hdmFpbGFibGVfbm9kZXMgJiAxIDw8IGkpIHsKPiArICAgICAgICAgICAgaWYgKHN0YXQo ZGV2aWNlLT5ub2Rlc1tpXSwgJnNidWYpID09IDAgJiYKPiArICAgICAgICAgICAgICAgIHNidWYu c3RfcmRldiA9PSBmaW5kX3JkZXYpCj4gKyAgICAgICAgICAgICAgICByZXR1cm4gdHJ1ZTsKPiAr ICAgICAgICB9Cj4gKyAgICB9Cj4gKyAgICByZXR1cm4gZmFsc2U7Cj4gK30KPiArCj4gICAvKioK PiAgICAqIEdldCBpbmZvcm1hdGlvbiBhYm91dCB0aGUgb3BlbmVkIGRybSBkZXZpY2UKPiAgICAq Cj4gQEAgLTM4ODksMjEgKzM5MDQsMjIgQEAgaW50IGRybUdldERldmljZTIoaW50IGZkLCB1aW50 MzJfdCBmbGFncywgZHJtRGV2aWNlUHRyICpkZXZpY2UpCj4gICAgICAgICAgICAgICBsb2NhbF9k ZXZpY2VzID0gdGVtcDsKPiAgICAgICAgICAgfQo+ICAgCj4gLSAgICAgICAgLyogc3RvcmUgdGFy Z2V0IGF0IGxvY2FsX2RldmljZXNbMF0gZm9yIGVhc2UgdG8gdXNlIGJlbG93ICovCj4gLSAgICAg ICAgaWYgKGZpbmRfcmRldiA9PSBzYnVmLnN0X3JkZXYgJiYgaSkgewo+IC0gICAgICAgICAgICBs b2NhbF9kZXZpY2VzW2ldID0gbG9jYWxfZGV2aWNlc1swXTsKPiAtICAgICAgICAgICAgbG9jYWxf ZGV2aWNlc1swXSA9IGQ7Cj4gLSAgICAgICAgfQo+IC0gICAgICAgIGVsc2UKPiAtICAgICAgICAg ICAgbG9jYWxfZGV2aWNlc1tpXSA9IGQ7Cj4gKyAgICAgICAgbG9jYWxfZGV2aWNlc1tpXSA9IGQ7 Cj4gICAgICAgICAgIGkrKzsKPiAgICAgICB9Cj4gICAgICAgbm9kZV9jb3VudCA9IGk7Cj4gICAK PiAgICAgICBkcm1Gb2xkRHVwbGljYXRlZERldmljZXMobG9jYWxfZGV2aWNlcywgbm9kZV9jb3Vu dCk7Cj4gICAKPiAtICAgICpkZXZpY2UgPSBsb2NhbF9kZXZpY2VzWzBdOwo+IC0gICAgZHJtRnJl ZURldmljZXMoJmxvY2FsX2RldmljZXNbMV0sIG5vZGVfY291bnQgLSAxKTsKPiArICAgIGZvciAo aSA9IDA7IGkgPCBub2RlX2NvdW50OyBpKyspIHsKPiArICAgICAgICBpZiAoIWxvY2FsX2Rldmlj ZXNbaV0pCj4gKyAgICAgICAgICAgIGNvbnRpbnVlOwo+ICsKPiArICAgICAgICBpZiAoZHJtX2Rl dmljZV9oYXNfcmRldihsb2NhbF9kZXZpY2VzW2ldLCBmaW5kX3JkZXYpKQo+ICsgICAgICAgICAg ICAqZGV2aWNlID0gbG9jYWxfZGV2aWNlc1tpXTsKPiArICAgICAgICBlbHNlCj4gKyAgICAgICAg ICAgIGRybUZyZWVEZXZpY2UoJmxvY2FsX2RldmljZXNbaV0pOwo+ICsgICAgfQo+ICAgCj4gICAg ICAgY2xvc2VkaXIoc3lzZGlyKTsKPiAgICAgICBmcmVlKGxvY2FsX2RldmljZXMpOwo+IApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK