From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework Date: Thu, 7 Nov 2019 21:32:29 +0800 Message-ID: References: <20191106133531.693-1-jasowang@redhat.com> <20191106133531.693-7-jasowang@redhat.com> <20191107040700-mutt-send-email-mst@kernel.org> <20191107061942-mutt-send-email-mst@kernel.org> <20191107080834-mutt-send-email-mst@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <20191107080834-mutt-send-email-mst@kernel.org> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: "Michael S. Tsirkin" Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com, alex.williamson@redhat.com, tiwei.bie@intel.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, cohuck@redhat.com, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, haotian.wang@sifive.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com, heiko.carstens@de.ibm.com, gor@linux.ib List-Id: dri-devel@lists.freedesktop.org On 2019/11/7 =E4=B8=8B=E5=8D=889:08, Michael S. Tsirkin wrote: > On Thu, Nov 07, 2019 at 08:43:29PM +0800, Jason Wang wrote: >> On 2019/11/7 =E4=B8=8B=E5=8D=887:21, Michael S. Tsirkin wrote: >>> On Thu, Nov 07, 2019 at 06:18:45PM +0800, Jason Wang wrote: >>>> On 2019/11/7 =E4=B8=8B=E5=8D=885:08, Michael S. Tsirkin wrote: >>>>> On Wed, Nov 06, 2019 at 09:35:31PM +0800, Jason Wang wrote: >>>>>> This sample driver creates mdev device that simulate virtio net devi= ce >>>>>> over virtio mdev transport. The device is implemented through vringh >>>>>> and workqueue. A device specific dma ops is to make sure HVA is used >>>>>> directly as the IOVA. This should be sufficient for kernel virtio >>>>>> driver to work. >>>>>> >>>>>> Only 'virtio' type is supported right now. I plan to add 'vhost' typ= e >>>>>> on top which requires some virtual IOMMU implemented in this sample >>>>>> driver. >>>>>> >>>>>> Acked-by: Cornelia Huck >>>>>> Signed-off-by: Jason Wang >>>>> I'd prefer it that we call this something else, e.g. >>>>> mvnet-loopback. Just so people don't expect a fully >>>>> functional device somehow. Can be renamed when applying? >>>> Actually, I plan to extend it as another standard network interface fo= r >>>> kernel. It could be either a standalone pseudo device or a stack devic= e. >>>> Does this sounds good to you? >>>> >>>> Thanks >>> That's a big change in an interface so it's a good reason >>> to rename the driver at that point right? >>> Oherwise users of an old kernel would expect a stacked driver >>> and get a loopback instead. >>> >>> Or did I miss something? >> >> My understanding is that it was a sample driver in /doc. It should not b= e >> used in production environment. Otherwise we need to move it to >> driver/virtio. >> >> But if you insist, I can post a V11. >> >> Thanks > this can be a patch on top. Then maybe it's better just extend it to work as a normal networking=20 device on top? Thanks From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFAABC5DF61 for ; Thu, 7 Nov 2019 13:33:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AF2E52187F for ; Thu, 7 Nov 2019 13:33:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AF2E52187F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B65186EB55; Thu, 7 Nov 2019 13:33:08 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id D59C46EB55 for ; Thu, 7 Nov 2019 13:33:07 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-51-OCtDdWVKNrKS2VpNpFxOEw-1; Thu, 07 Nov 2019 08:33:00 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CA6831005500; Thu, 7 Nov 2019 13:32:56 +0000 (UTC) Received: from [10.72.12.21] (ovpn-12-21.pek2.redhat.com [10.72.12.21]) by smtp.corp.redhat.com (Postfix) with ESMTP id D50B360BE0; Thu, 7 Nov 2019 13:32:30 +0000 (UTC) Subject: Re: [PATCH V10 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework To: "Michael S. Tsirkin" References: <20191106133531.693-1-jasowang@redhat.com> <20191106133531.693-7-jasowang@redhat.com> <20191107040700-mutt-send-email-mst@kernel.org> <20191107061942-mutt-send-email-mst@kernel.org> <20191107080834-mutt-send-email-mst@kernel.org> From: Jason Wang Message-ID: Date: Thu, 7 Nov 2019 21:32:29 +0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20191107080834-mutt-send-email-mst@kernel.org> Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-MC-Unique: OCtDdWVKNrKS2VpNpFxOEw-1 X-Mimecast-Spam-Score: 0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1573133586; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wtVPfNetgN4OJ+kdxUdEeGOlhfhZVM+OtnzXrAWUlvU=; b=JuKqHTEXHI2vUrDRLUkSdATj5JdKDdInnR2XJbmlW+FBegts6jggMCiQSF0xflxt1hEouh zA2GWpuXUNKII8/wN7BhsRPB1UJoqM0cY44blFgyHxdAKYlk0oC+42Ywteb/v52DW0gWxd YFsyF6iQs1BgaZ5ujMHpNe46wxjHm4A= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: stefanha@redhat.com, christophe.de.dinechin@gmail.com, kvm@vger.kernel.org, airlied@linux.ie, heiko.carstens@de.ibm.com, kevin.tian@intel.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kwankhede@nvidia.com, rob.miller@broadcom.com, linux-s390@vger.kernel.org, sebott@linux.ibm.com, lulu@redhat.com, eperezma@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, haotian.wang@sifive.com, cunming.liang@intel.com, zhi.a.wang@intel.com, farman@linux.ibm.com, idos@mellanox.com, gor@linux.ibm.com, intel-gfx@lists.freedesktop.org, alex.williamson@redhat.com, xiao.w.wang@intel.com, freude@linux.ibm.com, parav@mellanox.com, zhihong.wang@intel.com, rodrigo.vivi@intel.com, intel-gvt-dev@lists.freedesktop.org, akrowiak@linux.ibm.com, oberpar@linux.ibm.com, tiwei.bie@intel.com, netdev@vger.kernel.org, cohuck@redhat.com, linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, lingshan.zhu@intel.com Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191107133229.xDJEj_yjzP29ci-cmuUeLW7Oc9ow5aXR0RyaaqwA8hw@z> Ck9uIDIwMTkvMTEvNyDkuIvljYg5OjA4LCBNaWNoYWVsIFMuIFRzaXJraW4gd3JvdGU6Cj4gT24g VGh1LCBOb3YgMDcsIDIwMTkgYXQgMDg6NDM6MjlQTSArMDgwMCwgSmFzb24gV2FuZyB3cm90ZToK Pj4gT24gMjAxOS8xMS83IOS4i+WNiDc6MjEsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90ZToKPj4+ IE9uIFRodSwgTm92IDA3LCAyMDE5IGF0IDA2OjE4OjQ1UE0gKzA4MDAsIEphc29uIFdhbmcgd3Jv dGU6Cj4+Pj4gT24gMjAxOS8xMS83IOS4i+WNiDU6MDgsIE1pY2hhZWwgUy4gVHNpcmtpbiB3cm90 ZToKPj4+Pj4gT24gV2VkLCBOb3YgMDYsIDIwMTkgYXQgMDk6MzU6MzFQTSArMDgwMCwgSmFzb24g V2FuZyB3cm90ZToKPj4+Pj4+IFRoaXMgc2FtcGxlIGRyaXZlciBjcmVhdGVzIG1kZXYgZGV2aWNl IHRoYXQgc2ltdWxhdGUgdmlydGlvIG5ldCBkZXZpY2UKPj4+Pj4+IG92ZXIgdmlydGlvIG1kZXYg dHJhbnNwb3J0LiBUaGUgZGV2aWNlIGlzIGltcGxlbWVudGVkIHRocm91Z2ggdnJpbmdoCj4+Pj4+ PiBhbmQgd29ya3F1ZXVlLiBBIGRldmljZSBzcGVjaWZpYyBkbWEgb3BzIGlzIHRvIG1ha2Ugc3Vy ZSBIVkEgaXMgdXNlZAo+Pj4+Pj4gZGlyZWN0bHkgYXMgdGhlIElPVkEuIFRoaXMgc2hvdWxkIGJl IHN1ZmZpY2llbnQgZm9yIGtlcm5lbCB2aXJ0aW8KPj4+Pj4+IGRyaXZlciB0byB3b3JrLgo+Pj4+ Pj4KPj4+Pj4+IE9ubHkgJ3ZpcnRpbycgdHlwZSBpcyBzdXBwb3J0ZWQgcmlnaHQgbm93LiBJIHBs YW4gdG8gYWRkICd2aG9zdCcgdHlwZQo+Pj4+Pj4gb24gdG9wIHdoaWNoIHJlcXVpcmVzIHNvbWUg dmlydHVhbCBJT01NVSBpbXBsZW1lbnRlZCBpbiB0aGlzIHNhbXBsZQo+Pj4+Pj4gZHJpdmVyLgo+ Pj4+Pj4KPj4+Pj4+IEFja2VkLWJ5OiBDb3JuZWxpYSBIdWNrPGNvaHVja0ByZWRoYXQuY29tPgo+ Pj4+Pj4gU2lnbmVkLW9mZi1ieTogSmFzb24gV2FuZzxqYXNvd2FuZ0ByZWRoYXQuY29tPgo+Pj4+ PiBJJ2QgcHJlZmVyIGl0IHRoYXQgd2UgY2FsbCB0aGlzIHNvbWV0aGluZyBlbHNlLCBlLmcuCj4+ Pj4+IG12bmV0LWxvb3BiYWNrLiBKdXN0IHNvIHBlb3BsZSBkb24ndCBleHBlY3QgYSBmdWxseQo+ Pj4+PiBmdW5jdGlvbmFsIGRldmljZSBzb21laG93LiBDYW4gYmUgcmVuYW1lZCB3aGVuIGFwcGx5 aW5nPwo+Pj4+IEFjdHVhbGx5LCBJIHBsYW4gdG8gZXh0ZW5kIGl0IGFzIGFub3RoZXIgc3RhbmRh cmQgbmV0d29yayBpbnRlcmZhY2UgZm9yCj4+Pj4ga2VybmVsLiBJdCBjb3VsZCBiZSBlaXRoZXIg YSBzdGFuZGFsb25lIHBzZXVkbyBkZXZpY2Ugb3IgYSBzdGFjayBkZXZpY2UuCj4+Pj4gRG9lcyB0 aGlzIHNvdW5kcyBnb29kIHRvIHlvdT8KPj4+Pgo+Pj4+IFRoYW5rcwo+Pj4gVGhhdCdzIGEgYmln IGNoYW5nZSBpbiBhbiBpbnRlcmZhY2Ugc28gaXQncyBhIGdvb2QgcmVhc29uCj4+PiB0byByZW5h bWUgdGhlIGRyaXZlciBhdCB0aGF0IHBvaW50IHJpZ2h0Pwo+Pj4gT2hlcndpc2UgdXNlcnMgb2Yg YW4gb2xkIGtlcm5lbCB3b3VsZCBleHBlY3QgYSBzdGFja2VkIGRyaXZlcgo+Pj4gYW5kIGdldCBh IGxvb3BiYWNrIGluc3RlYWQuCj4+Pgo+Pj4gT3IgZGlkIEkgbWlzcyBzb21ldGhpbmc/Cj4+Cj4+ IE15IHVuZGVyc3RhbmRpbmcgaXMgdGhhdCBpdCB3YXMgYSBzYW1wbGUgZHJpdmVyIGluIC9kb2Mu IEl0IHNob3VsZCBub3QgYmUKPj4gdXNlZCBpbiBwcm9kdWN0aW9uIGVudmlyb25tZW50LiBPdGhl cndpc2Ugd2UgbmVlZCB0byBtb3ZlIGl0IHRvCj4+IGRyaXZlci92aXJ0aW8uCj4+Cj4+IEJ1dCBp ZiB5b3UgaW5zaXN0LCBJIGNhbiBwb3N0IGEgVjExLgo+Pgo+PiBUaGFua3MKPiB0aGlzIGNhbiBi ZSBhIHBhdGNoIG9uIHRvcC4KCgpUaGVuIG1heWJlIGl0J3MgYmV0dGVyIGp1c3QgZXh0ZW5kIGl0 IHRvIHdvcmsgYXMgYSBub3JtYWwgbmV0d29ya2luZyAKZGV2aWNlIG9uIHRvcD8KClRoYW5rcwoK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs