From: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
kraxel@redhat.com, airlied@redhat.com, daniel@ffwll.ch,
maxime.ripard@bootlin.com, sean@poorly.run, sam@ravnborg.org,
christian.koenig@amd.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/8] drm/ast: Unpin cursor BO during cleanup
Date: Wed, 5 Jun 2019 09:45:05 +0200 [thread overview]
Message-ID: <b2c1776f-c1b3-c6ce-db6a-8db247bc25f6@linux.intel.com> (raw)
In-Reply-To: <20190604154201.14460-2-tzimmermann@suse.de>
Op 04-06-2019 om 17:41 schreef Thomas Zimmermann:
> The unpin operation was missing from ast_cursor_fini(). Fixed now.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/ast/ast_mode.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/ast/ast_mode.c b/drivers/gpu/drm/ast/ast_mode.c
> index fb700d620b64..41741cd6cd15 100644
> --- a/drivers/gpu/drm/ast/ast_mode.c
> +++ b/drivers/gpu/drm/ast/ast_mode.c
> @@ -959,6 +959,7 @@ static void ast_cursor_fini(struct drm_device *dev)
> struct drm_gem_vram_object *gbo =
> drm_gem_vram_of_gem(ast->cursor_cache);
> drm_gem_vram_kunmap_at(gbo, &ast->cache_kmap);
> + drm_gem_vram_unpin(gbo);
> drm_gem_object_put_unlocked(ast->cursor_cache);
> }
>
Fixes tag?
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-06-05 7:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-04 15:41 Remove explicit locking and kmap arguments from GEM VRAM interface Thomas Zimmermann
2019-06-04 15:41 ` [PATCH 1/8] drm/ast: Unpin cursor BO during cleanup Thomas Zimmermann
2019-06-05 7:45 ` Maarten Lankhorst [this message]
2019-06-05 7:56 ` Thomas Zimmermann
2019-06-04 15:41 ` [PATCH 2/8] drm/ast: Remove obsolete or unused cursor state Thomas Zimmermann
2019-06-04 15:41 ` [PATCH 3/8] drm/ast: Pin and map cursor source BO during update Thomas Zimmermann
2019-06-04 15:41 ` [PATCH 4/8] drm/ast: Pin framebuffer BO during dirty update Thomas Zimmermann
2019-06-05 9:46 ` Gerd Hoffmann
2019-06-04 15:41 ` [PATCH 5/8] drm/mgag200: " Thomas Zimmermann
2019-06-04 15:41 ` [PATCH 6/8] drm/mgag200: Rewrite cursor handling Thomas Zimmermann
2019-06-05 9:58 ` Gerd Hoffmann
2019-06-11 12:31 ` Thomas Zimmermann
2019-06-11 15:33 ` Daniel Vetter
2019-06-12 7:27 ` Thomas Zimmermann
2019-06-12 14:36 ` Daniel Vetter
2019-06-04 15:42 ` [PATCH 7/8] drm: Remove lock interfaces from GEM VRAM helpers Thomas Zimmermann
2019-06-04 15:42 ` [PATCH 8/8] drm: Remove functions with kmap-object argument " Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b2c1776f-c1b3-c6ce-db6a-8db247bc25f6@linux.intel.com \
--to=maarten.lankhorst@linux.intel.com \
--cc=airlied@redhat.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=maxime.ripard@bootlin.com \
--cc=sam@ravnborg.org \
--cc=sean@poorly.run \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox