Re: [v5,06/13] drm/ast: Rename struct ast_i2c_chan to struct ast_ddc

[Sui Jingfeng <sui.jingfeng@linux.dev>]

Hi,


On 2024/3/21 16:13, Thomas Zimmermann wrote:
> Hi
>
> Am 20.03.24 um 18:32 schrieb Sui Jingfeng:
>> Hi,
>>
>>
>> On 2024/3/20 17:34, Thomas Zimmermann wrote:
>>> The struct struct ast_i2c_chan represents the Display Data Channel
>>> (DDC); I2C is the underlying bus. Rename the structure, the variables
>>> and the helper ast_i2c_create() to ddc-like terms. No functional
>>> changes.
>>>
>>> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>>
>>
>> Personally, I think _i2c_ is better name than _ddc_. Because It seems 
>> that
>> the Display Data Channel is comes from VESA standard, while aspeed 
>> I2C can
>> be used to configure the external display bridges(encoder). So _i2c_ 
>> is a
>> *abstract* name, and can be utilized to do something else beyond the DDC
>> itself.
>
> This specific instance of i2c is for DDC; even the AST manual refers 
> to it as DDC. I don't think there's anything else we could do with 
> those registers. If we have other uses for i2c, we can easily add them 
> in separate code.
>
>>
>>
>> Reviewed-by: Sui Jingfeng <sui.jingfeng@linux.dev>
>
> Thanks for reviewing the series. I think the new helper in patch 12 
> could be useful for loongson [1][2] as well.
>

Yes, after this series landed. I'm going to post a few patch to remove some boilerplate.
I want to follow as well, but need a period of time. I have tested the whole series with
ast 2600 dGPU, the /sys/class/.../status will reflect the physical hut-plug status.


> Best regards
> Thomas
>
> [1] 
> https://elixir.bootlin.com/linux/v6.8/source/drivers/gpu/drm/loongson/lsdc_output_7a1000.c#L80
> [2] 
> https://elixir.bootlin.com/linux/v6.8/source/drivers/gpu/drm/loongson/lsdc_output_7a2000.c#L177
>

-- 
Best regards,
Sui