From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10BFBCD1284 for ; Tue, 9 Apr 2024 08:35:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 45EC7112BA8; Tue, 9 Apr 2024 08:35:55 +0000 (UTC) Received: from riemann.telenet-ops.be (riemann.telenet-ops.be [195.130.137.80]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2AC3B112BA8 for ; Tue, 9 Apr 2024 08:35:52 +0000 (UTC) Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by riemann.telenet-ops.be (Postfix) with ESMTPS id 4VDK6Z4gSGz4wwcw for ; Tue, 09 Apr 2024 10:35:50 +0200 (CEST) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed80:76d0:2bff:fec8:549]) by andre.telenet-ops.be with bizsmtp id 8wbp2C00C0SSLxL01wbppr; Tue, 09 Apr 2024 10:35:50 +0200 Received: from geert (helo=localhost) by ramsan.of.borg with local-esmtp (Exim 4.95) (envelope-from ) id 1ru6xJ-00CuUk-Ae; Tue, 09 Apr 2024 10:35:49 +0200 Date: Tue, 9 Apr 2024 10:35:49 +0200 (CEST) From: Geert Uytterhoeven To: Maxime Ripard cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Daniel Vetter , Jani Nikula , dri-devel@lists.freedesktop.org, Jani Nikula , linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v3 09/13] drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on In-Reply-To: <20240327-kms-kconfig-helpers-v3-9-eafee11b84b3@kernel.org> Message-ID: References: <20240327-kms-kconfig-helpers-v3-0-eafee11b84b3@kernel.org> <20240327-kms-kconfig-helpers-v3-9-eafee11b84b3@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Maxime, Thanks for your patch, which is now commit 4d15125d7fe637f4 ("drm: Switch DRM_DISPLAY_DP_AUX_BUS to depends on") in drm/drm-next (next-20240402 and later). On Wed, 27 Mar 2024, Maxime Ripard wrote: > Most of our helpers have relied on being selected so far through > Kconfig, but that creates issues when we have multiple layers of helpers > with some depending on others. > > Indeed, select doesn't select a dependency's dependencies, and thus > isn't super intuitive. Depends on however doesn't have that limitation, (Almost?) Everywhere else we fixed that by also selecting the dependencies, which is more user-friendly. > so we can just switch all the drivers that were selecting > DRM_DISPLAY_DP_AUX_BUS to depend on it. > > Reviewed-by: Jani Nikula > Signed-off-by: Maxime Ripard > --- a/drivers/gpu/drm/display/Kconfig > +++ b/drivers/gpu/drm/display/Kconfig > @@ -9,10 +9,11 @@ config DRM_DISPLAY_HELPER > > config DRM_DISPLAY_DP_AUX_BUS > tristate "DRM DisplayPort AUX bus support" > depends on DRM > depends on OF || COMPILE_TEST > + default y (quoting Linus) "What is so special about your driver, that it needs to default to enabled?". Especially as there is no help available for this option, so the casual user has no idea if this is needed or not. And a general comment for this series: many defconfigs need to be updated, as drivers are no longer enabled because they need functionality that now needs to be enabled explicitly. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds