From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D41A0C3ABCC for ; Wed, 14 May 2025 15:08:26 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 41F3D10E284; Wed, 14 May 2025 15:08:26 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="aWN/WMdW"; dkim-atps=neutral Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02A6510E284 for ; Wed, 14 May 2025 15:08:25 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2A84D5C5AA8; Wed, 14 May 2025 15:06:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B9C5C4CEE3; Wed, 14 May 2025 15:08:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1747235304; bh=NwS1B7xosoDUO5tvEbjazSqGCbiVpg+Ub8mt/kAm3Y8=; h=Date:From:To:Subject:In-Reply-To:References:Cc:From; b=aWN/WMdWE1PCBthnaJXqUMGe1aMIEUcwedLYmMvOqp3gLpWVWDULMhgOdOssGYL7F Ux6eqGHwcD25ra82uYyaDFCffC2Hjg5eRVBd8Zjg5WPp5nERBe0jZ9HNwKk1CGWsmu uRP850sK2HnKUiT6TA1rchg/P9bA/ZNZwPV3d9cJwyNkUUVEXK6YX68PF3sF/63PnW s2YT/hITmGfEmg5iRSqgvGnZ7RwFDACT2KJDDnzuxEi3qMDTccfiM5mzq2xtlG7RQf JURaUBMP/w/k11jm6RWzkMUlRkrrZGsQu0rLJkL6WhPF4xn3EpzhKYLRj6brxaJO5k KVUXH2Uc2g+VQ== Message-ID: Date: Wed, 14 May 2025 15:08:20 +0000 From: "Maxime Ripard" To: "Ryan Walklin" Subject: Re: [PATCH v10 02/11] drm: sun4i: de2/de3: refactor mixer initialisation In-Reply-To: <20250511104042.24249-3-ryan@testtoast.com> References: <20250511104042.24249-3-ryan@testtoast.com> Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-sunxi@lists.linux.dev, "Andre Przywara" , "Chen-Yu Tsai" , "Chris Morgan" , "Conor Dooley" , "Daniel Vetter" , "David Airlie" , "Dmitry Baryshkov" , "Hironori KIKUCHI" , "Jernej Skrabec" , "Krzysztof Kozlowski" , "Maarten Lankhorst" , "Maxime Ripard" , "Michael Turquette" , "Philippe Simons" , "Rob Herring" , "Samuel Holland" , "Stephen Boyd" , "Thomas Zimmermann" Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, 11 May 2025 22:31:11 +1200, Ryan Walklin wrote: > From: Jernej Skrabec > > Now that the DE variant can be selected by enum, take the oppportunity > to factor out some common initialisation code to a separate function. > > > [ ... ] Acked-by: Maxime Ripard Thanks! Maxime