* Re: linux-next: Tree for Jul 29 (BACKLIGHT_KTD2801) [not found] <20250729153510.3781ac91@canb.auug.org.au> @ 2025-07-29 8:32 ` Randy Dunlap 2025-07-29 9:18 ` Duje Mihanović 0 siblings, 1 reply; 3+ messages in thread From: Randy Dunlap @ 2025-07-29 8:32 UTC (permalink / raw) To: Stephen Rothwell, Linux Next Mailing List Cc: Linux Kernel Mailing List, Duje Mihanović, Linux DRI Development, linux-leds On 7/28/25 10:35 PM, Stephen Rothwell wrote: > Hi all, > > Changes since 20250728: > on ARCH=um SUBARCH=i386, when # CONFIG_GPIOLIB is not set WARNING: unmet direct dependencies detected for LEDS_EXPRESSWIRE Depends on [n]: GPIOLIB [=n] || NEW_LEDS [=y] && GPIOLIB [=n] Selected by [y]: - BACKLIGHT_KTD2801 [=y] && HAS_IOMEM [=y] && BACKLIGHT_CLASS_DEVICE [=y] so BACKLIGHT_KTD2801 should: depends on GPIOLIB Also, in drivers/leds/Kconfig, does it need duplicate entries for this? Can't the second entry be removed? (asking since Duje made both entries) config LEDS_EXPRESSWIRE bool depends on GPIOLIB Thanks. -- ~Randy ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Jul 29 (BACKLIGHT_KTD2801) 2025-07-29 8:32 ` linux-next: Tree for Jul 29 (BACKLIGHT_KTD2801) Randy Dunlap @ 2025-07-29 9:18 ` Duje Mihanović 2025-07-29 16:05 ` Randy Dunlap 0 siblings, 1 reply; 3+ messages in thread From: Duje Mihanović @ 2025-07-29 9:18 UTC (permalink / raw) To: Stephen Rothwell, Linux Next Mailing List, Randy Dunlap Cc: Linux Kernel Mailing List, Linux DRI Development, linux-leds On Tuesday, 29 July 2025 10:32:13 Central European Summer Time Randy Dunlap wrote: > so BACKLIGHT_KTD2801 should: > depends on GPIOLIB Sounds good to me. > Also, in drivers/leds/Kconfig, does it need duplicate entries for this? > Can't the second entry be removed? > (asking since Duje made both entries) That's an oversight on my end, and as such the second one (the one inside the "if NEW_LEDS" block) should be removed. Would you like me to send a patch to fix these? Regards, -- Duje ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: linux-next: Tree for Jul 29 (BACKLIGHT_KTD2801) 2025-07-29 9:18 ` Duje Mihanović @ 2025-07-29 16:05 ` Randy Dunlap 0 siblings, 0 replies; 3+ messages in thread From: Randy Dunlap @ 2025-07-29 16:05 UTC (permalink / raw) To: Duje Mihanović, Stephen Rothwell, Linux Next Mailing List Cc: Linux Kernel Mailing List, Linux DRI Development, linux-leds On July 29, 2025 2:18:16 AM PDT, "Duje Mihanović" <duje@dujemihanovic.xyz> wrote: >On Tuesday, 29 July 2025 10:32:13 Central European Summer Time Randy Dunlap >wrote: >> so BACKLIGHT_KTD2801 should: >> depends on GPIOLIB > >Sounds good to me. > >> Also, in drivers/leds/Kconfig, does it need duplicate entries for this? >> Can't the second entry be removed? >> (asking since Duje made both entries) > >That's an oversight on my end, and as such the second one (the one inside the >"if NEW_LEDS" block) should be removed. > >Would you like me to send a patch to fix these? Yes, please. Thanks. ~Randy ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-07-29 16:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20250729153510.3781ac91@canb.auug.org.au>
2025-07-29 8:32 ` linux-next: Tree for Jul 29 (BACKLIGHT_KTD2801) Randy Dunlap
2025-07-29 9:18 ` Duje Mihanović
2025-07-29 16:05 ` Randy Dunlap
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).